From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH v4 1/2] nvme: cache struct nvme_ctrl reference to struct nvme_request
Date: Tue, 26 Jun 2018 08:55:32 -0600 [thread overview]
Message-ID: <20180626145532.GA6628@localhost.localdomain> (raw)
In-Reply-To: <20180626135141.14088-2-jthumshirn@suse.de>
On Tue, Jun 26, 2018@03:51:40PM +0200, Johannes Thumshirn wrote:
> @@ -652,6 +653,7 @@ blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req,
> }
>
> cmd->common.command_id = req->tag;
> + nvme_req(req)->ctrl = ctrl;
> if (ns)
> trace_nvme_setup_nvm_cmd(req->q->id, cmd);
> else
I don't think we need to do this per-io. The request coming from the
controller's tagset, so we can do this just once at .init_request time,
right?
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@linux.intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@intel.com>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v4 1/2] nvme: cache struct nvme_ctrl reference to struct nvme_request
Date: Tue, 26 Jun 2018 08:55:32 -0600 [thread overview]
Message-ID: <20180626145532.GA6628@localhost.localdomain> (raw)
In-Reply-To: <20180626135141.14088-2-jthumshirn@suse.de>
On Tue, Jun 26, 2018 at 03:51:40PM +0200, Johannes Thumshirn wrote:
> @@ -652,6 +653,7 @@ blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req,
> }
>
> cmd->common.command_id = req->tag;
> + nvme_req(req)->ctrl = ctrl;
> if (ns)
> trace_nvme_setup_nvm_cmd(req->q->id, cmd);
> else
I don't think we need to do this per-io. The request coming from the
controller's tagset, so we can do this just once at .init_request time,
right?
next prev parent reply other threads:[~2018-06-26 14:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 13:51 [PATCH v4 0/2] nvme: add controller id and disk name to tracepoints Johannes Thumshirn
2018-06-26 13:51 ` Johannes Thumshirn
2018-06-26 13:51 ` [PATCH v4 1/2] nvme: cache struct nvme_ctrl reference to struct nvme_request Johannes Thumshirn
2018-06-26 13:51 ` Johannes Thumshirn
2018-06-26 14:55 ` Keith Busch [this message]
2018-06-26 14:55 ` Keith Busch
2018-06-27 7:35 ` Johannes Thumshirn
2018-06-27 7:35 ` Johannes Thumshirn
2018-06-27 8:45 ` Sagi Grimberg
2018-06-27 8:45 ` Sagi Grimberg
2018-06-26 13:51 ` [PATCH] nvme: trace: add disk name to tracepoints Johannes Thumshirn
2018-06-26 13:51 ` Johannes Thumshirn
2018-06-26 15:01 ` Keith Busch
2018-06-26 15:01 ` Keith Busch
2018-06-27 7:33 ` Johannes Thumshirn
2018-06-27 7:33 ` Johannes Thumshirn
2018-06-27 8:06 ` Sagi Grimberg
2018-06-27 8:06 ` Sagi Grimberg
2018-06-27 10:00 ` Johannes Thumshirn
2018-06-27 10:00 ` Johannes Thumshirn
2018-06-27 23:43 ` Keith Busch
2018-06-27 23:43 ` Keith Busch
2018-06-28 0:59 ` Keith Busch
2018-06-28 0:59 ` Keith Busch
2018-06-28 7:44 ` Johannes Thumshirn
2018-06-28 7:44 ` Johannes Thumshirn
2018-06-28 14:34 ` Sagi Grimberg
2018-06-28 14:34 ` Sagi Grimberg
2018-06-28 15:02 ` Keith Busch
2018-06-28 15:02 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626145532.GA6628@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.