From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: fstests@vger.kernel.org
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH v2] xfstests: fix install target using sudo
Date: Wed, 27 Jun 2018 09:03:55 -0700 [thread overview]
Message-ID: <20180627160355.10348-1-mcgrof@kernel.org> (raw)
If you install with:
sudo make install
Depending on the system, you may see that /var/lib/xfstests/ installed
properly but /var/lib/xfstests/tests/ is empty and so your install
really is broken and not functional. Finding out what went wrong is
not obvious.
The issue is caused due to the fact that $(PWD) is used nad if sudo is used
this can be empty on some systems.
PWD is only used on one target on the xfstests build system, the
tests/*/ dir install target.
We can fix this by using $(CURDIR) instead.
This issue is observed on both Fedora and OpenSUSE, but not on Debian.
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
tests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile b/tests/Makefile
index 2611b3b845f5..11164e9ec130 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -5,7 +5,7 @@
TOPDIR = ..
include $(TOPDIR)/include/builddefs
-TESTS_SUBDIRS = $(sort $(dir $(wildcard $(PWD)/$(TESTS_DIR)/[a-z]*/)))
+TESTS_SUBDIRS = $(sort $(dir $(wildcard $(CURDIR)/[a-z]*/)))
include $(BUILDRULES)
--
2.16.3
reply other threads:[~2018-06-27 16:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627160355.10348-1-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.