* [PATCH v2] xfstests: fix install target using sudo
@ 2018-06-27 16:03 Luis R. Rodriguez
0 siblings, 0 replies; only message in thread
From: Luis R. Rodriguez @ 2018-06-27 16:03 UTC (permalink / raw)
To: fstests; +Cc: Luis R. Rodriguez
If you install with:
sudo make install
Depending on the system, you may see that /var/lib/xfstests/ installed
properly but /var/lib/xfstests/tests/ is empty and so your install
really is broken and not functional. Finding out what went wrong is
not obvious.
The issue is caused due to the fact that $(PWD) is used nad if sudo is used
this can be empty on some systems.
PWD is only used on one target on the xfstests build system, the
tests/*/ dir install target.
We can fix this by using $(CURDIR) instead.
This issue is observed on both Fedora and OpenSUSE, but not on Debian.
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
tests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile b/tests/Makefile
index 2611b3b845f5..11164e9ec130 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -5,7 +5,7 @@
TOPDIR = ..
include $(TOPDIR)/include/builddefs
-TESTS_SUBDIRS = $(sort $(dir $(wildcard $(PWD)/$(TESTS_DIR)/[a-z]*/)))
+TESTS_SUBDIRS = $(sort $(dir $(wildcard $(CURDIR)/[a-z]*/)))
include $(BUILDRULES)
--
2.16.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-06-27 16:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-27 16:03 [PATCH v2] xfstests: fix install target using sudo Luis R. Rodriguez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.