All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	tglx@linutronix.de, "David S. Miller" <davem@davemloft.net>,
	linux-wireless@vger.kernel.org
Subject: [2/4] libertas_tf: use irqsave() in USB's complete callback
Date: Wed, 27 Jun 2018 16:13:57 +0000 (UTC)	[thread overview]
Message-ID: <20180627161357.103F360791@smtp.codeaurora.org> (raw)

Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:

> The USB completion callback does not disable interrupts while acquiring
> the lock. We want to remove the local_irq_disable() invocation from
> __usb_hcd_giveback_urb() and therefore it is required for the callback
> handler to disable the interrupts while acquiring the lock.
> The callback may be invoked either in IRQ or BH context depending on the
> USB host controller.
> Use the _irqsave() variant of the locking primitives.
> 
> I am removing the
> 	BUG_ON(!in_interrupt());
> 
> check because it serves no purpose. Running the completion callback in
> BH context makes in_interrupt() still return true but the interrupts
> could be enabled. The important part is that ->driver_lock is acquired
> with disabled interrupts which is the case now.
> 
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-wireless@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

3 patches applied to wireless-drivers-next.git, thanks.

fc75122fabb5 libertas_tf: use irqsave() in USB's complete callback
a3128feef6d5 libertas: use irqsave() in USB's complete callback
81454b8405f2 zd1211rw: use irqsave() in USB's complete callback

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
	tglx@linutronix.de, "David S. Miller" <davem@davemloft.net>,
	linux-wireless@vger.kernel.org,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [2/4] libertas_tf: use irqsave() in USB's complete callback
Date: Wed, 27 Jun 2018 16:13:57 +0000 (UTC)	[thread overview]
Message-ID: <20180627161357.103F360791@smtp.codeaurora.org> (raw)
In-Reply-To: <20180620193648.25136-3-bigeasy@linutronix.de>

Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:

> The USB completion callback does not disable interrupts while acquiring
> the lock. We want to remove the local_irq_disable() invocation from
> __usb_hcd_giveback_urb() and therefore it is required for the callback
> handler to disable the interrupts while acquiring the lock.
> The callback may be invoked either in IRQ or BH context depending on the
> USB host controller.
> Use the _irqsave() variant of the locking primitives.
> 
> I am removing the
> 	BUG_ON(!in_interrupt());
> 
> check because it serves no purpose. Running the completion callback in
> BH context makes in_interrupt() still return true but the interrupts
> could be enabled. The important part is that ->driver_lock is acquired
> with disabled interrupts which is the case now.
> 
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-wireless@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

3 patches applied to wireless-drivers-next.git, thanks.

fc75122fabb5 libertas_tf: use irqsave() in USB's complete callback
a3128feef6d5 libertas: use irqsave() in USB's complete callback
81454b8405f2 zd1211rw: use irqsave() in USB's complete callback

-- 
https://patchwork.kernel.org/patch/10478609/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

             reply	other threads:[~2018-06-27 16:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27 16:13 Kalle Valo [this message]
2018-06-27 16:13 ` [2/4] libertas_tf: use irqsave() in USB's complete callback Kalle Valo
  -- strict thread matches above, loose matches on Subject: below --
2018-06-29 11:56 [1/4] ath9k: " Kalle Valo
2018-06-29 11:56 ` Kalle Valo
2018-06-20 19:36 [4/4] zd1211rw: " Sebastian Andrzej Siewior
2018-06-20 19:36 ` [PATCH 4/4] " Sebastian Andrzej Siewior
2018-06-20 19:36 ` Sebastian Andrzej Siewior
2018-06-20 19:36 [3/4] libertas: " Sebastian Andrzej Siewior
2018-06-20 19:36 ` [PATCH 3/4] " Sebastian Andrzej Siewior
2018-06-20 19:36 ` Sebastian Andrzej Siewior
2018-06-20 19:36 [2/4] libertas_tf: " Sebastian Andrzej Siewior
2018-06-20 19:36 ` [PATCH 2/4] " Sebastian Andrzej Siewior
2018-06-20 19:36 ` Sebastian Andrzej Siewior
2018-06-20 19:36 [1/4] ath9k: " Sebastian Andrzej Siewior
2018-06-20 19:36 ` [PATCH 1/4] " Sebastian Andrzej Siewior
2018-06-20 19:36 ` Sebastian Andrzej Siewior
2018-06-20 19:36 [PATCH 0/4] wireless: Use irqsave " Sebastian Andrzej Siewior
2018-06-20 19:36 ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180627161357.103F360791@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.