From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: remove no-op -p linker flag
Date: Thu, 28 Jun 2018 10:39:29 +0100 [thread overview]
Message-ID: <20180628093928.GB10751@arm.com> (raw)
In-Reply-To: <20180627194614.188210-1-ghackmann@google.com>
On Wed, Jun 27, 2018 at 12:46:14PM -0700, Greg Hackmann wrote:
> Linking the ARM64 defconfig kernel with LLVM lld fails with the error:
>
> ld.lld: error: unknown argument: -p
> Makefile:1015: recipe for target 'vmlinux' failed
>
> Without this flag, the ARM64 defconfig kernel successfully links with
> lld and boots on Dragonboard 410c.
>
> After digging through binutils source and changelogs, it turns out that
> -p is only relevant to ancient binutils installations targeting 32-bit
> ARM. binutils accepts -p for AArch64 too, but it's always been
> undocumented and silently ignored. A comment in
> ld/emultempl/aarch64elf.em explains that it's "Only here for backwards
> compatibility".
>
> Since this flag is a no-op on ARM64, we can safely drop it.
Makes sense:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Greg Hackmann <ghackmann@android.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, ndesaulniers@google.com,
mka@chromium.org, Greg Hackmann <ghackmann@google.com>
Subject: Re: [PATCH] arm64: remove no-op -p linker flag
Date: Thu, 28 Jun 2018 10:39:29 +0100 [thread overview]
Message-ID: <20180628093928.GB10751@arm.com> (raw)
In-Reply-To: <20180627194614.188210-1-ghackmann@google.com>
On Wed, Jun 27, 2018 at 12:46:14PM -0700, Greg Hackmann wrote:
> Linking the ARM64 defconfig kernel with LLVM lld fails with the error:
>
> ld.lld: error: unknown argument: -p
> Makefile:1015: recipe for target 'vmlinux' failed
>
> Without this flag, the ARM64 defconfig kernel successfully links with
> lld and boots on Dragonboard 410c.
>
> After digging through binutils source and changelogs, it turns out that
> -p is only relevant to ancient binutils installations targeting 32-bit
> ARM. binutils accepts -p for AArch64 too, but it's always been
> undocumented and silently ignored. A comment in
> ld/emultempl/aarch64elf.em explains that it's "Only here for backwards
> compatibility".
>
> Since this flag is a no-op on ARM64, we can safely drop it.
Makes sense:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2018-06-28 9:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 19:46 [PATCH] arm64: remove no-op -p linker flag Greg Hackmann
2018-06-27 19:46 ` Greg Hackmann
2018-06-28 9:39 ` Will Deacon [this message]
2018-06-28 9:39 ` Will Deacon
2018-06-28 12:40 ` Nick Desaulniers
2018-06-28 12:40 ` Nick Desaulniers
-- strict thread matches above, loose matches on Subject: below --
2018-11-27 19:15 ndesaulniers
2018-11-28 16:07 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628093928.GB10751@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.