From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH v5 2/2] nvme: trace: add disk name to tracepoints
Date: Thu, 28 Jun 2018 14:55:59 -0600 [thread overview]
Message-ID: <20180628205559.GD12970@localhost.localdomain> (raw)
In-Reply-To: <20180628074824.crqwgdlnrqt34s3d@linux-x5ow.site>
On Thu, Jun 28, 2018@09:48:24AM +0200, Johannes Thumshirn wrote:
> On Wed, Jun 27, 2018@10:37:06AM -0600, Keith Busch wrote:
> > It looks like you want the # assigned to /dev/nvme<#>. Do you want to
> > use ctrl->instance here instead?
>
> Right.
>
> As it'll conflict with your other trace patch do you want me to wait
> with the resend?
I tried to merge your disk names but it got substantially different
after I combined the two submission trace points into one (I sort of
prefer having only one). I'm about to send it out, and I hope I was able
to preserve your intention, but please have a look and let me know.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@linux.intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
James Smart <james.smart@broadcom.com>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Keith Busch <keith.busch@intel.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v5 2/2] nvme: trace: add disk name to tracepoints
Date: Thu, 28 Jun 2018 14:55:59 -0600 [thread overview]
Message-ID: <20180628205559.GD12970@localhost.localdomain> (raw)
In-Reply-To: <20180628074824.crqwgdlnrqt34s3d@linux-x5ow.site>
On Thu, Jun 28, 2018 at 09:48:24AM +0200, Johannes Thumshirn wrote:
> On Wed, Jun 27, 2018 at 10:37:06AM -0600, Keith Busch wrote:
> > It looks like you want the # assigned to /dev/nvme<#>. Do you want to
> > use ctrl->instance here instead?
>
> Right.
>
> As it'll conflict with your other trace patch do you want me to wait
> with the resend?
I tried to merge your disk names but it got substantially different
after I combined the two submission trace points into one (I sort of
prefer having only one). I'm about to send it out, and I hope I was able
to preserve your intention, but please have a look and let me know.
next prev parent reply other threads:[~2018-06-28 20:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 12:53 [PATCH v5 0/2] nvme: add controller id and disk name to tracepoints Johannes Thumshirn
2018-06-27 12:53 ` Johannes Thumshirn
2018-06-27 12:53 ` [PATCH v5 1/2] nvme: cache struct nvme_ctrl reference to struct nvme_request Johannes Thumshirn
2018-06-27 12:53 ` Johannes Thumshirn
2018-06-27 16:40 ` James Smart
2018-06-27 16:40 ` James Smart
2018-06-27 12:53 ` [PATCH v5 2/2] nvme: trace: add disk name to tracepoints Johannes Thumshirn
2018-06-27 12:53 ` Johannes Thumshirn
2018-06-27 16:37 ` Keith Busch
2018-06-27 16:37 ` Keith Busch
2018-06-28 7:48 ` Johannes Thumshirn
2018-06-28 7:48 ` Johannes Thumshirn
2018-06-28 20:55 ` Keith Busch [this message]
2018-06-28 20:55 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628205559.GD12970@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.