From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PCI: endpoint: use after free in pci_epf_unregister_driver()
Date: Fri, 29 Jun 2018 13:47:15 +0000 [thread overview]
Message-ID: <20180629134715.GG9643@red-moon> (raw)
In-Reply-To: <20180531062148.qnhcnnibz2ql6soa@kili.mountain>
On Thu, May 31, 2018 at 09:21:48AM +0300, Dan Carpenter wrote:
> We need to use list_for_each_entry_safe() because the
> pci_ep_cfs_remove_epf_group() function frees "group".
>
> Fixes: ef1433f717a2 ("PCI: endpoint: Create configfs entry for each pci_epf_device_id table entry")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c
Applied to pci/controller-fixes to be tentatively merged for -rc4,
thanks.
Lorenzo
> index 523a8cab3bfb..bf53fad636a5 100644
> --- a/drivers/pci/endpoint/pci-epf-core.c
> +++ b/drivers/pci/endpoint/pci-epf-core.c
> @@ -145,10 +145,10 @@ EXPORT_SYMBOL_GPL(pci_epf_alloc_space);
> */
> void pci_epf_unregister_driver(struct pci_epf_driver *driver)
> {
> - struct config_group *group;
> + struct config_group *group, *tmp;
>
> mutex_lock(&pci_epf_mutex);
> - list_for_each_entry(group, &driver->epf_group, group_entry)
> + list_for_each_entry_safe(group, tmp, &driver->epf_group, group_entry)
> pci_ep_cfs_remove_epf_group(group);
> list_del(&driver->epf_group);
> mutex_unlock(&pci_epf_mutex);
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PCI: endpoint: use after free in pci_epf_unregister_driver()
Date: Fri, 29 Jun 2018 14:47:15 +0100 [thread overview]
Message-ID: <20180629134715.GG9643@red-moon> (raw)
In-Reply-To: <20180531062148.qnhcnnibz2ql6soa@kili.mountain>
On Thu, May 31, 2018 at 09:21:48AM +0300, Dan Carpenter wrote:
> We need to use list_for_each_entry_safe() because the
> pci_ep_cfs_remove_epf_group() function frees "group".
>
> Fixes: ef1433f717a2 ("PCI: endpoint: Create configfs entry for each pci_epf_device_id table entry")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c
Applied to pci/controller-fixes to be tentatively merged for -rc4,
thanks.
Lorenzo
> index 523a8cab3bfb..bf53fad636a5 100644
> --- a/drivers/pci/endpoint/pci-epf-core.c
> +++ b/drivers/pci/endpoint/pci-epf-core.c
> @@ -145,10 +145,10 @@ EXPORT_SYMBOL_GPL(pci_epf_alloc_space);
> */
> void pci_epf_unregister_driver(struct pci_epf_driver *driver)
> {
> - struct config_group *group;
> + struct config_group *group, *tmp;
>
> mutex_lock(&pci_epf_mutex);
> - list_for_each_entry(group, &driver->epf_group, group_entry)
> + list_for_each_entry_safe(group, tmp, &driver->epf_group, group_entry)
> pci_ep_cfs_remove_epf_group(group);
> list_del(&driver->epf_group);
> mutex_unlock(&pci_epf_mutex);
next prev parent reply other threads:[~2018-06-29 13:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 6:21 [PATCH] PCI: endpoint: use after free in pci_epf_unregister_driver() Dan Carpenter
2018-05-31 6:21 ` Dan Carpenter
2018-06-29 10:00 ` Lorenzo Pieralisi
2018-06-29 10:00 ` Lorenzo Pieralisi
2018-06-29 10:00 ` Kishon Vijay Abraham I
2018-06-29 10:12 ` Kishon Vijay Abraham I
2018-06-29 13:47 ` Lorenzo Pieralisi [this message]
2018-06-29 13:47 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629134715.GG9643@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.