From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl
Date: Sun, 1 Jul 2018 11:20:29 +0800 [thread overview]
Message-ID: <20180701032028.GF4348@dragon> (raw)
In-Reply-To: <20180621181000.12687-1-nick@shmanahar.org>
On Thu, Jun 21, 2018 at 07:10:00PM +0100, Nick Dyer wrote:
> The pinctrl settings were incorrect for the touchscreen interrupt line, causing
> an interrupt storm. This change has been tested with both the atmel_mxt_ts and
> RMI4 drivers on the RDU1 units.
>
> The value 0x4 comes from the value of register IOMUXC_SW_PAD_CTL_PAD_CSI1_D8
> from the old vendor kernel.
>
> Signed-off-by: Nick Dyer <nick@shmanahar.org>
> Fixes: ceef0396f367 ("ARM: dts: imx: add ZII RDU1 board")
> Cc: <stable@vger.kernel.org> # 4.15+
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> Tested-by: Chris Healy <cphealy@gmail.com>
Applied, thanks.
> ---
> Changes in v5:
> - Add tested by Chris Healy
> Changes in v4:
> - Add reviewed by Fabio
You do not have to send new version just for collecting review and test
tags. I will do that when applying.
Shawn
> Changes in v3:
> - Update commit message to add source of 0x4 value, fixes tag and CC stable
> Changes in v2:
> - Use hex, only alter IRQ line config
>
> arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> index df9eca94d812..8a878687197b 100644
> --- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
> +++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> @@ -770,7 +770,7 @@
>
> pinctrl_ts: tsgrp {
> fsl,pins = <
> - MX51_PAD_CSI1_D8__GPIO3_12 0x85
> + MX51_PAD_CSI1_D8__GPIO3_12 0x04
> MX51_PAD_CSI1_D9__GPIO3_13 0x85
> >;
> };
> --
> 2.17.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Nick Dyer <nick@shmanahar.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Fabio Estevam <festevam@gmail.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Chris Healy <cphealy@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
stable@vger.kernel.org
Subject: Re: [PATCH v5] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl
Date: Sun, 1 Jul 2018 11:20:29 +0800 [thread overview]
Message-ID: <20180701032028.GF4348@dragon> (raw)
In-Reply-To: <20180621181000.12687-1-nick@shmanahar.org>
On Thu, Jun 21, 2018 at 07:10:00PM +0100, Nick Dyer wrote:
> The pinctrl settings were incorrect for the touchscreen interrupt line, causing
> an interrupt storm. This change has been tested with both the atmel_mxt_ts and
> RMI4 drivers on the RDU1 units.
>
> The value 0x4 comes from the value of register IOMUXC_SW_PAD_CTL_PAD_CSI1_D8
> from the old vendor kernel.
>
> Signed-off-by: Nick Dyer <nick@shmanahar.org>
> Fixes: ceef0396f367 ("ARM: dts: imx: add ZII RDU1 board")
> Cc: <stable@vger.kernel.org> # 4.15+
> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
> Tested-by: Chris Healy <cphealy@gmail.com>
Applied, thanks.
> ---
> Changes in v5:
> - Add tested by Chris Healy
> Changes in v4:
> - Add reviewed by Fabio
You do not have to send new version just for collecting review and test
tags. I will do that when applying.
Shawn
> Changes in v3:
> - Update commit message to add source of 0x4 value, fixes tag and CC stable
> Changes in v2:
> - Use hex, only alter IRQ line config
>
> arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> index df9eca94d812..8a878687197b 100644
> --- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
> +++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> @@ -770,7 +770,7 @@
>
> pinctrl_ts: tsgrp {
> fsl,pins = <
> - MX51_PAD_CSI1_D8__GPIO3_12 0x85
> + MX51_PAD_CSI1_D8__GPIO3_12 0x04
> MX51_PAD_CSI1_D9__GPIO3_13 0x85
> >;
> };
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-07-01 3:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 19:42 [PATCH v2] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl Nick Dyer
2018-06-20 19:42 ` Nick Dyer
2018-06-20 20:20 ` [PATCH v3] " Nick Dyer
2018-06-20 20:20 ` Nick Dyer
2018-06-20 20:31 ` Fabio Estevam
2018-06-20 20:31 ` Fabio Estevam
2018-06-20 20:35 ` [PATCH v4] " Nick Dyer
2018-06-20 20:35 ` Nick Dyer
2018-06-21 4:22 ` Chris Healy
2018-06-21 4:22 ` Chris Healy
2018-06-21 18:10 ` [PATCH v5] " Nick Dyer
2018-06-21 18:10 ` Nick Dyer
2018-07-01 3:20 ` Shawn Guo [this message]
2018-07-01 3:20 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180701032028.GF4348@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.