All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 5/5] net: gemini: Indicate that we can handle jumboframes
Date: Sun, 1 Jul 2018 09:58:54 +0200	[thread overview]
Message-ID: <20180701075854.GB15006@lunn.ch> (raw)
In-Reply-To: <20180630161806.24312-5-linus.walleij@linaro.org>

On Sat, Jun 30, 2018 at 06:18:06PM +0200, Linus Walleij wrote:
> The hardware supposedly handles frames up to 10236 bytes and
> implements .ndo_change_mtu() so accept 10236 minus the ethernet
> header for a VLAN tagged frame on the netdevices.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/net/ethernet/cortina/gemini.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
> index 79324bbfd768..ae475393e4ac 100644
> --- a/drivers/net/ethernet/cortina/gemini.c
> +++ b/drivers/net/ethernet/cortina/gemini.c
> @@ -2473,6 +2473,11 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
>  
>  	netdev->hw_features = GMAC_OFFLOAD_FEATURES;
>  	netdev->features |= GMAC_OFFLOAD_FEATURES | NETIF_F_GRO;
> +	/* We can handle jumbo frames up to 10236 bytes so, let's accept
> +	 * payloads of 10236 bytes minus VLAN and ethernet header
> +	 */
> +	netdev->min_mtu = 256;
> +	netdev->max_mtu = 10236 - VLAN_ETH_HLEN;

Hi Linus

The commit message does not mention the min mtu you set here. Where
does 256 come from?

Thanks
     Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"Janos Laube" <janos.dev@gmail.com>,
	"Paulius Zaleckas" <paulius.zaleckas@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	"Hans Ulli Kroll" <ulli.kroll@googlemail.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 5/5] net: gemini: Indicate that we can handle jumboframes
Date: Sun, 1 Jul 2018 09:58:54 +0200	[thread overview]
Message-ID: <20180701075854.GB15006@lunn.ch> (raw)
In-Reply-To: <20180630161806.24312-5-linus.walleij@linaro.org>

On Sat, Jun 30, 2018 at 06:18:06PM +0200, Linus Walleij wrote:
> The hardware supposedly handles frames up to 10236 bytes and
> implements .ndo_change_mtu() so accept 10236 minus the ethernet
> header for a VLAN tagged frame on the netdevices.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/net/ethernet/cortina/gemini.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
> index 79324bbfd768..ae475393e4ac 100644
> --- a/drivers/net/ethernet/cortina/gemini.c
> +++ b/drivers/net/ethernet/cortina/gemini.c
> @@ -2473,6 +2473,11 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
>  
>  	netdev->hw_features = GMAC_OFFLOAD_FEATURES;
>  	netdev->features |= GMAC_OFFLOAD_FEATURES | NETIF_F_GRO;
> +	/* We can handle jumbo frames up to 10236 bytes so, let's accept
> +	 * payloads of 10236 bytes minus VLAN and ethernet header
> +	 */
> +	netdev->min_mtu = 256;
> +	netdev->max_mtu = 10236 - VLAN_ETH_HLEN;

Hi Linus

The commit message does not mention the min mtu you set here. Where
does 256 come from?

Thanks
     Andrew

  reply	other threads:[~2018-07-01  7:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-30 16:18 [PATCH net-next 1/5] net: gemini: Look up L3 maxlen from table Linus Walleij
2018-06-30 16:18 ` Linus Walleij
2018-06-30 16:18 ` [PATCH net-next 2/5] net: gemini: Improve connection prints Linus Walleij
2018-06-30 16:18   ` Linus Walleij
2018-07-01  7:54   ` Andrew Lunn
2018-07-01  7:54     ` Andrew Lunn
2018-06-30 16:18 ` [PATCH net-next 3/5] net: gemini: Allow multiple ports to instantiate Linus Walleij
2018-06-30 16:18   ` Linus Walleij
2018-06-30 16:18 ` [PATCH net-next 4/5] net: gemini: Move main init to port Linus Walleij
2018-06-30 16:18   ` Linus Walleij
2018-06-30 16:18 ` [PATCH net-next 5/5] net: gemini: Indicate that we can handle jumboframes Linus Walleij
2018-06-30 16:18   ` Linus Walleij
2018-07-01  7:58   ` Andrew Lunn [this message]
2018-07-01  7:58     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180701075854.GB15006@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.