From: Will Deacon <will.deacon@arm.com>
To: Kees Cook <keescook@chromium.org>
Cc: Laura Abbott <labbott@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Alexander Popov <alex.popov@linux.com>,
catalin.marinas@arm.com
Subject: Re: [PATCH] arm64: Clear the stack
Date: Mon, 2 Jul 2018 10:59:32 +0100 [thread overview]
Message-ID: <20180702095931.GB28665@arm.com> (raw)
In-Reply-To: <CAGXu5jLW5FJdRdRXcP=xPOEcQ=Tg+uSi=vj6vQ39iVp=QHSRAQ@mail.gmail.com>
Hi Kees,
On Fri, Jun 29, 2018 at 01:25:20PM -0700, Kees Cook wrote:
> On Fri, Jun 29, 2018 at 1:22 PM, Laura Abbott <labbott@redhat.com> wrote:
> > On 06/29/2018 01:19 PM, Kees Cook wrote:
> >>
> >> On Fri, Jun 29, 2018 at 12:05 PM, Laura Abbott <labbott@redhat.com> wrote:
> >>>
> >>> Implementation of stackleak based heavily on the x86 version
> >>>
> >>> Signed-off-by: Laura Abbott <labbott@redhat.com>
> >>> [...]
> >>> +#define current_top_of_stack() (task_stack_page(current) + THREAD_SIZE)
> >>> +#define on_thread_stack() (on_task_stack(current,
> >>> current_stack_pointer))
> >>
> >>
> >> nit on types here. I get some warnings:
> >>
> >> kernel/stackleak.c:55:12: warning: assignment makes integer from
> >> pointer without a cast [-Wint-conversion]
> >> boundary = current_top_of_stack();
> >> ^
> >> kernel/stackleak.c:65:24: warning: assignment makes integer from
> >> pointer without a cast [-Wint-conversion]
> >> current->lowest_stack = current_top_of_stack() - THREAD_SIZE / 64;
> >> ^
> >>
> >> So I think this needs to be:
> >>
> >> +#define current_top_of_stack() ((unsigned long)task_stack_page(current) +
> >> \
> >> + THREAD_SIZE)
> >>
> >
> > Argh, missed that in an amend, can fix for next version if there
> > are no other objections to this approach.
>
> No worries! I've made the change locally and will push this out to
> -next unless there are objections?
I'm a bit wary of conflicts in entry.S, since it's likely that we're going
to have a lot going on in there for 4.19.
Could I take this via arm64 instead, please, or are there dependencies
on other parts of your tree?
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Clear the stack
Date: Mon, 2 Jul 2018 10:59:32 +0100 [thread overview]
Message-ID: <20180702095931.GB28665@arm.com> (raw)
In-Reply-To: <CAGXu5jLW5FJdRdRXcP=xPOEcQ=Tg+uSi=vj6vQ39iVp=QHSRAQ@mail.gmail.com>
Hi Kees,
On Fri, Jun 29, 2018 at 01:25:20PM -0700, Kees Cook wrote:
> On Fri, Jun 29, 2018 at 1:22 PM, Laura Abbott <labbott@redhat.com> wrote:
> > On 06/29/2018 01:19 PM, Kees Cook wrote:
> >>
> >> On Fri, Jun 29, 2018 at 12:05 PM, Laura Abbott <labbott@redhat.com> wrote:
> >>>
> >>> Implementation of stackleak based heavily on the x86 version
> >>>
> >>> Signed-off-by: Laura Abbott <labbott@redhat.com>
> >>> [...]
> >>> +#define current_top_of_stack() (task_stack_page(current) + THREAD_SIZE)
> >>> +#define on_thread_stack() (on_task_stack(current,
> >>> current_stack_pointer))
> >>
> >>
> >> nit on types here. I get some warnings:
> >>
> >> kernel/stackleak.c:55:12: warning: assignment makes integer from
> >> pointer without a cast [-Wint-conversion]
> >> boundary = current_top_of_stack();
> >> ^
> >> kernel/stackleak.c:65:24: warning: assignment makes integer from
> >> pointer without a cast [-Wint-conversion]
> >> current->lowest_stack = current_top_of_stack() - THREAD_SIZE / 64;
> >> ^
> >>
> >> So I think this needs to be:
> >>
> >> +#define current_top_of_stack() ((unsigned long)task_stack_page(current) +
> >> \
> >> + THREAD_SIZE)
> >>
> >
> > Argh, missed that in an amend, can fix for next version if there
> > are no other objections to this approach.
>
> No worries! I've made the change locally and will push this out to
> -next unless there are objections?
I'm a bit wary of conflicts in entry.S, since it's likely that we're going
to have a lot going on in there for 4.19.
Could I take this via arm64 instead, please, or are there dependencies
on other parts of your tree?
Will
next prev parent reply other threads:[~2018-07-02 9:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 19:05 [PATCH] arm64: Clear the stack Laura Abbott
2018-06-29 19:05 ` Laura Abbott
2018-06-29 19:47 ` Kees Cook
2018-06-29 19:47 ` Kees Cook
2018-06-29 20:19 ` Kees Cook
2018-06-29 20:19 ` Kees Cook
2018-06-29 20:22 ` Laura Abbott
2018-06-29 20:22 ` Laura Abbott
2018-06-29 20:25 ` Kees Cook
2018-06-29 20:25 ` Kees Cook
2018-07-02 9:59 ` Will Deacon [this message]
2018-07-02 9:59 ` Will Deacon
2018-07-02 17:29 ` Kees Cook
2018-07-02 17:29 ` Kees Cook
2018-07-04 14:04 ` Will Deacon
2018-07-04 14:04 ` Will Deacon
2018-07-02 13:02 ` Alexander Popov
2018-07-02 13:02 ` Alexander Popov
2018-07-02 18:48 ` Laura Abbott
2018-07-02 18:48 ` Laura Abbott
2018-07-03 12:14 ` Mark Rutland
2018-07-03 12:14 ` Mark Rutland
2018-07-03 15:03 ` Catalin Marinas
2018-07-03 15:03 ` Catalin Marinas
2018-07-03 20:38 ` Alexander Popov
2018-07-03 20:38 ` Alexander Popov
2018-07-17 22:58 ` Laura Abbott
2018-07-17 22:58 ` Laura Abbott
2018-07-19 10:41 ` Mark Rutland
2018-07-19 10:41 ` Mark Rutland
2018-07-12 0:05 ` Kees Cook
2018-07-12 0:05 ` Kees Cook
2018-07-12 12:10 ` Will Deacon
2018-07-12 12:10 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702095931.GB28665@arm.com \
--to=will.deacon@arm.com \
--cc=alex.popov@linux.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.