All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: Limite blob creation to drm master
@ 2018-07-02  8:12 Daniel Vetter
  2018-07-02  8:27 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Daniel Vetter @ 2018-07-02  8:12 UTC (permalink / raw)
  To: DRI Development
  Cc: Daniel Stone, Daniel Vetter, Michel Dänzer, Daniel Vetter,
	Intel Graphics Development

This interface allows pretty much unlimited kernel memory allocations,
which isn't all that great. But we allow that anyway for any drm
master client (through pinning display buffers and stuff, at least for
UMA gpus), so just limiting it to the active master seems like a
reasonable stopgap measure.

Fixes: e2f5d2ea479b ("drm/mode: Add user blob-creation ioctl")
Cc: Daniel Stone <daniels@collabora.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Michel Dänzer <michel@daenzer.net>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/drm_ioctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c
index c148eb3be8c2..dc740c381f9e 100644
--- a/drivers/gpu/drm/drm_ioctl.c
+++ b/drivers/gpu/drm/drm_ioctl.c
@@ -656,8 +656,8 @@ static const struct drm_ioctl_desc drm_ioctls[] = {
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_OBJ_SETPROPERTY, drm_mode_obj_set_property_ioctl, DRM_MASTER|DRM_UNLOCKED),
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_CURSOR2, drm_mode_cursor2_ioctl, DRM_MASTER|DRM_UNLOCKED),
 	DRM_IOCTL_DEF(DRM_IOCTL_MODE_ATOMIC, drm_mode_atomic_ioctl, DRM_MASTER|DRM_UNLOCKED),
-	DRM_IOCTL_DEF(DRM_IOCTL_MODE_CREATEPROPBLOB, drm_mode_createblob_ioctl, DRM_UNLOCKED),
-	DRM_IOCTL_DEF(DRM_IOCTL_MODE_DESTROYPROPBLOB, drm_mode_destroyblob_ioctl, DRM_UNLOCKED),
+	DRM_IOCTL_DEF(DRM_IOCTL_MODE_CREATEPROPBLOB, drm_mode_createblob_ioctl, DRM_MASTER|DRM_UNLOCKED),
+	DRM_IOCTL_DEF(DRM_IOCTL_MODE_DESTROYPROPBLOB, drm_mode_destroyblob_ioctl, DRM_MASTER|DRM_UNLOCKED),
 
 	DRM_IOCTL_DEF(DRM_IOCTL_SYNCOBJ_CREATE, drm_syncobj_create_ioctl,
 		      DRM_UNLOCKED|DRM_RENDER_ALLOW),
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm: Limite blob creation to drm master
  2018-07-02  8:12 [PATCH] drm: Limite blob creation to drm master Daniel Vetter
@ 2018-07-02  8:27 ` Patchwork
  2018-07-02  8:47 ` ✓ Fi.CI.BAT: success " Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-02  8:27 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

== Series Details ==

Series: drm: Limite blob creation to drm master
URL   : https://patchwork.freedesktop.org/series/45753/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
dea0d1f54e76 drm: Limite blob creation to drm master
-:31: WARNING:LONG_LINE: line over 100 characters
#31: FILE: drivers/gpu/drm/drm_ioctl.c:659:
+	DRM_IOCTL_DEF(DRM_IOCTL_MODE_CREATEPROPBLOB, drm_mode_createblob_ioctl, DRM_MASTER|DRM_UNLOCKED),

-:31: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#31: FILE: drivers/gpu/drm/drm_ioctl.c:659:
+	DRM_IOCTL_DEF(DRM_IOCTL_MODE_CREATEPROPBLOB, drm_mode_createblob_ioctl, DRM_MASTER|DRM_UNLOCKED),
 	                                                                                  ^

-:32: WARNING:LONG_LINE: line over 100 characters
#32: FILE: drivers/gpu/drm/drm_ioctl.c:660:
+	DRM_IOCTL_DEF(DRM_IOCTL_MODE_DESTROYPROPBLOB, drm_mode_destroyblob_ioctl, DRM_MASTER|DRM_UNLOCKED),

-:32: CHECK:SPACING: spaces preferred around that '|' (ctx:VxV)
#32: FILE: drivers/gpu/drm/drm_ioctl.c:660:
+	DRM_IOCTL_DEF(DRM_IOCTL_MODE_DESTROYPROPBLOB, drm_mode_destroyblob_ioctl, DRM_MASTER|DRM_UNLOCKED),
 	                                                                                    ^

total: 0 errors, 2 warnings, 2 checks, 10 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm: Limite blob creation to drm master
  2018-07-02  8:12 [PATCH] drm: Limite blob creation to drm master Daniel Vetter
  2018-07-02  8:27 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2018-07-02  8:47 ` Patchwork
  2018-07-02  9:39 ` ✗ Fi.CI.IGT: failure " Patchwork
  2018-07-02 10:24 ` [PATCH] " Ville Syrjälä
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-02  8:47 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

== Series Details ==

Series: drm: Limite blob creation to drm master
URL   : https://patchwork.freedesktop.org/series/45753/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4410 -> Patchwork_9493 =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_9493 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9493, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/45753/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9493:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_gttfill@basic:
      fi-pnv-d510:        PASS -> SKIP

    
== Known issues ==

  Here are the changes found in Patchwork_9493 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)

    
    ==== Possible fixes ====

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         FAIL (fdo#104008) -> PASS

    
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008


== Participating hosts (38 -> 39) ==

  Additional (5): fi-hsw-peppy fi-kbl-7560u fi-glk-j4005 fi-kbl-r fi-snb-2600 
  Missing    (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * Linux: CI_DRM_4410 -> Patchwork_9493

  CI_DRM_4410: 2eaf040dbd0cc45edc4101b8ebe51bcabe1b4e88 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4532: 840d12e2f050b784552197403d6575a57b6e896d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9493: dea0d1f54e769eeeb8d876129bec1b1129a314f7 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

dea0d1f54e76 drm: Limite blob creation to drm master

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9493/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* ✗ Fi.CI.IGT: failure for drm: Limite blob creation to drm master
  2018-07-02  8:12 [PATCH] drm: Limite blob creation to drm master Daniel Vetter
  2018-07-02  8:27 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
  2018-07-02  8:47 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-07-02  9:39 ` Patchwork
  2018-07-02 10:24 ` [PATCH] " Ville Syrjälä
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-02  9:39 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

== Series Details ==

Series: drm: Limite blob creation to drm master
URL   : https://patchwork.freedesktop.org/series/45753/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4410_full -> Patchwork_9493_full =

== Summary - FAILURE ==

  Serious unknown changes coming with Patchwork_9493_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9493_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9493_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@core_prop_blob@blob-multiple:
      shard-hsw:          PASS -> FAIL +1
      shard-kbl:          PASS -> FAIL
      shard-apl:          PASS -> FAIL +1

    igt@core_prop_blob@blob-prop-lifetime:
      shard-snb:          PASS -> FAIL +1
      shard-kbl:          NOTRUN -> FAIL
      shard-glk:          PASS -> FAIL +1

    
    ==== Warnings ====

    igt@gem_exec_schedule@deep-blt:
      shard-kbl:          SKIP -> PASS +1

    igt@kms_cursor_crc@cursor-64x64-suspend:
      shard-snb:          PASS -> SKIP +5

    
== Known issues ==

  Here are the changes found in Patchwork_9493_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@mock_scatterlist:
      shard-kbl:          NOTRUN -> DMESG-WARN (fdo#103667)

    igt@gem_exec_schedule@pi-ringfull-blt:
      shard-kbl:          NOTRUN -> FAIL (fdo#103158)

    igt@kms_flip_tiling@flip-x-tiled:
      shard-glk:          PASS -> FAIL (fdo#103822, fdo#104724)

    
    ==== Possible fixes ====

    igt@gem_workarounds@suspend-resume-context:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
      shard-glk:          FAIL (fdo#105703) -> PASS

    igt@kms_flip@plain-flip-fb-recreate-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS +2

    igt@kms_flip_tiling@flip-to-y-tiled:
      shard-glk:          FAIL (fdo#103822, fdo#104724) -> PASS +1

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103667 https://bugs.freedesktop.org/show_bug.cgi?id=103667
  fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
  fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
  fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4410 -> Patchwork_9493

  CI_DRM_4410: 2eaf040dbd0cc45edc4101b8ebe51bcabe1b4e88 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4532: 840d12e2f050b784552197403d6575a57b6e896d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9493: dea0d1f54e769eeeb8d876129bec1b1129a314f7 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9493/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Limite blob creation to drm master
  2018-07-02  8:12 [PATCH] drm: Limite blob creation to drm master Daniel Vetter
                   ` (2 preceding siblings ...)
  2018-07-02  9:39 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-07-02 10:24 ` Ville Syrjälä
  2018-07-04  9:35   ` Daniel Vetter
  3 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2018-07-02 10:24 UTC (permalink / raw)
  To: Daniel Vetter
  Cc: Michel Dänzer, Daniel Vetter, Intel Graphics Development,
	Daniel Stone, DRI Development

On Mon, Jul 02, 2018 at 10:12:21AM +0200, Daniel Vetter wrote:
> This interface allows pretty much unlimited kernel memory allocations,
> which isn't all that great. But we allow that anyway for any drm
> master client (through pinning display buffers and stuff, at least for
> UMA gpus),

At least on i915 memory used by pinned display buffers has some kind
of upper bound based on the number of planes+max fb size and/or ggtt
size.

Anyways, patch makes sense so
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> so just limiting it to the active master seems like a
> reasonable stopgap measure.
> 
> Fixes: e2f5d2ea479b ("drm/mode: Add user blob-creation ioctl")
> Cc: Daniel Stone <daniels@collabora.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Michel Dänzer <michel@daenzer.net>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/drm_ioctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c
> index c148eb3be8c2..dc740c381f9e 100644
> --- a/drivers/gpu/drm/drm_ioctl.c
> +++ b/drivers/gpu/drm/drm_ioctl.c
> @@ -656,8 +656,8 @@ static const struct drm_ioctl_desc drm_ioctls[] = {
>  	DRM_IOCTL_DEF(DRM_IOCTL_MODE_OBJ_SETPROPERTY, drm_mode_obj_set_property_ioctl, DRM_MASTER|DRM_UNLOCKED),
>  	DRM_IOCTL_DEF(DRM_IOCTL_MODE_CURSOR2, drm_mode_cursor2_ioctl, DRM_MASTER|DRM_UNLOCKED),
>  	DRM_IOCTL_DEF(DRM_IOCTL_MODE_ATOMIC, drm_mode_atomic_ioctl, DRM_MASTER|DRM_UNLOCKED),
> -	DRM_IOCTL_DEF(DRM_IOCTL_MODE_CREATEPROPBLOB, drm_mode_createblob_ioctl, DRM_UNLOCKED),
> -	DRM_IOCTL_DEF(DRM_IOCTL_MODE_DESTROYPROPBLOB, drm_mode_destroyblob_ioctl, DRM_UNLOCKED),
> +	DRM_IOCTL_DEF(DRM_IOCTL_MODE_CREATEPROPBLOB, drm_mode_createblob_ioctl, DRM_MASTER|DRM_UNLOCKED),
> +	DRM_IOCTL_DEF(DRM_IOCTL_MODE_DESTROYPROPBLOB, drm_mode_destroyblob_ioctl, DRM_MASTER|DRM_UNLOCKED),
>  
>  	DRM_IOCTL_DEF(DRM_IOCTL_SYNCOBJ_CREATE, drm_syncobj_create_ioctl,
>  		      DRM_UNLOCKED|DRM_RENDER_ALLOW),
> -- 
> 2.18.0

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm: Limite blob creation to drm master
  2018-07-02 10:24 ` [PATCH] " Ville Syrjälä
@ 2018-07-04  9:35   ` Daniel Vetter
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2018-07-04  9:35 UTC (permalink / raw)
  To: Ville Syrjälä
  Cc: Daniel Stone, Daniel Vetter, Michel Dänzer, DRI Development,
	Daniel Vetter, Intel Graphics Development

On Mon, Jul 02, 2018 at 01:24:40PM +0300, Ville Syrjälä wrote:
> On Mon, Jul 02, 2018 at 10:12:21AM +0200, Daniel Vetter wrote:
> > This interface allows pretty much unlimited kernel memory allocations,
> > which isn't all that great. But we allow that anyway for any drm
> > master client (through pinning display buffers and stuff, at least for
> > UMA gpus),
> 
> At least on i915 memory used by pinned display buffers has some kind
> of upper bound based on the number of planes+max fb size and/or ggtt
> size.
> 
> Anyways, patch makes sense so
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

CI is unhappy about it because it breaks the testcase. And on second
thought with stuff like drm leases we allow rather unpriviledge things to
be drm master, so this isn't helping all that much really. Also, cgroups
should be able to limit these kernel allocations - we only ever do this in
process context.

Decided to drop this on the floor instead.
-Daniel

> 
> > so just limiting it to the active master seems like a
> > reasonable stopgap measure.
> > 
> > Fixes: e2f5d2ea479b ("drm/mode: Add user blob-creation ioctl")
> > Cc: Daniel Stone <daniels@collabora.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Michel Dänzer <michel@daenzer.net>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  drivers/gpu/drm/drm_ioctl.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c
> > index c148eb3be8c2..dc740c381f9e 100644
> > --- a/drivers/gpu/drm/drm_ioctl.c
> > +++ b/drivers/gpu/drm/drm_ioctl.c
> > @@ -656,8 +656,8 @@ static const struct drm_ioctl_desc drm_ioctls[] = {
> >  	DRM_IOCTL_DEF(DRM_IOCTL_MODE_OBJ_SETPROPERTY, drm_mode_obj_set_property_ioctl, DRM_MASTER|DRM_UNLOCKED),
> >  	DRM_IOCTL_DEF(DRM_IOCTL_MODE_CURSOR2, drm_mode_cursor2_ioctl, DRM_MASTER|DRM_UNLOCKED),
> >  	DRM_IOCTL_DEF(DRM_IOCTL_MODE_ATOMIC, drm_mode_atomic_ioctl, DRM_MASTER|DRM_UNLOCKED),
> > -	DRM_IOCTL_DEF(DRM_IOCTL_MODE_CREATEPROPBLOB, drm_mode_createblob_ioctl, DRM_UNLOCKED),
> > -	DRM_IOCTL_DEF(DRM_IOCTL_MODE_DESTROYPROPBLOB, drm_mode_destroyblob_ioctl, DRM_UNLOCKED),
> > +	DRM_IOCTL_DEF(DRM_IOCTL_MODE_CREATEPROPBLOB, drm_mode_createblob_ioctl, DRM_MASTER|DRM_UNLOCKED),
> > +	DRM_IOCTL_DEF(DRM_IOCTL_MODE_DESTROYPROPBLOB, drm_mode_destroyblob_ioctl, DRM_MASTER|DRM_UNLOCKED),
> >  
> >  	DRM_IOCTL_DEF(DRM_IOCTL_SYNCOBJ_CREATE, drm_syncobj_create_ioctl,
> >  		      DRM_UNLOCKED|DRM_RENDER_ALLOW),
> > -- 
> > 2.18.0
> 
> -- 
> Ville Syrjälä
> Intel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-04  9:35 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-02  8:12 [PATCH] drm: Limite blob creation to drm master Daniel Vetter
2018-07-02  8:27 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-07-02  8:47 ` ✓ Fi.CI.BAT: success " Patchwork
2018-07-02  9:39 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-07-02 10:24 ` [PATCH] " Ville Syrjälä
2018-07-04  9:35   ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.