From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Andrea Parri <andrea.parri@amarulasolutions.com>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-doc@vger.kernel.org, "Jonathan Corbet" <corbet@lwn.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: atomic_ops: atomic_set is a write (not read) operation
Date: Mon, 2 Jul 2018 11:55:26 -0700 [thread overview]
Message-ID: <20180702185526.GS3593@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180629134345.GA10981@andrea>
On Fri, Jun 29, 2018 at 03:43:45PM +0200, Andrea Parri wrote:
> On Wed, Jun 06, 2018 at 01:07:56AM -0700, Paul E. McKenney wrote:
> > On Tue, Jun 05, 2018 at 09:43:23PM +0200, Jonathan Neuschäfer wrote:
> > > Describe it as such.
> > >
> > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> >
> > I have queued this, but if someone else would prefer to take it:
> >
> > Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> In the commit message of bb7d47b697116c ("docs: atomic_ops: Describe
> atomic_set as a write operation") from your dev branch,
>
> from "reads" to "writes"
Good catch, fixed, thank you!
Thanx, Paul
> Andrea
>
>
> >
> > > ---
> > > Documentation/core-api/atomic_ops.rst | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/core-api/atomic_ops.rst b/Documentation/core-api/atomic_ops.rst
> > > index 2e7165f86f55..724583453e1f 100644
> > > --- a/Documentation/core-api/atomic_ops.rst
> > > +++ b/Documentation/core-api/atomic_ops.rst
> > > @@ -29,7 +29,7 @@ updated by one CPU, local_t is probably more appropriate. Please see
> > > local_t.
> > >
> > > The first operations to implement for atomic_t's are the initializers and
> > > -plain reads. ::
> > > +plain writes. ::
> > >
> > > #define ATOMIC_INIT(i) { (i) }
> > > #define atomic_set(v, i) ((v)->counter = (i))
> > > --
> > > 2.17.1
> > >
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Andrea Parri <andrea.parri@amarulasolutions.com>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-doc@vger.kernel.org, "Jonathan Corbet" <corbet@lwn.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: atomic_ops: atomic_set is a write (not read) operation
Date: Mon, 2 Jul 2018 11:55:26 -0700 [thread overview]
Message-ID: <20180702185526.GS3593@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180629134345.GA10981@andrea>
On Fri, Jun 29, 2018 at 03:43:45PM +0200, Andrea Parri wrote:
> On Wed, Jun 06, 2018 at 01:07:56AM -0700, Paul E. McKenney wrote:
> > On Tue, Jun 05, 2018 at 09:43:23PM +0200, Jonathan Neuschäfer wrote:
> > > Describe it as such.
> > >
> > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> >
> > I have queued this, but if someone else would prefer to take it:
> >
> > Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> In the commit message of bb7d47b697116c ("docs: atomic_ops: Describe
> atomic_set as a write operation") from your dev branch,
>
> from "reads" to "writes"
Good catch, fixed, thank you!
Thanx, Paul
> Andrea
>
>
> >
> > > ---
> > > Documentation/core-api/atomic_ops.rst | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/core-api/atomic_ops.rst b/Documentation/core-api/atomic_ops.rst
> > > index 2e7165f86f55..724583453e1f 100644
> > > --- a/Documentation/core-api/atomic_ops.rst
> > > +++ b/Documentation/core-api/atomic_ops.rst
> > > @@ -29,7 +29,7 @@ updated by one CPU, local_t is probably more appropriate. Please see
> > > local_t.
> > >
> > > The first operations to implement for atomic_t's are the initializers and
> > > -plain reads. ::
> > > +plain writes. ::
> > >
> > > #define ATOMIC_INIT(i) { (i) }
> > > #define atomic_set(v, i) ((v)->counter = (i))
> > > --
> > > 2.17.1
> > >
> >
>
next prev parent reply other threads:[~2018-07-02 18:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 19:43 [PATCH] docs: atomic_ops: atomic_set is a write (not read) operation Jonathan Neuschäfer
2018-06-05 19:43 ` Jonathan Neuschäfer
2018-06-06 8:07 ` Paul E. McKenney
2018-06-06 8:07 ` Paul E. McKenney
2018-06-29 13:43 ` Andrea Parri
2018-06-29 13:43 ` Andrea Parri
2018-07-02 18:55 ` Paul E. McKenney [this message]
2018-07-02 18:55 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702185526.GS3593@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=corbet@lwn.net \
--cc=j.neuschaefer@gmx.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.