All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takahiro AKASHI <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] ARM: qemu-arm: enable RTC
Date: Tue, 3 Jul 2018 08:51:32 +0900	[thread overview]
Message-ID: <20180702235131.GR23681@linaro.org> (raw)
In-Reply-To: <3036110f-231f-0bc9-8b26-9ece81443cb0@iki.fi>

On Mon, Jul 02, 2018 at 07:07:55PM +0300, Tuomas Tynkkynen wrote:
> Hi Heinrich,
> 
> On 06/29/2018 01:34 AM, Heinrich Schuchardt wrote:
> >QEMU provides an emulated ARM AMBA PrimeCell PL031 RTC.
> >
> >The patch sets the base address in the board include file according to the
> >definition in hw/arm/virt.c of the QEMU source. It defines the Kconfig
> >option for the existing driver, and enables the RTC driver in
> >qemu_arm64_defconfig and qemu_arm_defconfig as well as the date command.
> >
> >We need an RTC to provide the GetTime() runtime service in the UEFI
> >subsystem.
> >
> >Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> >---
> >  configs/qemu_arm64_defconfig | 2 ++
> >  configs/qemu_arm_defconfig   | 2 ++
> >  drivers/rtc/Kconfig          | 7 +++++++
> >  include/configs/qemu-arm.h   | 3 +++
> >  4 files changed, 14 insertions(+)
> >
> 
> Reviewed-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> Tested-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
> 
> - Tuomas

Well, it is a good time. Why not change the driver to driver model
like below:
 * I intentionally leave CONFIG_DM_RTC not mandatory here
 * The patch may be split into two parts; one for rtc, the other for qemu-arm

---8<---

  reply	other threads:[~2018-07-02 23:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28 22:34 [U-Boot] [PATCH 1/1] ARM: qemu-arm: enable RTC Heinrich Schuchardt
2018-07-02 16:07 ` Tuomas Tynkkynen
2018-07-02 23:51   ` Takahiro AKASHI [this message]
2018-07-03  2:07     ` Heinrich Schuchardt
2018-07-03  3:30       ` Heinrich Schuchardt
2018-07-03  5:29       ` Takahiro AKASHI
2018-07-03  6:00         ` Heinrich Schuchardt
2018-07-20 12:36 ` [U-Boot] [U-Boot,1/1] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180702235131.GR23681@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.