* [PATCH] ARM: dts: am3517-evm: Remove unnessary PMIC parameters
@ 2018-05-19 20:48 Adam Ford
2018-06-19 22:45 ` Adam Ford
0 siblings, 1 reply; 3+ messages in thread
From: Adam Ford @ 2018-05-19 20:48 UTC (permalink / raw)
To: linux-omap; +Cc: devicetree, bcousson, tony, woods.technical, Adam Ford
The AM3517-EVM uses a TPS65023 PMIC. This is already defined
by: compatible = "ti,tps65023"
There doesn't seem to be a need to have each regulator in the
PMIC with the 'compatible = "regulator-fixed"' since each
regulator has a min and max setting.
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/arch/arm/boot/dts/am3517-som.dtsi b/arch/arm/boot/dts/am3517-som.dtsi
index a6d5ff73c163..7ff7cd135dca 100644
--- a/arch/arm/boot/dts/am3517-som.dtsi
+++ b/arch/arm/boot/dts/am3517-som.dtsi
@@ -64,7 +64,6 @@
regulators {
vdd_core_reg: VDCDC1 {
regulator-name = "vdd_core";
- compatible = "regulator-fixed";
regulator-always-on;
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <1200000>;
@@ -72,7 +71,6 @@
vdd_io_reg: VDCDC2 {
regulator-name = "vdd_io";
- compatible = "regulator-fixed";
regulator-always-on;
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
@@ -80,7 +78,6 @@
vdd_1v8_reg: VDCDC3 {
regulator-name = "vdd_1v8";
- compatible = "regulator-fixed";
regulator-always-on;
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
@@ -88,7 +85,6 @@
vdd_usb18_reg: LDO1 {
regulator-name = "vdd_usb18";
- compatible = "regulator-fixed";
regulator-always-on;
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
@@ -96,7 +92,6 @@
vdd_usb33_reg: LDO2 {
regulator-name = "vdd_usb33";
- compatible = "regulator-fixed";
regulator-always-on;
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: am3517-evm: Remove unnessary PMIC parameters
2018-05-19 20:48 [PATCH] ARM: dts: am3517-evm: Remove unnessary PMIC parameters Adam Ford
@ 2018-06-19 22:45 ` Adam Ford
2018-07-03 6:37 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Adam Ford @ 2018-06-19 22:45 UTC (permalink / raw)
To: linux-omap; +Cc: devicetree, Benoît Cousson, Tony Lindgren, Derald Woods
On Sat, May 19, 2018 at 3:48 PM Adam Ford <aford173@gmail.com> wrote:
>
> The AM3517-EVM uses a TPS65023 PMIC. This is already defined
> by: compatible = "ti,tps65023"
>
> There doesn't seem to be a need to have each regulator in the
> PMIC with the 'compatible = "regulator-fixed"' since each
> regulator has a min and max setting.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
Gentle nudge
adam
> diff --git a/arch/arm/boot/dts/am3517-som.dtsi b/arch/arm/boot/dts/am3517-som.dtsi
> index a6d5ff73c163..7ff7cd135dca 100644
> --- a/arch/arm/boot/dts/am3517-som.dtsi
> +++ b/arch/arm/boot/dts/am3517-som.dtsi
> @@ -64,7 +64,6 @@
> regulators {
> vdd_core_reg: VDCDC1 {
> regulator-name = "vdd_core";
> - compatible = "regulator-fixed";
> regulator-always-on;
> regulator-min-microvolt = <1200000>;
> regulator-max-microvolt = <1200000>;
> @@ -72,7 +71,6 @@
>
> vdd_io_reg: VDCDC2 {
> regulator-name = "vdd_io";
> - compatible = "regulator-fixed";
> regulator-always-on;
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> @@ -80,7 +78,6 @@
>
> vdd_1v8_reg: VDCDC3 {
> regulator-name = "vdd_1v8";
> - compatible = "regulator-fixed";
> regulator-always-on;
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> @@ -88,7 +85,6 @@
>
> vdd_usb18_reg: LDO1 {
> regulator-name = "vdd_usb18";
> - compatible = "regulator-fixed";
> regulator-always-on;
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> @@ -96,7 +92,6 @@
>
> vdd_usb33_reg: LDO2 {
> regulator-name = "vdd_usb33";
> - compatible = "regulator-fixed";
> regulator-always-on;
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> --
> 2.17.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: am3517-evm: Remove unnessary PMIC parameters
2018-06-19 22:45 ` Adam Ford
@ 2018-07-03 6:37 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2018-07-03 6:37 UTC (permalink / raw)
To: Adam Ford; +Cc: linux-omap, devicetree, Benoît Cousson, Derald Woods
* Adam Ford <aford173@gmail.com> [180619 22:48]:
> On Sat, May 19, 2018 at 3:48 PM Adam Ford <aford173@gmail.com> wrote:
> >
> > The AM3517-EVM uses a TPS65023 PMIC. This is already defined
> > by: compatible = "ti,tps65023"
> >
> > There doesn't seem to be a need to have each regulator in the
> > PMIC with the 'compatible = "regulator-fixed"' since each
> > regulator has a min and max setting.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
>
> Gentle nudge
Sorry for the delay, applying into omap-for-v4.19/dt thanks.
Regards,
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-03 6:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-19 20:48 [PATCH] ARM: dts: am3517-evm: Remove unnessary PMIC parameters Adam Ford
2018-06-19 22:45 ` Adam Ford
2018-07-03 6:37 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.