From: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: "Theodore Y. Ts'o" <tytso-3s7WtUTddSA@public.gmane.org>
Cc: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
"Darrick J. Wong"
<darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH v2 1/2] dax: dax_layout_busy_page() warn on !exceptional
Date: Tue, 3 Jul 2018 09:41:37 -0600 [thread overview]
Message-ID: <20180703154137.GB13019@linux.intel.com> (raw)
In-Reply-To: <20180702221503.GA12830-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
On Mon, Jul 02, 2018 at 06:15:03PM -0400, Theodore Y. Ts'o wrote:
> On Wed, Jun 27, 2018 at 03:22:51PM -0600, Ross Zwisler wrote:
> > Inodes using DAX should only ever have exceptional entries in their page
> > caches. Make this clear by warning if the iteration in
> > dax_layout_busy_page() ever sees a non-exceptional entry, and by adding a
> > comment for the pagevec_release() call which only deals with struct page
> > pointers.
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> > Reviewed-by: Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>
>
> Thanks, applied (to the ext4 tree). If someone thinks they should go
> in via some other tree, holler.
>
> - Ted
Hey Ted,
It looks like you only picked up patch 1/2? (I'm looking at the 'dev' branch
in your repo.) Was that intentional?
You can find the final version of the 2nd patch here:
https://lists.01.org/pipermail/linux-nvdimm/2018-July/016602.html
Thanks,
- Ross
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-nvdimm@lists.01.org, Dave Chinner <david@fromorbit.com>,
linux-ext4@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 1/2] dax: dax_layout_busy_page() warn on !exceptional
Date: Tue, 3 Jul 2018 09:41:37 -0600 [thread overview]
Message-ID: <20180703154137.GB13019@linux.intel.com> (raw)
In-Reply-To: <20180702221503.GA12830@thunk.org>
On Mon, Jul 02, 2018 at 06:15:03PM -0400, Theodore Y. Ts'o wrote:
> On Wed, Jun 27, 2018 at 03:22:51PM -0600, Ross Zwisler wrote:
> > Inodes using DAX should only ever have exceptional entries in their page
> > caches. Make this clear by warning if the iteration in
> > dax_layout_busy_page() ever sees a non-exceptional entry, and by adding a
> > comment for the pagevec_release() call which only deals with struct page
> > pointers.
> >
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > Reviewed-by: Jan Kara <jack@suse.cz>
>
> Thanks, applied (to the ext4 tree). If someone thinks they should go
> in via some other tree, holler.
>
> - Ted
Hey Ted,
It looks like you only picked up patch 1/2? (I'm looking at the 'dev' branch
in your repo.) Was that intentional?
You can find the final version of the 2nd patch here:
https://lists.01.org/pipermail/linux-nvdimm/2018-July/016602.html
Thanks,
- Ross
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-07-03 15:41 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 21:22 [PATCH v2 0/2] ext4: fix DAX dma vs truncate/hole-punch Ross Zwisler
2018-06-27 21:22 ` Ross Zwisler
[not found] ` <20180627212252.31032-1-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-06-27 21:22 ` [PATCH v2 1/2] dax: dax_layout_busy_page() warn on !exceptional Ross Zwisler
2018-06-27 21:22 ` Ross Zwisler
[not found] ` <20180627212252.31032-2-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-07-02 22:15 ` Theodore Y. Ts'o
2018-07-02 22:15 ` Theodore Y. Ts'o
[not found] ` <20180702221503.GA12830-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2018-07-03 15:41 ` Ross Zwisler [this message]
2018-07-03 15:41 ` Ross Zwisler
[not found] ` <20180703154137.GB13019-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-07-03 17:44 ` Theodore Y. Ts'o
2018-07-03 17:44 ` Theodore Y. Ts'o
2018-06-27 21:22 ` [PATCH v2 2/2] ext4: handle layout changes to pinned DAX mappings Ross Zwisler
2018-06-27 21:22 ` Ross Zwisler
[not found] ` <20180627212252.31032-3-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-06-29 12:02 ` Lukas Czerner
2018-06-29 12:02 ` Lukas Czerner
[not found] ` <20180629120223.oaslngsvspnwf4ae-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-06-29 15:13 ` Ross Zwisler
2018-06-29 15:13 ` Ross Zwisler
[not found] ` <20180629151300.GA3006-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-07-02 7:34 ` Jan Kara
2018-07-02 7:34 ` Jan Kara
2018-07-02 7:59 ` Lukas Czerner
2018-07-02 7:59 ` Lukas Czerner
[not found] ` <20180702075948.i4aqjg5rrorwoxqj-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-07-02 16:27 ` Ross Zwisler
2018-07-02 16:27 ` Ross Zwisler
2018-06-30 1:12 ` Dave Chinner
2018-06-30 1:12 ` Dave Chinner
2018-07-02 17:29 ` [PATCH v3 " Ross Zwisler
2018-07-02 17:29 ` Ross Zwisler
[not found] ` <20180702172912.329-1-ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-07-04 0:49 ` Dave Chinner
2018-07-04 0:49 ` Dave Chinner
2018-07-04 12:27 ` Jan Kara
2018-07-04 12:27 ` Jan Kara
[not found] ` <20180704122723.lup2wovzb6u6ta6v-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2018-07-04 23:54 ` Dave Chinner
2018-07-04 23:54 ` Dave Chinner
2018-07-05 3:59 ` Darrick J. Wong
2018-07-05 3:59 ` Darrick J. Wong
2018-07-05 16:53 ` Ross Zwisler
2018-07-05 16:53 ` Ross Zwisler
[not found] ` <20180705165310.GB22200-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-07-09 12:33 ` Jan Kara
2018-07-09 12:33 ` Jan Kara
[not found] ` <20180709123347.nw3ixr64prgk7sxz-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2018-07-09 16:23 ` Darrick J. Wong
2018-07-09 16:23 ` Darrick J. Wong
2018-07-09 19:49 ` Jan Kara
2018-07-09 19:49 ` Jan Kara
2018-07-05 20:40 ` Dan Williams
2018-07-05 20:40 ` Dan Williams
[not found] ` <CAPcyv4jSNh95XUPh4ZzguKmcJpgNG7AG5_9=+gbLEjsaZUTq4g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-05 23:29 ` Dave Chinner
2018-07-05 23:29 ` Dave Chinner
2018-07-06 5:08 ` Dan Williams
2018-07-06 5:08 ` Dan Williams
2018-07-09 9:59 ` Lukas Czerner
2018-07-09 9:59 ` Lukas Czerner
[not found] ` <20180709095907.i3mnyodvn6gpcidt-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-07-09 16:18 ` Darrick J. Wong
2018-07-09 16:18 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703154137.GB13019@linux.intel.com \
--to=ross.zwisler-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
--cc=tytso-3s7WtUTddSA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.