* [tpm2] tpm2-tools man pages not installing?
@ 2018-07-03 13:46 Scheie, Peter M
0 siblings, 0 replies; 11+ messages in thread
From: Scheie, Peter M @ 2018-07-03 13:46 UTC (permalink / raw)
To: tpm2
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
When I build & install tpm2-tools, the man pages don't seem to get installed. I'm just using the default './configure; make; sudo make install' routine, so everything is going into /usr/local/; therefore, I'd expect the man pages to end up in /usr/local/share/man, but they don't. Do I need add an argument to configure to make that happen?
[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 1919 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tpm2] tpm2-tools man pages not installing?
@ 2018-07-03 14:53 Matthias Gerstner
0 siblings, 0 replies; 11+ messages in thread
From: Matthias Gerstner @ 2018-07-03 14:53 UTC (permalink / raw)
To: tpm2
[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]
Hello,
On Tue, Jul 03, 2018 at 01:46:14PM +0000, Scheie, Peter M wrote:
> When I build & install tpm2-tools, the man pages don't seem to get
> installed. I'm just using the default './configure; make; sudo make
> install' routine, so everything is going into /usr/local/; therefore,
> I'd expect the man pages to end up in /usr/local/share/man, but they
> don't. Do I need add an argument to configure to make that happen?
that is actually a bug and I addressed it via commit
72a28f36151db9bfa59a460ae0114dcece218862, however that commit didn't
make it into the current release.
So you either have to install them manually or, as a workaround, if you
have pandoc installed on the system, then the build system tries to
generate the man pages and alongside that also installs them.
Regards
Matthias
--
Matthias Gerstner <matthias.gerstner(a)suse.de>
Dipl.-Wirtsch.-Inf. (FH), Security Engineer
https://www.suse.com/security
Telefon: +49 911 740 53 290
GPG Key ID: 0x14C405C971923553
SUSE Linux GmbH
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nuernberg)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tpm2] tpm2-tools man pages not installing?
@ 2018-07-03 17:41 Scheie, Peter M
0 siblings, 0 replies; 11+ messages in thread
From: Scheie, Peter M @ 2018-07-03 17:41 UTC (permalink / raw)
To: tpm2
[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]
Glad to hear it has been fixed. Yeah, I had already copied them in by hand, but that's when it occurred to me that I shouldn't have to be doing that. Thanks for taking care of it.
Peter
-----Original Message-----
From: Matthias Gerstner [mailto:mgerstner(a)suse.de]
Sent: Tuesday, July 03, 2018 9:53 AM
To: Scheie, Peter M
Cc: tpm2(a)lists.01.org
Subject: Re: [tpm2] tpm2-tools man pages not installing?
Hello,
On Tue, Jul 03, 2018 at 01:46:14PM +0000, Scheie, Peter M wrote:
> When I build & install tpm2-tools, the man pages don't seem to get
> installed. I'm just using the default './configure; make; sudo make
> install' routine, so everything is going into /usr/local/; therefore,
> I'd expect the man pages to end up in /usr/local/share/man, but they
> don't. Do I need add an argument to configure to make that happen?
that is actually a bug and I addressed it via commit 72a28f36151db9bfa59a460ae0114dcece218862, however that commit didn't make it into the current release.
So you either have to install them manually or, as a workaround, if you have pandoc installed on the system, then the build system tries to generate the man pages and alongside that also installs them.
Regards
Matthias
--
Matthias Gerstner <matthias.gerstner(a)suse.de> Dipl.-Wirtsch.-Inf. (FH), Security Engineer https://www.suse.com/security
Telefon: +49 911 740 53 290
GPG Key ID: 0x14C405C971923553
SUSE Linux GmbH
GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nuernberg)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tpm2] tpm2-tools man pages not installing?
@ 2018-07-03 17:49 Philip Tricca
0 siblings, 0 replies; 11+ messages in thread
From: Philip Tricca @ 2018-07-03 17:49 UTC (permalink / raw)
To: tpm2
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
On Tue, Jul 03, 2018 at 04:53:23PM +0200, Matthias Gerstner wrote:
> Hello,
>
> On Tue, Jul 03, 2018 at 01:46:14PM +0000, Scheie, Peter M wrote:
> > When I build & install tpm2-tools, the man pages don't seem to get
> > installed. I'm just using the default './configure; make; sudo make
> > install' routine, so everything is going into /usr/local/; therefore,
> > I'd expect the man pages to end up in /usr/local/share/man, but they
> > don't. Do I need add an argument to configure to make that happen?
>
> that is actually a bug and I addressed it via commit
> 72a28f36151db9bfa59a460ae0114dcece218862, however that commit didn't
> make it into the current release.
>
> So you either have to install them manually or, as a workaround, if you
> have pandoc installed on the system, then the build system tries to
> generate the man pages and alongside that also installs them.
Sounds like a bug to me. Should have been backported to 3.x release.
Just made an issue to track this:
https://github.com/tpm2-software/tpm2-tools/issues/1091
Regards,
Philip
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tpm2] tpm2-tools man pages not installing?
@ 2018-07-04 10:09 Joshua Lock
0 siblings, 0 replies; 11+ messages in thread
From: Joshua Lock @ 2018-07-04 10:09 UTC (permalink / raw)
To: tpm2
[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]
On 03/07/2018 15:53, Matthias Gerstner wrote:
> Hello,
>
> On Tue, Jul 03, 2018 at 01:46:14PM +0000, Scheie, Peter M wrote:
>> When I build & install tpm2-tools, the man pages don't seem to get
>> installed. I'm just using the default './configure; make; sudo make
>> install' routine, so everything is going into /usr/local/; therefore,
>> I'd expect the man pages to end up in /usr/local/share/man, but they
>> don't. Do I need add an argument to configure to make that happen?
>
> that is actually a bug and I addressed it via commit
> 72a28f36151db9bfa59a460ae0114dcece218862, however that commit didn't
> make it into the current release.
>
> So you either have to install them manually or, as a workaround, if you
> have pandoc installed on the system, then the build system tries to
> generate the man pages and alongside that also installs them.
Thanks for the report Peter and for pointing to the fix Matthias. I've
backported the change to the 3.X branch and tagged a release candidate
for 3.1.1 which includes the fix:
https://github.com/tpm2-software/tpm2-tools/releases/tag/3.1.1-rc0
Regards,
Joshua
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tpm2] tpm2-tools man pages not installing?
@ 2018-07-05 20:44 Scheie, Peter M
0 siblings, 0 replies; 11+ messages in thread
From: Scheie, Peter M @ 2018-07-05 20:44 UTC (permalink / raw)
To: tpm2
[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]
BTW, there's a grammatical error in the man page for tpm2_unseal. What's the best way to get that fixed? (Sorry, my mother was an English major).
Peter
-----Original Message-----
From: Joshua Lock [mailto:joshua.g.lock(a)linux.intel.com]
Sent: Wednesday, July 04, 2018 5:10 AM
To: Matthias Gerstner; Scheie, Peter M
Cc: tpm2(a)lists.01.org
Subject: Re: [tpm2] tpm2-tools man pages not installing?
On 03/07/2018 15:53, Matthias Gerstner wrote:
> Hello,
>
> On Tue, Jul 03, 2018 at 01:46:14PM +0000, Scheie, Peter M wrote:
>> When I build & install tpm2-tools, the man pages don't seem to get
>> installed. I'm just using the default './configure; make; sudo make
>> install' routine, so everything is going into /usr/local/; therefore,
>> I'd expect the man pages to end up in /usr/local/share/man, but they
>> don't. Do I need add an argument to configure to make that happen?
>
> that is actually a bug and I addressed it via commit
> 72a28f36151db9bfa59a460ae0114dcece218862, however that commit didn't
> make it into the current release.
>
> So you either have to install them manually or, as a workaround, if you
> have pandoc installed on the system, then the build system tries to
> generate the man pages and alongside that also installs them.
Thanks for the report Peter and for pointing to the fix Matthias. I've
backported the change to the 3.X branch and tagged a release candidate
for 3.1.1 which includes the fix:
https://github.com/tpm2-software/tpm2-tools/releases/tag/3.1.1-rc0
Regards,
Joshua
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tpm2] tpm2-tools man pages not installing?
@ 2018-07-06 13:48 Joshua Lock
0 siblings, 0 replies; 11+ messages in thread
From: Joshua Lock @ 2018-07-06 13:48 UTC (permalink / raw)
To: tpm2
[-- Attachment #1: Type: text/plain, Size: 1857 bytes --]
No need to apologise, we do have plans to review and try to improve the
quality of all of the manual pages. In the interim a Github pull request
would be most welcome.
Joshua
On 05/07/2018 21:44, Scheie, Peter M wrote:
> BTW, there's a grammatical error in the man page for tpm2_unseal. What's the best way to get that fixed? (Sorry, my mother was an English major).
>
> Peter
>
> -----Original Message-----
> From: Joshua Lock [mailto:joshua.g.lock(a)linux.intel.com]
> Sent: Wednesday, July 04, 2018 5:10 AM
> To: Matthias Gerstner; Scheie, Peter M
> Cc: tpm2(a)lists.01.org
> Subject: Re: [tpm2] tpm2-tools man pages not installing?
>
>
>
> On 03/07/2018 15:53, Matthias Gerstner wrote:
>> Hello,
>>
>> On Tue, Jul 03, 2018 at 01:46:14PM +0000, Scheie, Peter M wrote:
>>> When I build & install tpm2-tools, the man pages don't seem to get
>>> installed. I'm just using the default './configure; make; sudo make
>>> install' routine, so everything is going into /usr/local/; therefore,
>>> I'd expect the man pages to end up in /usr/local/share/man, but they
>>> don't. Do I need add an argument to configure to make that happen?
>>
>> that is actually a bug and I addressed it via commit
>> 72a28f36151db9bfa59a460ae0114dcece218862, however that commit didn't
>> make it into the current release.
>>
>> So you either have to install them manually or, as a workaround, if you
>> have pandoc installed on the system, then the build system tries to
>> generate the man pages and alongside that also installs them.
>
> Thanks for the report Peter and for pointing to the fix Matthias. I've
> backported the change to the 3.X branch and tagged a release candidate
> for 3.1.1 which includes the fix:
>
> https://github.com/tpm2-software/tpm2-tools/releases/tag/3.1.1-rc0
>
> Regards,
> Joshua
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tpm2] tpm2-tools man pages not installing?
@ 2018-07-06 14:10 Scheie, Peter M
0 siblings, 0 replies; 11+ messages in thread
From: Scheie, Peter M @ 2018-07-06 14:10 UTC (permalink / raw)
To: tpm2
[-- Attachment #1: Type: text/plain, Size: 2452 bytes --]
Heh, when your message arrived, I was just reading through your pull request for "object auth short form unification" and discovered why I'm having so much trouble with tpm2_create (the argument letters changed last week). :-)
Anyway, I'm glad to help out if I can, so I'll do the pull request I'm not very good with git, so I may have questions.
Peter
-----Original Message-----
From: Joshua Lock [mailto:joshua.g.lock(a)linux.intel.com]
Sent: Friday, July 06, 2018 8:49 AM
To: Scheie, Peter M
Cc: tpm2(a)lists.01.org
Subject: Re: [tpm2] tpm2-tools man pages not installing?
No need to apologise, we do have plans to review and try to improve the
quality of all of the manual pages. In the interim a Github pull request
would be most welcome.
Joshua
On 05/07/2018 21:44, Scheie, Peter M wrote:
> BTW, there's a grammatical error in the man page for tpm2_unseal. What's the best way to get that fixed? (Sorry, my mother was an English major).
>
> Peter
>
> -----Original Message-----
> From: Joshua Lock [mailto:joshua.g.lock(a)linux.intel.com]
> Sent: Wednesday, July 04, 2018 5:10 AM
> To: Matthias Gerstner; Scheie, Peter M
> Cc: tpm2(a)lists.01.org
> Subject: Re: [tpm2] tpm2-tools man pages not installing?
>
>
>
> On 03/07/2018 15:53, Matthias Gerstner wrote:
>> Hello,
>>
>> On Tue, Jul 03, 2018 at 01:46:14PM +0000, Scheie, Peter M wrote:
>>> When I build & install tpm2-tools, the man pages don't seem to get
>>> installed. I'm just using the default './configure; make; sudo make
>>> install' routine, so everything is going into /usr/local/; therefore,
>>> I'd expect the man pages to end up in /usr/local/share/man, but they
>>> don't. Do I need add an argument to configure to make that happen?
>>
>> that is actually a bug and I addressed it via commit
>> 72a28f36151db9bfa59a460ae0114dcece218862, however that commit didn't
>> make it into the current release.
>>
>> So you either have to install them manually or, as a workaround, if you
>> have pandoc installed on the system, then the build system tries to
>> generate the man pages and alongside that also installs them.
>
> Thanks for the report Peter and for pointing to the fix Matthias. I've
> backported the change to the 3.X branch and tagged a release candidate
> for 3.1.1 which includes the fix:
>
> https://github.com/tpm2-software/tpm2-tools/releases/tag/3.1.1-rc0
>
> Regards,
> Joshua
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tpm2] tpm2-tools man pages not installing?
@ 2018-07-06 15:19 Scheie, Peter M
0 siblings, 0 replies; 11+ messages in thread
From: Scheie, Peter M @ 2018-07-06 15:19 UTC (permalink / raw)
To: tpm2
[-- Attachment #1: Type: text/plain, Size: 3100 bytes --]
I don't think I have permission to push my branch to github, do I? When I do a 'git push origin update-tpm2-unseal-man-page' I get a 'remote: Permission to tpm2-software/tpm2-tools.git denied to pscheie" error, which isn't surprising as you wouldn't want every Tom, Dick, and Harry pushing branches up. But I think I have to have my branch pushed before I can create a pull request, right? (Otherwise, people can't see the changes I made.)
Peter
-----Original Message-----
From: Scheie, Peter M
Sent: Friday, July 06, 2018 9:10 AM
To: 'Joshua Lock'
Cc: tpm2(a)lists.01.org
Subject: RE: [tpm2] tpm2-tools man pages not installing?
Heh, when your message arrived, I was just reading through your pull request for "object auth short form unification" and discovered why I'm having so much trouble with tpm2_create (the argument letters changed last week). :-)
Anyway, I'm glad to help out if I can, so I'll do the pull request I'm not very good with git, so I may have questions.
Peter
-----Original Message-----
From: Joshua Lock [mailto:joshua.g.lock(a)linux.intel.com]
Sent: Friday, July 06, 2018 8:49 AM
To: Scheie, Peter M
Cc: tpm2(a)lists.01.org
Subject: Re: [tpm2] tpm2-tools man pages not installing?
No need to apologise, we do have plans to review and try to improve the
quality of all of the manual pages. In the interim a Github pull request
would be most welcome.
Joshua
On 05/07/2018 21:44, Scheie, Peter M wrote:
> BTW, there's a grammatical error in the man page for tpm2_unseal. What's the best way to get that fixed? (Sorry, my mother was an English major).
>
> Peter
>
> -----Original Message-----
> From: Joshua Lock [mailto:joshua.g.lock(a)linux.intel.com]
> Sent: Wednesday, July 04, 2018 5:10 AM
> To: Matthias Gerstner; Scheie, Peter M
> Cc: tpm2(a)lists.01.org
> Subject: Re: [tpm2] tpm2-tools man pages not installing?
>
>
>
> On 03/07/2018 15:53, Matthias Gerstner wrote:
>> Hello,
>>
>> On Tue, Jul 03, 2018 at 01:46:14PM +0000, Scheie, Peter M wrote:
>>> When I build & install tpm2-tools, the man pages don't seem to get
>>> installed. I'm just using the default './configure; make; sudo make
>>> install' routine, so everything is going into /usr/local/; therefore,
>>> I'd expect the man pages to end up in /usr/local/share/man, but they
>>> don't. Do I need add an argument to configure to make that happen?
>>
>> that is actually a bug and I addressed it via commit
>> 72a28f36151db9bfa59a460ae0114dcece218862, however that commit didn't
>> make it into the current release.
>>
>> So you either have to install them manually or, as a workaround, if you
>> have pandoc installed on the system, then the build system tries to
>> generate the man pages and alongside that also installs them.
>
> Thanks for the report Peter and for pointing to the fix Matthias. I've
> backported the change to the 3.X branch and tagged a release candidate
> for 3.1.1 which includes the fix:
>
> https://github.com/tpm2-software/tpm2-tools/releases/tag/3.1.1-rc0
>
> Regards,
> Joshua
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tpm2] tpm2-tools man pages not installing?
@ 2018-07-06 17:12 Roberts, William C
0 siblings, 0 replies; 11+ messages in thread
From: Roberts, William C @ 2018-07-06 17:12 UTC (permalink / raw)
To: tpm2
[-- Attachment #1: Type: text/plain, Size: 3992 bytes --]
So you don't push to the origin remote. You need to fork, push to your fork and then
Create a Pull Request (PR) back to the project. This should answer your questions here:
https://blog.scottlowe.org/2015/01/27/using-fork-branch-git-workflow/
Let me know if you run into issues, just PM me.
> -----Original Message-----
> From: tpm2 [mailto:tpm2-bounces(a)lists.01.org] On Behalf Of Scheie, Peter M
> Sent: Friday, July 6, 2018 8:19 AM
> To: Joshua Lock <joshua.g.lock(a)linux.intel.com>
> Cc: tpm2(a)lists.01.org
> Subject: Re: [tpm2] tpm2-tools man pages not installing?
>
> I don't think I have permission to push my branch to github, do I? When I do a 'git
> push origin update-tpm2-unseal-man-page' I get a 'remote: Permission to tpm2-
> software/tpm2-tools.git denied to pscheie" error, which isn't surprising as you
> wouldn't want every Tom, Dick, and Harry pushing branches up. But I think I have
> to have my branch pushed before I can create a pull request, right? (Otherwise,
> people can't see the changes I made.)
>
> Peter
>
> -----Original Message-----
> From: Scheie, Peter M
> Sent: Friday, July 06, 2018 9:10 AM
> To: 'Joshua Lock'
> Cc: tpm2(a)lists.01.org
> Subject: RE: [tpm2] tpm2-tools man pages not installing?
>
> Heh, when your message arrived, I was just reading through your pull request for
> "object auth short form unification" and discovered why I'm having so much
> trouble with tpm2_create (the argument letters changed last week). :-)
>
> Anyway, I'm glad to help out if I can, so I'll do the pull request I'm not very good
> with git, so I may have questions.
>
> Peter
>
> -----Original Message-----
> From: Joshua Lock [mailto:joshua.g.lock(a)linux.intel.com]
> Sent: Friday, July 06, 2018 8:49 AM
> To: Scheie, Peter M
> Cc: tpm2(a)lists.01.org
> Subject: Re: [tpm2] tpm2-tools man pages not installing?
>
> No need to apologise, we do have plans to review and try to improve the quality
> of all of the manual pages. In the interim a Github pull request would be most
> welcome.
>
> Joshua
>
> On 05/07/2018 21:44, Scheie, Peter M wrote:
> > BTW, there's a grammatical error in the man page for tpm2_unseal. What's the
> best way to get that fixed? (Sorry, my mother was an English major).
> >
> > Peter
> >
> > -----Original Message-----
> > From: Joshua Lock [mailto:joshua.g.lock(a)linux.intel.com]
> > Sent: Wednesday, July 04, 2018 5:10 AM
> > To: Matthias Gerstner; Scheie, Peter M
> > Cc: tpm2(a)lists.01.org
> > Subject: Re: [tpm2] tpm2-tools man pages not installing?
> >
> >
> >
> > On 03/07/2018 15:53, Matthias Gerstner wrote:
> >> Hello,
> >>
> >> On Tue, Jul 03, 2018 at 01:46:14PM +0000, Scheie, Peter M wrote:
> >>> When I build & install tpm2-tools, the man pages don't seem to get
> >>> installed. I'm just using the default './configure; make; sudo make
> >>> install' routine, so everything is going into /usr/local/;
> >>> therefore, I'd expect the man pages to end up in
> >>> /usr/local/share/man, but they don't. Do I need add an argument to
> configure to make that happen?
> >>
> >> that is actually a bug and I addressed it via commit
> >> 72a28f36151db9bfa59a460ae0114dcece218862, however that commit didn't
> >> make it into the current release.
> >>
> >> So you either have to install them manually or, as a workaround, if
> >> you have pandoc installed on the system, then the build system tries
> >> to generate the man pages and alongside that also installs them.
> >
> > Thanks for the report Peter and for pointing to the fix Matthias. I've
> > backported the change to the 3.X branch and tagged a release candidate
> > for 3.1.1 which includes the fix:
> >
> > https://github.com/tpm2-software/tpm2-tools/releases/tag/3.1.1-rc0
> >
> > Regards,
> > Joshua
> >
> _______________________________________________
> tpm2 mailing list
> tpm2(a)lists.01.org
> https://lists.01.org/mailman/listinfo/tpm2
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [tpm2] tpm2-tools man pages not installing?
@ 2018-07-06 17:30 Scheie, Peter M
0 siblings, 0 replies; 11+ messages in thread
From: Scheie, Peter M @ 2018-07-06 17:30 UTC (permalink / raw)
To: tpm2
[-- Attachment #1: Type: text/plain, Size: 5811 bytes --]
Matthias sent me the message below; it was the git fork step I was missing (I was just cloning & branching). Okay, now we're in business...well, almost. It appears the company firewall is blocking me from pushing my changes up to my fork, which other devs have confirmed. (Bringing info from the outside in is okay, but going the other way is often blocked. Yum gets broken regularly, too.) I've put in a request to get access to push to github. That will probably take a few days, so I'll probably just push the changes from home tonight.
Matthias, thanks for the steps in your other message; they were very helpful.
(I hope top-posting is okay.)
Peter
--
Hi Peter,
what you need to do is:
1) have a personal accounton Github
2) fork the tpm2 repository via the Github web interface (it's a button found on the repository page once you're logged in)
3) now you can clone your personal fork of the tpm2 repository that lives under your personal Github namespace
4) once you're done with your work you can push to your personal, forked repository and it becomes visible to the public on Github
5) now you can create a pull-request from your fork to the origin repository via the Github web interface.
Hope that helps :-)
Cheers
Matthias
--
Matthias Gerstner <matthias.gerstner(a)suse.de> Dipl.-Wirtsch.-Inf. (FH), Security Engineer https://www.suse.com/security
Telefon: +49 911 740 53 290
GPG Key ID: 0x14C405C971923553
SUSE Linux GmbH
GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nuernberg)
-----Original Message-----
From: Roberts, William C [mailto:william.c.roberts(a)intel.com]
Sent: Friday, July 06, 2018 12:13 PM
To: Scheie, Peter M; Joshua Lock
Cc: tpm2(a)lists.01.org
Subject: RE: [tpm2] tpm2-tools man pages not installing?
So you don't push to the origin remote. You need to fork, push to your fork and then
Create a Pull Request (PR) back to the project. This should answer your questions here:
https://blog.scottlowe.org/2015/01/27/using-fork-branch-git-workflow/
Let me know if you run into issues, just PM me.
> -----Original Message-----
> From: tpm2 [mailto:tpm2-bounces(a)lists.01.org] On Behalf Of Scheie, Peter M
> Sent: Friday, July 6, 2018 8:19 AM
> To: Joshua Lock <joshua.g.lock(a)linux.intel.com>
> Cc: tpm2(a)lists.01.org
> Subject: Re: [tpm2] tpm2-tools man pages not installing?
>
> I don't think I have permission to push my branch to github, do I? When I do a 'git
> push origin update-tpm2-unseal-man-page' I get a 'remote: Permission to tpm2-
> software/tpm2-tools.git denied to pscheie" error, which isn't surprising as you
> wouldn't want every Tom, Dick, and Harry pushing branches up. But I think I have
> to have my branch pushed before I can create a pull request, right? (Otherwise,
> people can't see the changes I made.)
>
> Peter
>
> -----Original Message-----
> From: Scheie, Peter M
> Sent: Friday, July 06, 2018 9:10 AM
> To: 'Joshua Lock'
> Cc: tpm2(a)lists.01.org
> Subject: RE: [tpm2] tpm2-tools man pages not installing?
>
> Heh, when your message arrived, I was just reading through your pull request for
> "object auth short form unification" and discovered why I'm having so much
> trouble with tpm2_create (the argument letters changed last week). :-)
>
> Anyway, I'm glad to help out if I can, so I'll do the pull request I'm not very good
> with git, so I may have questions.
>
> Peter
>
> -----Original Message-----
> From: Joshua Lock [mailto:joshua.g.lock(a)linux.intel.com]
> Sent: Friday, July 06, 2018 8:49 AM
> To: Scheie, Peter M
> Cc: tpm2(a)lists.01.org
> Subject: Re: [tpm2] tpm2-tools man pages not installing?
>
> No need to apologise, we do have plans to review and try to improve the quality
> of all of the manual pages. In the interim a Github pull request would be most
> welcome.
>
> Joshua
>
> On 05/07/2018 21:44, Scheie, Peter M wrote:
> > BTW, there's a grammatical error in the man page for tpm2_unseal. What's the
> best way to get that fixed? (Sorry, my mother was an English major).
> >
> > Peter
> >
> > -----Original Message-----
> > From: Joshua Lock [mailto:joshua.g.lock(a)linux.intel.com]
> > Sent: Wednesday, July 04, 2018 5:10 AM
> > To: Matthias Gerstner; Scheie, Peter M
> > Cc: tpm2(a)lists.01.org
> > Subject: Re: [tpm2] tpm2-tools man pages not installing?
> >
> >
> >
> > On 03/07/2018 15:53, Matthias Gerstner wrote:
> >> Hello,
> >>
> >> On Tue, Jul 03, 2018 at 01:46:14PM +0000, Scheie, Peter M wrote:
> >>> When I build & install tpm2-tools, the man pages don't seem to get
> >>> installed. I'm just using the default './configure; make; sudo make
> >>> install' routine, so everything is going into /usr/local/;
> >>> therefore, I'd expect the man pages to end up in
> >>> /usr/local/share/man, but they don't. Do I need add an argument to
> configure to make that happen?
> >>
> >> that is actually a bug and I addressed it via commit
> >> 72a28f36151db9bfa59a460ae0114dcece218862, however that commit didn't
> >> make it into the current release.
> >>
> >> So you either have to install them manually or, as a workaround, if
> >> you have pandoc installed on the system, then the build system tries
> >> to generate the man pages and alongside that also installs them.
> >
> > Thanks for the report Peter and for pointing to the fix Matthias. I've
> > backported the change to the 3.X branch and tagged a release candidate
> > for 3.1.1 which includes the fix:
> >
> > https://github.com/tpm2-software/tpm2-tools/releases/tag/3.1.1-rc0
> >
> > Regards,
> > Joshua
> >
> _______________________________________________
> tpm2 mailing list
> tpm2(a)lists.01.org
> https://lists.01.org/mailman/listinfo/tpm2
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-07-06 17:30 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-03 17:49 [tpm2] tpm2-tools man pages not installing? Philip Tricca
-- strict thread matches above, loose matches on Subject: below --
2018-07-06 17:30 Scheie, Peter M
2018-07-06 17:12 Roberts, William C
2018-07-06 15:19 Scheie, Peter M
2018-07-06 14:10 Scheie, Peter M
2018-07-06 13:48 Joshua Lock
2018-07-05 20:44 Scheie, Peter M
2018-07-04 10:09 Joshua Lock
2018-07-03 17:41 Scheie, Peter M
2018-07-03 14:53 Matthias Gerstner
2018-07-03 13:46 Scheie, Peter M
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.