From: Baoquan He <bhe@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Nicolas Pitre" <nicolas.pitre@linaro.org>,
brijesh.singh@amd.com, devicetree <devicetree@vger.kernel.org>,
"David Airlie" <airlied@linux.ie>,
linux-pci@vger.kernel.org, richard.weiyang@gmail.com,
"Keith Busch" <keith.busch@intel.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Paul Mackerras" <paulus@samba.org>,
baiyaowei@cmss.chinamobile.com,
"KY Srinivasan" <kys@microsoft.com>,
"Frank Rowand" <frowand.list@gmail.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Stephen Hemminger" <sthemmin@microsoft.com>,
linux-nvdimm@lists.01.org,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
linux-input <linux-input@vger.kernel.org>,
"Gustavo Padovan" <gustavo@padovan.org>,
"Borislav Petkov" <bp@suse.de>, "Dave Young" <dyoung@redhat.com>,
"Vivek Goyal" <vgoyal@redhat.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Josh Triplett" <josh@joshtriplett.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Sean Paul" <seanpaul@chromium.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Yinghai Lu" <yinghai@kernel.org>,
"Jon Derrick" <jonathan.derrick@intel.com>,
"Chris Zankel" <chris@zankel.net>,
"Michal Simek" <monstr@monstr.eu>,
linux-parisc@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
kexec@lists.infradead.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Eric Biederman" <ebiederm@xmission.com>,
devel@linuxdriverproject.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"kbuild test robot" <fengguang.wu@intel.com>,
"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT"
<linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
Date: Wed, 4 Jul 2018 12:18:34 +0800 [thread overview]
Message-ID: <20180704041834.GA2762@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CAHp75VeEjhcYF4Fy4O_srdv_nEGGjGwAHhZufscB_tiLQVQ=FQ@mail.gmail.com>
On 07/03/18 at 11:57pm, Andy Shevchenko wrote:
> On Tue, Jul 3, 2018 at 5:55 PM, Baoquan He <bhe@redhat.com> wrote:
> > On 06/12/18 at 05:24pm, Andy Shevchenko wrote:
> >> On Tue, Jun 12, 2018 at 5:20 PM, Andy Shevchenko
> >> <andy.shevchenko@gmail.com> wrote:
>
> >> > I briefly looked at the code and error codes we have, so, my proposal
> >> > is one of the following
> >>
> >> > - use -ECANCELED (not the best choice for first occurrence here,
> >> > though I can't find better)
> >>
> >> Actually -ENOTSUPP might suit the first case (although the actual
> >> would be something like -EOVERLAP, which we don't have)
> >
> > Sorry for late reply, and many thanks for your great suggestion.
> >
>
> > I am fine to use -ENOTSUPP as the first returned value, and -ECANCELED
> > for the 2nd one.
>
> I have no strong opinion, but I like (slightly better) this approach ^^^
Done, post v6 in this way, many thanks.
>
> > Or define an enum as you suggested inside the function
> > or in header file.
>
> >
> > Or use -EBUSY for the first case because existing resource is
> > overlapping but not fully contained by 'res'; and -EINVAL for
> > the 2nd case since didn't find any one resources which is contained by
> > 'res', means we passed in a invalid resource.
> >
> > All is fine to me, I can repost with each of them.
>
> >> > - use positive integers (or enum), like
> >> > #define RES_REPARENTED 0
> >> > #define RES_OVERLAPPED 1
> >> > #define RES_NOCONFLICT 2
>
> --
> With Best Regards,
> Andy Shevchenko
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Andy Shevchenko
<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Nicolas Pitre
<nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
brijesh.singh-5C7GfCeVMHo@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Max Filippov <jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
baiyaowei-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/@public.gmane.org,
KY Srinivasan <kys-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
Frank Rowand
<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Lorenzo Pieralisi
<lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>,
Stephen Hemminger
<sthemmin-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>,
Patrik Jakobsson
<patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-input <linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Gustavo Padovan <gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org>,
Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>,
Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Tom Lendacky <thomas.lendacky-5C7GfCeVMHo@public.gmane.org>,
Haiyang Zhang <haiyangz-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
Maarten Lankhorst
<maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Josh Triplett <josh@joshtri>
Subject: Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
Date: Wed, 4 Jul 2018 12:18:34 +0800 [thread overview]
Message-ID: <20180704041834.GA2762@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CAHp75VeEjhcYF4Fy4O_srdv_nEGGjGwAHhZufscB_tiLQVQ=FQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 07/03/18 at 11:57pm, Andy Shevchenko wrote:
> On Tue, Jul 3, 2018 at 5:55 PM, Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> > On 06/12/18 at 05:24pm, Andy Shevchenko wrote:
> >> On Tue, Jun 12, 2018 at 5:20 PM, Andy Shevchenko
> >> <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> >> > I briefly looked at the code and error codes we have, so, my proposal
> >> > is one of the following
> >>
> >> > - use -ECANCELED (not the best choice for first occurrence here,
> >> > though I can't find better)
> >>
> >> Actually -ENOTSUPP might suit the first case (although the actual
> >> would be something like -EOVERLAP, which we don't have)
> >
> > Sorry for late reply, and many thanks for your great suggestion.
> >
>
> > I am fine to use -ENOTSUPP as the first returned value, and -ECANCELED
> > for the 2nd one.
>
> I have no strong opinion, but I like (slightly better) this approach ^^^
Done, post v6 in this way, many thanks.
>
> > Or define an enum as you suggested inside the function
> > or in header file.
>
> >
> > Or use -EBUSY for the first case because existing resource is
> > overlapping but not fully contained by 'res'; and -EINVAL for
> > the 2nd case since didn't find any one resources which is contained by
> > 'res', means we passed in a invalid resource.
> >
> > All is fine to me, I can repost with each of them.
>
> >> > - use positive integers (or enum), like
> >> > #define RES_REPARENTED 0
> >> > #define RES_OVERLAPPED 1
> >> > #define RES_NOCONFLICT 2
>
> --
> With Best Regards,
> Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Nicolas Pitre" <nicolas.pitre@linaro.org>,
brijesh.singh@amd.com, devicetree <devicetree@vger.kernel.org>,
"David Airlie" <airlied@linux.ie>,
linux-pci@vger.kernel.org, richard.weiyang@gmail.com,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Paul Mackerras" <paulus@samba.org>,
baiyaowei@cmss.chinamobile.com,
"KY Srinivasan" <kys@microsoft.com>,
"Frank Rowand" <frowand.list@gmail.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Stephen Hemminger" <sthemmin@microsoft.com>,
linux-nvdimm@lists.01.org,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
linux-input <linux-input@vger.kernel.org>,
"Gustavo Padovan" <gustavo@padovan.org>,
"Borislav Petkov" <bp@suse.de>, "Dave Young" <dyoung@redhat.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Josh Triplett" <josh@joshtriplett.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Sean Paul" <seanpaul@chromium.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Yinghai Lu" <yinghai@kernel.org>,
"Jon Derrick" <jonathan.derrick@intel.com>,
"Chris Zankel" <chris@zankel.net>,
"Michal Simek" <monstr@monstr.eu>,
linux-parisc@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
kexec@lists.infradead.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Eric Biederman" <ebiederm@xmission.com>,
devel@linuxdriverproject.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"kbuild test robot" <fengguang.wu@intel.com>,
"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT"
<linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
Date: Wed, 4 Jul 2018 12:18:34 +0800 [thread overview]
Message-ID: <20180704041834.GA2762@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CAHp75VeEjhcYF4Fy4O_srdv_nEGGjGwAHhZufscB_tiLQVQ=FQ@mail.gmail.com>
On 07/03/18 at 11:57pm, Andy Shevchenko wrote:
> On Tue, Jul 3, 2018 at 5:55 PM, Baoquan He <bhe@redhat.com> wrote:
> > On 06/12/18 at 05:24pm, Andy Shevchenko wrote:
> >> On Tue, Jun 12, 2018 at 5:20 PM, Andy Shevchenko
> >> <andy.shevchenko@gmail.com> wrote:
>
> >> > I briefly looked at the code and error codes we have, so, my proposal
> >> > is one of the following
> >>
> >> > - use -ECANCELED (not the best choice for first occurrence here,
> >> > though I can't find better)
> >>
> >> Actually -ENOTSUPP might suit the first case (although the actual
> >> would be something like -EOVERLAP, which we don't have)
> >
> > Sorry for late reply, and many thanks for your great suggestion.
> >
>
> > I am fine to use -ENOTSUPP as the first returned value, and -ECANCELED
> > for the 2nd one.
>
> I have no strong opinion, but I like (slightly better) this approach ^^^
Done, post v6 in this way, many thanks.
>
> > Or define an enum as you suggested inside the function
> > or in header file.
>
> >
> > Or use -EBUSY for the first case because existing resource is
> > overlapping but not fully contained by 'res'; and -EINVAL for
> > the 2nd case since didn't find any one resources which is contained by
> > 'res', means we passed in a invalid resource.
> >
> > All is fine to me, I can repost with each of them.
>
> >> > - use positive integers (or enum), like
> >> > #define RES_REPARENTED 0
> >> > #define RES_OVERLAPPED 1
> >> > #define RES_NOCONFLICT 2
>
> --
> With Best Regards,
> Andy Shevchenko
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Andy Shevchenko
<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Nicolas Pitre
<nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
brijesh.singh-5C7GfCeVMHo@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
Max Filippov <jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
baiyaowei-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/@public.gmane.org,
KY Srinivasan <kys-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
Frank Rowand
<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Lorenzo Pieralisi
<lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>,
Stephen Hemminger
<sthemmin-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>,
Patrik Jakobsson
<patrik.r.jakobsson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-input <linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Gustavo Padovan <gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org>,
Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>,
Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Tom Lendacky <thomas.lendacky-5C7GfCeVMHo@public.gmane.org>,
Haiyang Zhang <haiyangz-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
Maarten Lankhorst
<maarten.lankhorst-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Josh Triplett <josh@joshtri
Subject: Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
Date: Wed, 4 Jul 2018 12:18:34 +0800 [thread overview]
Message-ID: <20180704041834.GA2762@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CAHp75VeEjhcYF4Fy4O_srdv_nEGGjGwAHhZufscB_tiLQVQ=FQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 07/03/18 at 11:57pm, Andy Shevchenko wrote:
> On Tue, Jul 3, 2018 at 5:55 PM, Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> > On 06/12/18 at 05:24pm, Andy Shevchenko wrote:
> >> On Tue, Jun 12, 2018 at 5:20 PM, Andy Shevchenko
> >> <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> >> > I briefly looked at the code and error codes we have, so, my proposal
> >> > is one of the following
> >>
> >> > - use -ECANCELED (not the best choice for first occurrence here,
> >> > though I can't find better)
> >>
> >> Actually -ENOTSUPP might suit the first case (although the actual
> >> would be something like -EOVERLAP, which we don't have)
> >
> > Sorry for late reply, and many thanks for your great suggestion.
> >
>
> > I am fine to use -ENOTSUPP as the first returned value, and -ECANCELED
> > for the 2nd one.
>
> I have no strong opinion, but I like (slightly better) this approach ^^^
Done, post v6 in this way, many thanks.
>
> > Or define an enum as you suggested inside the function
> > or in header file.
>
> >
> > Or use -EBUSY for the first case because existing resource is
> > overlapping but not fully contained by 'res'; and -EINVAL for
> > the 2nd case since didn't find any one resources which is contained by
> > 'res', means we passed in a invalid resource.
> >
> > All is fine to me, I can repost with each of them.
>
> >> > - use positive integers (or enum), like
> >> > #define RES_REPARENTED 0
> >> > #define RES_OVERLAPPED 1
> >> > #define RES_NOCONFLICT 2
>
> --
> With Best Regards,
> Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Nicolas Pitre" <nicolas.pitre@linaro.org>,
"Josh Triplett" <josh@joshtriplett.org>,
"kbuild test robot" <fengguang.wu@intel.com>,
"Borislav Petkov" <bp@suse.de>,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
"David Airlie" <airlied@linux.ie>,
"KY Srinivasan" <kys@microsoft.com>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Stephen Hemminger" <sthemmin@microsoft.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Frank Rowand" <frowand.list@gmail.com>,
"Keith Busch" <keith.busch@intel.com>,
"Jon Derrick" <jonathan.derrick@intel.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
brijesh.singh@amd.com, "Jérôme Glisse" <jglisse@redhat.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
baiyaowei@cmss.chinamobile.com, richard.weiyang@gmail.com,
devel@linuxdriverproject.org,
linux-input <linux-input@vger.kernel.org>,
linux-nvdimm@lists.01.org,
devicetree <devicetree@vger.kernel.org>,
linux-pci@vger.kernel.org,
"Eric Biederman" <ebiederm@xmission.com>,
"Vivek Goyal" <vgoyal@redhat.com>,
"Dave Young" <dyoung@redhat.com>,
"Yinghai Lu" <yinghai@kernel.org>,
kexec@lists.infradead.org, "Michal Simek" <monstr@monstr.eu>,
"David S. Miller" <davem@davemloft.net>,
"Chris Zankel" <chris@zankel.net>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Gustavo Padovan" <gustavo@padovan.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Sean Paul" <seanpaul@chromium.org>,
linux-parisc@vger.kernel.org,
"open list:LINUX FOR POWERPC PA SEMI PWRFICIENT"
<linuxppc-dev@lists.ozlabs.org>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"Michael Ellerman" <mpe@ellerman.id.au>
Subject: Re: [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public
Date: Wed, 4 Jul 2018 12:18:34 +0800 [thread overview]
Message-ID: <20180704041834.GA2762@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CAHp75VeEjhcYF4Fy4O_srdv_nEGGjGwAHhZufscB_tiLQVQ=FQ@mail.gmail.com>
On 07/03/18 at 11:57pm, Andy Shevchenko wrote:
> On Tue, Jul 3, 2018 at 5:55 PM, Baoquan He <bhe@redhat.com> wrote:
> > On 06/12/18 at 05:24pm, Andy Shevchenko wrote:
> >> On Tue, Jun 12, 2018 at 5:20 PM, Andy Shevchenko
> >> <andy.shevchenko@gmail.com> wrote:
>
> >> > I briefly looked at the code and error codes we have, so, my proposal
> >> > is one of the following
> >>
> >> > - use -ECANCELED (not the best choice for first occurrence here,
> >> > though I can't find better)
> >>
> >> Actually -ENOTSUPP might suit the first case (although the actual
> >> would be something like -EOVERLAP, which we don't have)
> >
> > Sorry for late reply, and many thanks for your great suggestion.
> >
>
> > I am fine to use -ENOTSUPP as the first returned value, and -ECANCELED
> > for the 2nd one.
>
> I have no strong opinion, but I like (slightly better) this approach ^^^
Done, post v6 in this way, many thanks.
>
> > Or define an enum as you suggested inside the function
> > or in header file.
>
> >
> > Or use -EBUSY for the first case because existing resource is
> > overlapping but not fully contained by 'res'; and -EINVAL for
> > the 2nd case since didn't find any one resources which is contained by
> > 'res', means we passed in a invalid resource.
> >
> > All is fine to me, I can repost with each of them.
>
> >> > - use positive integers (or enum), like
> >> > #define RES_REPARENTED 0
> >> > #define RES_OVERLAPPED 1
> >> > #define RES_NOCONFLICT 2
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2018-07-04 4:18 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 3:28 [PATCH v5 0/4] resource: Use list_head to link sibling resource Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` [PATCH v5 1/4] resource: Move reparent_resources() to kernel/resource.c and make it public Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:34 ` Baoquan He
2018-06-12 3:34 ` Baoquan He
2018-06-12 3:34 ` Baoquan He
2018-06-12 3:34 ` Baoquan He
2018-06-12 3:34 ` Baoquan He
2018-06-12 3:55 ` kbuild test robot
2018-06-12 3:55 ` kbuild test robot
2018-06-12 3:55 ` kbuild test robot
2018-06-12 3:55 ` kbuild test robot
2018-06-12 3:55 ` kbuild test robot
2018-06-12 8:29 ` Andy Shevchenko
2018-06-12 8:29 ` Andy Shevchenko
2018-06-12 8:29 ` Andy Shevchenko
2018-06-12 8:29 ` Andy Shevchenko
2018-06-12 8:29 ` Andy Shevchenko
2018-06-12 9:38 ` Baoquan He
2018-06-12 9:38 ` Baoquan He
2018-06-12 9:38 ` Baoquan He
2018-06-12 9:38 ` Baoquan He
2018-06-12 9:38 ` Baoquan He
2018-06-12 14:20 ` Andy Shevchenko
2018-06-12 14:20 ` Andy Shevchenko
2018-06-12 14:20 ` Andy Shevchenko
2018-06-12 14:20 ` Andy Shevchenko
2018-06-12 14:20 ` Andy Shevchenko
2018-06-12 14:24 ` Andy Shevchenko
2018-06-12 14:24 ` Andy Shevchenko
2018-06-12 14:24 ` Andy Shevchenko
2018-06-12 14:24 ` Andy Shevchenko
2018-06-12 14:24 ` Andy Shevchenko
2018-07-03 14:55 ` Baoquan He
2018-07-03 14:55 ` Baoquan He
2018-07-03 14:55 ` Baoquan He
2018-07-03 14:55 ` Baoquan He
2018-07-03 14:55 ` Baoquan He
2018-07-03 20:57 ` Andy Shevchenko
2018-07-03 20:57 ` Andy Shevchenko
2018-07-03 20:57 ` Andy Shevchenko
2018-07-03 20:57 ` Andy Shevchenko
2018-07-04 4:18 ` Baoquan He [this message]
2018-07-04 4:18 ` Baoquan He
2018-07-04 4:18 ` Baoquan He
2018-07-04 4:18 ` Baoquan He
2018-07-04 4:18 ` Baoquan He
2018-06-12 9:49 ` Baoquan He
2018-06-12 9:49 ` Baoquan He
2018-06-12 9:49 ` Baoquan He
2018-06-12 9:49 ` Baoquan He
2018-06-12 9:49 ` Baoquan He
2018-06-12 3:28 ` [PATCH v5 2/4] resource: Use list_head to link sibling resource Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 4:37 ` kbuild test robot
2018-06-12 4:37 ` kbuild test robot
2018-06-12 4:37 ` kbuild test robot
2018-06-12 4:37 ` kbuild test robot
2018-06-12 4:37 ` kbuild test robot
2018-06-12 4:49 ` kbuild test robot
2018-06-12 4:49 ` kbuild test robot
2018-06-12 4:49 ` kbuild test robot
2018-06-12 4:49 ` kbuild test robot
2018-06-12 4:49 ` kbuild test robot
2018-06-12 3:28 ` [PATCH v5 3/4] resource: add walk_system_ram_res_rev() Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` [PATCH v5 4/4] kexec_file: Load kernel at top of system RAM if required Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` Baoquan He
2018-06-12 3:28 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704041834.GA2762@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=chris@zankel.net \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=fengguang.wu@intel.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@padovan.org \
--cc=haiyangz@microsoft.com \
--cc=jcmvbkbc@gmail.com \
--cc=jglisse@redhat.com \
--cc=jonathan.derrick@intel.com \
--cc=josh@joshtriplett.org \
--cc=keith.busch@intel.com \
--cc=kexec@lists.infradead.org \
--cc=kys@microsoft.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=nicolas.pitre@linaro.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=paulus@samba.org \
--cc=richard.weiyang@gmail.com \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vgoyal@redhat.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.