From: Lee Jones <lee.jones@linaro.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Johan Hovold <johan@kernel.org>,
Octavian Purdila <tavi@cs.pub.ro>,
lkml <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org, tglx@linutronix.de
Subject: [v2] mfd: dln2: use irqsave() in USB's complete callback
Date: Wed, 4 Jul 2018 08:40:23 +0100 [thread overview]
Message-ID: <20180704074023.GN20176@dell> (raw)
On Mon, 02 Jul 2018, Sebastian Andrzej Siewior wrote:
> The USB completion callback does not disable interrupts while acquiring
> the lock. We want to remove the local_irq_disable() invocation from
> __usb_hcd_giveback_urb() and therefore it is required for the callback
> handler to disable the interrupts while acquiring the lock.
> The callback may be invoked either in IRQ or BH context depending on the
> USB host controller.
> Use the _irqsave() variant of the locking primitives.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Octavian Purdila <tavi@cs.pub.ro>
> Reviewed-by: Johan Hovold <johan@kernel.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> v1…v2: Remove also the comment that says that there is no need to
> disable interrupts.
>
> drivers/mfd/dln2.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Johan Hovold <johan@kernel.org>,
Octavian Purdila <tavi@cs.pub.ro>,
lkml <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH v2] mfd: dln2: use irqsave() in USB's complete callback
Date: Wed, 4 Jul 2018 08:40:23 +0100 [thread overview]
Message-ID: <20180704074023.GN20176@dell> (raw)
In-Reply-To: <20180702073132.vrbvrdrht3ipwhq7@linutronix.de>
On Mon, 02 Jul 2018, Sebastian Andrzej Siewior wrote:
> The USB completion callback does not disable interrupts while acquiring
> the lock. We want to remove the local_irq_disable() invocation from
> __usb_hcd_giveback_urb() and therefore it is required for the callback
> handler to disable the interrupts while acquiring the lock.
> The callback may be invoked either in IRQ or BH context depending on the
> USB host controller.
> Use the _irqsave() variant of the locking primitives.
>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Octavian Purdila <tavi@cs.pub.ro>
> Reviewed-by: Johan Hovold <johan@kernel.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> v1…v2: Remove also the comment that says that there is no need to
> disable interrupts.
>
> drivers/mfd/dln2.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next reply other threads:[~2018-07-04 7:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 7:40 Lee Jones [this message]
2018-07-04 7:40 ` [PATCH v2] mfd: dln2: use irqsave() in USB's complete callback Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2018-07-02 7:31 [v2] " Sebastian Andrzej Siewior
2018-07-02 7:31 ` [PATCH v2] " Sebastian Andrzej Siewior
2018-07-02 6:24 [REPOST] " Johan Hovold
2018-07-02 6:24 ` [PATCH REPOST] " Johan Hovold
2018-07-01 22:07 [REPOST] " Octavian Purdila
2018-07-01 22:07 ` [PATCH REPOST] " Octavian Purdila
2018-07-01 15:41 [REPOST] " Sebastian Andrzej Siewior
2018-07-01 15:41 ` [PATCH REPOST] " Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704074023.GN20176@dell \
--to=lee.jones@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tavi@cs.pub.ro \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.