All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
	Jani Nikula <jani.nikula@intel.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] backlight: remove obsolete comment for ->state
Date: Wed, 4 Jul 2018 10:38:16 +0100	[thread overview]
Message-ID: <20180704093816.GV20176@dell> (raw)
In-Reply-To: <20180704093447.GU20176@dell>

On Wed, 04 Jul 2018, Lee Jones wrote:

> > Jani spotted this when reviewing my earlier patch to remove the driver
> > internal usage of this field in
> > 
> > commit 3cf91adaa594e8933af1727942ac560e5c7bc70e
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date:   Wed Apr 25 19:42:52 2018 +0200
> > 
> >     backlight: Nuke BL_CORE_DRIVER1
> 
> FYI, sending patches like this is not a good idea.
> 
> I'll clean it up for you this time, but in future please send patches
> properly and place any additional comments you may have below the
> '---' line.

Ah, I see what you've tried to do.  This hurt my eyes! :)

It's more conventional to reference commits like:

  Commit 3cf91adaa594 ("backlight: Nuke BL_CORE_DRIVER1")

Again, I'll make the amendment to avoid further confusion.

> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Daniel Thompson <daniel.thompson@linaro.org>
> > Cc: Jingoo Han <jingoohan1@gmail.com>
> > ---
> >  include/linux/backlight.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> > index 7fbf0539e14a..0b5897446dca 100644
> > --- a/include/linux/backlight.h
> > +++ b/include/linux/backlight.h
> > @@ -79,7 +79,6 @@ struct backlight_properties {
> >  	/* Backlight type */
> >  	enum backlight_type type;
> >  	/* Flags used to signal drivers of state changes */
> > -	/* Upper 4 bits are reserved for driver internal use */
> >  	unsigned int state;
> >  
> >  #define BL_CORE_SUSPENDED	(1 << 0)	/* backlight is suspended */
> 

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: LKML <linux-kernel@vger.kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Jani Nikula <jani.nikula@intel.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>
Subject: Re: [PATCH] backlight: remove obsolete comment for ->state
Date: Wed, 4 Jul 2018 10:38:16 +0100	[thread overview]
Message-ID: <20180704093816.GV20176@dell> (raw)
In-Reply-To: <20180704093447.GU20176@dell>

On Wed, 04 Jul 2018, Lee Jones wrote:

> > Jani spotted this when reviewing my earlier patch to remove the driver
> > internal usage of this field in
> > 
> > commit 3cf91adaa594e8933af1727942ac560e5c7bc70e
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date:   Wed Apr 25 19:42:52 2018 +0200
> > 
> >     backlight: Nuke BL_CORE_DRIVER1
> 
> FYI, sending patches like this is not a good idea.
> 
> I'll clean it up for you this time, but in future please send patches
> properly and place any additional comments you may have below the
> '---' line.

Ah, I see what you've tried to do.  This hurt my eyes! :)

It's more conventional to reference commits like:

  Commit 3cf91adaa594 ("backlight: Nuke BL_CORE_DRIVER1")

Again, I'll make the amendment to avoid further confusion.

> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Daniel Thompson <daniel.thompson@linaro.org>
> > Cc: Jingoo Han <jingoohan1@gmail.com>
> > ---
> >  include/linux/backlight.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> > index 7fbf0539e14a..0b5897446dca 100644
> > --- a/include/linux/backlight.h
> > +++ b/include/linux/backlight.h
> > @@ -79,7 +79,6 @@ struct backlight_properties {
> >  	/* Backlight type */
> >  	enum backlight_type type;
> >  	/* Flags used to signal drivers of state changes */
> > -	/* Upper 4 bits are reserved for driver internal use */
> >  	unsigned int state;
> >  
> >  #define BL_CORE_SUSPENDED	(1 << 0)	/* backlight is suspended */
> 

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2018-07-04  9:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 14:15 [PATCH] backlight: remove obsolete comment for ->state Daniel Vetter
2018-05-03 14:32 ` Daniel Thompson
2018-05-03 14:32   ` Daniel Thompson
2018-07-04  9:18   ` Daniel Vetter
2018-07-04  9:18     ` Daniel Vetter
2018-07-04  9:34 ` Lee Jones
2018-07-04  9:34   ` Lee Jones
2018-07-04  9:38   ` Lee Jones [this message]
2018-07-04  9:38     ` Lee Jones
2018-07-04 10:05     ` Daniel Vetter
2018-07-04 10:05       ` Daniel Vetter
2018-07-04 10:34       ` Lee Jones
2018-07-04 10:34         ` Lee Jones
2018-07-04 11:49         ` Daniel Vetter
2018-07-04 11:49           ` Daniel Vetter
2018-07-04 12:10           ` Lee Jones
2018-07-04 12:10             ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180704093816.GV20176@dell \
    --to=lee.jones@linaro.org \
    --cc=daniel.thompson@linaro.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=jingoohan1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.