From: Will Deacon <will.deacon@arm.com>
To: Laura Abbott <labbott@redhat.com>
Cc: mjw@fedoraproject.org, "H . J . Lu" <hjl.tools@gmail.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Andy Lutomirski <luto@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
X86 ML <x86@kernel.org>,
linux-kernel@vger.kernel.org, Nick Clifton <nickc@redhat.com>,
Cary Coutant <ccoutant@gmail.com>,
linux-kbuild@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Michael Ellerman <mpe@ellerman.id.au>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv5 4/4] arm64: Add build salt to the vDSO
Date: Wed, 4 Jul 2018 18:36:15 +0100 [thread overview]
Message-ID: <20180704173615.GC9668@arm.com> (raw)
In-Reply-To: <20180703233430.14416-5-labbott@redhat.com>
On Tue, Jul 03, 2018 at 04:34:30PM -0700, Laura Abbott wrote:
>
> The vDSO needs to have a unique build id in a similar manner
> to the kernel and modules. Use the build salt macro.
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> v5: I was previously focused on x86 only but since powerpc gave a patch,
> I figured I would do arm64 since the changes were also fairly simple.
> ---
> arch/arm64/kernel/vdso/note.S | 3 +++
> 1 file changed, 3 insertions(+)
If you drop the trailing semicolon, then:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
> diff --git a/arch/arm64/kernel/vdso/note.S b/arch/arm64/kernel/vdso/note.S
> index b82c85e5d972..2c429dfd3f45 100644
> --- a/arch/arm64/kernel/vdso/note.S
> +++ b/arch/arm64/kernel/vdso/note.S
> @@ -22,7 +22,10 @@
> #include <linux/uts.h>
> #include <linux/version.h>
> #include <linux/elfnote.h>
> +#include <linux/build-salt.h>
>
> ELFNOTE_START(Linux, 0, "a")
> .long LINUX_VERSION_CODE
> ELFNOTE_END
> +
> +BUILD_SALT;
> --
> 2.17.1
>
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv5 4/4] arm64: Add build salt to the vDSO
Date: Wed, 4 Jul 2018 18:36:15 +0100 [thread overview]
Message-ID: <20180704173615.GC9668@arm.com> (raw)
In-Reply-To: <20180703233430.14416-5-labbott@redhat.com>
On Tue, Jul 03, 2018 at 04:34:30PM -0700, Laura Abbott wrote:
>
> The vDSO needs to have a unique build id in a similar manner
> to the kernel and modules. Use the build salt macro.
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> v5: I was previously focused on x86 only but since powerpc gave a patch,
> I figured I would do arm64 since the changes were also fairly simple.
> ---
> arch/arm64/kernel/vdso/note.S | 3 +++
> 1 file changed, 3 insertions(+)
If you drop the trailing semicolon, then:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
> diff --git a/arch/arm64/kernel/vdso/note.S b/arch/arm64/kernel/vdso/note.S
> index b82c85e5d972..2c429dfd3f45 100644
> --- a/arch/arm64/kernel/vdso/note.S
> +++ b/arch/arm64/kernel/vdso/note.S
> @@ -22,7 +22,10 @@
> #include <linux/uts.h>
> #include <linux/version.h>
> #include <linux/elfnote.h>
> +#include <linux/build-salt.h>
>
> ELFNOTE_START(Linux, 0, "a")
> .long LINUX_VERSION_CODE
> ELFNOTE_END
> +
> +BUILD_SALT;
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-07-04 17:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 23:34 [PATCHv5 0/4] Salted build ids via ELF notes Laura Abbott
2018-07-03 23:34 ` Laura Abbott
2018-07-03 23:34 ` [PATCHv5 1/4] kbuild: Add build salt to the kernel and modules Laura Abbott
2018-07-03 23:34 ` Laura Abbott
2018-07-04 3:59 ` Masahiro Yamada
2018-07-04 3:59 ` Masahiro Yamada
2018-07-05 19:20 ` Laura Abbott
2018-07-05 19:20 ` Laura Abbott
2018-07-03 23:34 ` [PATCHv5 2/4] x86: Add build salt to the vDSO Laura Abbott
2018-07-03 23:34 ` Laura Abbott
2018-07-05 15:58 ` Andy Lutomirski
2018-07-05 15:58 ` Andy Lutomirski
2018-07-05 19:08 ` Laura Abbott
2018-07-05 19:08 ` Laura Abbott
2018-07-05 21:46 ` Andy Lutomirski
2018-07-05 21:46 ` Andy Lutomirski
2018-07-03 23:34 ` [PATCHv5 3/4] powerpc: " Laura Abbott
2018-07-03 23:34 ` Laura Abbott
2018-07-03 23:34 ` [PATCHv5 4/4] arm64: " Laura Abbott
2018-07-03 23:34 ` Laura Abbott
2018-07-04 3:55 ` Masahiro Yamada
2018-07-04 3:55 ` Masahiro Yamada
2018-07-05 19:05 ` Laura Abbott
2018-07-05 19:05 ` Laura Abbott
2018-07-04 17:36 ` Will Deacon [this message]
2018-07-04 17:36 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704173615.GC9668@arm.com \
--to=will.deacon@arm.com \
--cc=catalin.marinas@arm.com \
--cc=ccoutant@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mjw@fedoraproject.org \
--cc=mpe@ellerman.id.au \
--cc=nickc@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.