From: Eryu Guan <guaneryu@gmail.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Liu Yiding <liuyd.fnst@cn.fujitsu.com>, fstests@vger.kernel.org
Subject: Re: [PATCH ] xfs/262: remove -y parameter
Date: Thu, 5 Jul 2018 13:49:45 +0800 [thread overview]
Message-ID: <20180705054945.GB2780@desktop> (raw)
In-Reply-To: <20180705040212.GC5703@magnolia>
On Wed, Jul 04, 2018 at 09:02:12PM -0700, Darrick J. Wong wrote:
> On Thu, Jul 05, 2018 at 09:37:03AM +0800, Liu Yiding wrote:
> > Since commit 66f7b4c2ce14 ("xfs_scrub: remove -y parameter") has removed parameter -y, -y is an invalid option.
But I couldn't find this commit in xfsprogs repo
git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
Is it already upstream?
> >
> > Signed-off-by: Liu Yiding <liuyd.fnst@cn.fujitsu.com>
>
> Good catch!
>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Thanks for the review!
Eryu
>
> --D
>
> > ---
> > tests/xfs/262 | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/xfs/262 b/tests/xfs/262
> > index 6c39268..b109f93 100755
> > --- a/tests/xfs/262
> > +++ b/tests/xfs/262
> > @@ -48,7 +48,7 @@ done
> > LD_LIBRARY_PATH=$SCRATCH_MNT $LDD_PROG $SCRATCH_MNT/xfs_scrub >> $seqres.full
> >
> > echo "Force online repairs"
> > -XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTvy $SCRATCH_MNT >> $seqres.full
> > +XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTv $SCRATCH_MNT >> $seqres.full
> >
> > # success, all done
> > status=0
> > --
> > 2.7.4
> >
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe fstests" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-07-05 5:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 1:37 [PATCH ] xfs/262: remove -y parameter Liu Yiding
2018-07-05 4:02 ` Darrick J. Wong
2018-07-05 5:49 ` Eryu Guan [this message]
2018-07-05 6:05 ` Lu Fengqi
2018-07-05 6:14 ` Lu Fengqi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705054945.GB2780@desktop \
--to=guaneryu@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=liuyd.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.