* [PATCH ] xfs/262: remove -y parameter
@ 2018-07-05 1:37 Liu Yiding
2018-07-05 4:02 ` Darrick J. Wong
0 siblings, 1 reply; 5+ messages in thread
From: Liu Yiding @ 2018-07-05 1:37 UTC (permalink / raw)
To: fstests; +Cc: Liu Yiding
Since commit 66f7b4c2ce14 ("xfs_scrub: remove -y parameter") has removed parameter -y, -y is an invalid option.
Signed-off-by: Liu Yiding <liuyd.fnst@cn.fujitsu.com>
---
tests/xfs/262 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/262 b/tests/xfs/262
index 6c39268..b109f93 100755
--- a/tests/xfs/262
+++ b/tests/xfs/262
@@ -48,7 +48,7 @@ done
LD_LIBRARY_PATH=$SCRATCH_MNT $LDD_PROG $SCRATCH_MNT/xfs_scrub >> $seqres.full
echo "Force online repairs"
-XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTvy $SCRATCH_MNT >> $seqres.full
+XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTv $SCRATCH_MNT >> $seqres.full
# success, all done
status=0
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH ] xfs/262: remove -y parameter
2018-07-05 1:37 [PATCH ] xfs/262: remove -y parameter Liu Yiding
@ 2018-07-05 4:02 ` Darrick J. Wong
2018-07-05 5:49 ` Eryu Guan
0 siblings, 1 reply; 5+ messages in thread
From: Darrick J. Wong @ 2018-07-05 4:02 UTC (permalink / raw)
To: Liu Yiding; +Cc: fstests
On Thu, Jul 05, 2018 at 09:37:03AM +0800, Liu Yiding wrote:
> Since commit 66f7b4c2ce14 ("xfs_scrub: remove -y parameter") has removed parameter -y, -y is an invalid option.
>
> Signed-off-by: Liu Yiding <liuyd.fnst@cn.fujitsu.com>
Good catch!
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/xfs/262 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/262 b/tests/xfs/262
> index 6c39268..b109f93 100755
> --- a/tests/xfs/262
> +++ b/tests/xfs/262
> @@ -48,7 +48,7 @@ done
> LD_LIBRARY_PATH=$SCRATCH_MNT $LDD_PROG $SCRATCH_MNT/xfs_scrub >> $seqres.full
>
> echo "Force online repairs"
> -XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTvy $SCRATCH_MNT >> $seqres.full
> +XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTv $SCRATCH_MNT >> $seqres.full
>
> # success, all done
> status=0
> --
> 2.7.4
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH ] xfs/262: remove -y parameter
2018-07-05 4:02 ` Darrick J. Wong
@ 2018-07-05 5:49 ` Eryu Guan
2018-07-05 6:05 ` Lu Fengqi
0 siblings, 1 reply; 5+ messages in thread
From: Eryu Guan @ 2018-07-05 5:49 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Liu Yiding, fstests
On Wed, Jul 04, 2018 at 09:02:12PM -0700, Darrick J. Wong wrote:
> On Thu, Jul 05, 2018 at 09:37:03AM +0800, Liu Yiding wrote:
> > Since commit 66f7b4c2ce14 ("xfs_scrub: remove -y parameter") has removed parameter -y, -y is an invalid option.
But I couldn't find this commit in xfsprogs repo
git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
Is it already upstream?
> >
> > Signed-off-by: Liu Yiding <liuyd.fnst@cn.fujitsu.com>
>
> Good catch!
>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Thanks for the review!
Eryu
>
> --D
>
> > ---
> > tests/xfs/262 | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/xfs/262 b/tests/xfs/262
> > index 6c39268..b109f93 100755
> > --- a/tests/xfs/262
> > +++ b/tests/xfs/262
> > @@ -48,7 +48,7 @@ done
> > LD_LIBRARY_PATH=$SCRATCH_MNT $LDD_PROG $SCRATCH_MNT/xfs_scrub >> $seqres.full
> >
> > echo "Force online repairs"
> > -XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTvy $SCRATCH_MNT >> $seqres.full
> > +XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTv $SCRATCH_MNT >> $seqres.full
> >
> > # success, all done
> > status=0
> > --
> > 2.7.4
> >
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe fstests" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH ] xfs/262: remove -y parameter
2018-07-05 5:49 ` Eryu Guan
@ 2018-07-05 6:05 ` Lu Fengqi
2018-07-05 6:14 ` Lu Fengqi
0 siblings, 1 reply; 5+ messages in thread
From: Lu Fengqi @ 2018-07-05 6:05 UTC (permalink / raw)
To: Eryu Guan; +Cc: darrick.wong, liuyd.fnst, fstests
Eryu Guan <guaneryu@gmail.com> 于2018年7月5日周四 下午1:50写道：
>
> On Wed, Jul 04, 2018 at 09:02:12PM -0700, Darrick J. Wong wrote:
> > On Thu, Jul 05, 2018 at 09:37:03AM +0800, Liu Yiding wrote:
> > > Since commit 66f7b4c2ce14 ("xfs_scrub: remove -y parameter") has removed parameter -y, -y is an invalid option.
>
> But I couldn't find this commit in xfsprogs repo
> git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
>
> Is it already upstream?
This commit seems in xfstest-dev.
-------------------------------------------------------------
Thanks,
Lu
>
> > >
> > > Signed-off-by: Liu Yiding <liuyd.fnst@cn.fujitsu.com>
> >
> > Good catch!
> >
> > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> Thanks for the review!
>
> Eryu
>
> >
> > --D
> >
> > > ---
> > > tests/xfs/262 | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tests/xfs/262 b/tests/xfs/262
> > > index 6c39268..b109f93 100755
> > > --- a/tests/xfs/262
> > > +++ b/tests/xfs/262
> > > @@ -48,7 +48,7 @@ done
> > > LD_LIBRARY_PATH=$SCRATCH_MNT $LDD_PROG $SCRATCH_MNT/xfs_scrub >> $seqres.full
> > >
> > > echo "Force online repairs"
> > > -XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTvy $SCRATCH_MNT >> $seqres.full
> > > +XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTv $SCRATCH_MNT >> $seqres.full
> > >
> > > # success, all done
> > > status=0
> > > --
> > > 2.7.4
> > >
> > >
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe fstests" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > --
> > To unsubscribe from this list: send the line "unsubscribe fstests" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH ] xfs/262: remove -y parameter
2018-07-05 6:05 ` Lu Fengqi
@ 2018-07-05 6:14 ` Lu Fengqi
0 siblings, 0 replies; 5+ messages in thread
From: Lu Fengqi @ 2018-07-05 6:14 UTC (permalink / raw)
To: Eryu Guan; +Cc: darrick.wong, liuyd.fnst, fstests
Lu Fengqi <curiouslfq@gmail.com> 于2018年7月5日周四 下午2:05写道：
>
> Eryu Guan <guaneryu@gmail.com> 于2018年7月5日周四 下午1:50写道：
> >
> > On Wed, Jul 04, 2018 at 09:02:12PM -0700, Darrick J. Wong wrote:
> > > On Thu, Jul 05, 2018 at 09:37:03AM +0800, Liu Yiding wrote:
> > > > Since commit 66f7b4c2ce14 ("xfs_scrub: remove -y parameter") has removed parameter -y, -y is an invalid option.
> >
> > But I couldn't find this commit in xfsprogs repo
> > git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
> >
> > Is it already upstream?
>
> This commit seems in xfstest-dev.
>
BTW, removing -y option from xfs_scrub is commit 1658224d2b5d
("xfs_scrub: remove preen mode").
-------------------------------------------------------------
Thanks,
Lu
> -------------------------------------------------------------
> Thanks,
> Lu
>
> >
> > > >
> > > > Signed-off-by: Liu Yiding <liuyd.fnst@cn.fujitsu.com>
> > >
> > > Good catch!
> > >
> > > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Thanks for the review!
> >
> > Eryu
> >
> > >
> > > --D
> > >
> > > > ---
> > > > tests/xfs/262 | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/tests/xfs/262 b/tests/xfs/262
> > > > index 6c39268..b109f93 100755
> > > > --- a/tests/xfs/262
> > > > +++ b/tests/xfs/262
> > > > @@ -48,7 +48,7 @@ done
> > > > LD_LIBRARY_PATH=$SCRATCH_MNT $LDD_PROG $SCRATCH_MNT/xfs_scrub >> $seqres.full
> > > >
> > > > echo "Force online repairs"
> > > > -XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTvy $SCRATCH_MNT >> $seqres.full
> > > > +XFS_SCRUB_FORCE_REPAIR=1 LD_LIBRARY_PATH=$SCRATCH_MNT $SCRATCH_MNT/xfs_scrub -dTv $SCRATCH_MNT >> $seqres.full
> > > >
> > > > # success, all done
> > > > status=0
> > > > --
> > > > 2.7.4
> > > >
> > > >
> > > >
> > > > --
> > > > To unsubscribe from this list: send the line "unsubscribe fstests" in
> > > > the body of a message to majordomo@vger.kernel.org
> > > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe fstests" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > --
> > To unsubscribe from this list: send the line "unsubscribe fstests" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-05 6:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-05 1:37 [PATCH ] xfs/262: remove -y parameter Liu Yiding
2018-07-05 4:02 ` Darrick J. Wong
2018-07-05 5:49 ` Eryu Guan
2018-07-05 6:05 ` Lu Fengqi
2018-07-05 6:14 ` Lu Fengqi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.