All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, imammedo@redhat.com, eblake@redhat.com,
	pkrempa@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] Let's not chisel --preconfig in stone without a user
Date: Thu, 5 Jul 2018 13:41:44 -0300	[thread overview]
Message-ID: <20180705164144.GP7451@localhost.localdomain> (raw)
In-Reply-To: <20180705091402.26244-1-armbru@redhat.com>

On Thu, Jul 05, 2018 at 11:14:00AM +0200, Markus Armbruster wrote:
> Please refer to PATCH 1 for rationale.

Justification is good.  We're far from having machine
initialization code (i.e. everything between the two main_loop()
calls) safe to run with an active QMP monitor.

Acked-by: Eduardo Habkost <ehabkost@redhat.com>

> 
> Markus Armbruster (2):
>   qapi: Do not expose "allow-preconfig" in query-qmp-schema
>   cli qmp: Mark --preconfig, exit-preconfig experimental
> 
>  hmp.c                      |  2 +-
>  qapi/introspect.json       |  5 +----
>  qapi/misc.json             |  6 +++---
>  qemu-options.hx            |  9 +++++----
>  qemu-tech.texi             | 11 ++++-------
>  qmp.c                      |  2 +-
>  scripts/qapi/introspect.py |  3 +--
>  tests/numa-test.c          |  2 +-
>  tests/qmp-test.c           |  6 +++---
>  9 files changed, 20 insertions(+), 26 deletions(-)
> 
> -- 
> 2.17.1
> 

-- 
Eduardo

  parent reply	other threads:[~2018-07-05 16:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05  9:14 [Qemu-devel] [PATCH 0/2] Let's not chisel --preconfig in stone without a user Markus Armbruster
2018-07-05  9:14 ` [Qemu-devel] [PATCH 1/2] qapi: Do not expose "allow-preconfig" in query-qmp-schema Markus Armbruster
2018-07-05 16:36   ` Eric Blake
2018-07-05  9:14 ` [Qemu-devel] [PATCH 2/2] cli qmp: Mark --preconfig, exit-preconfig experimental Markus Armbruster
2018-07-05 16:39   ` Eric Blake
2018-07-06  6:31     ` Markus Armbruster
2018-07-05 17:04   ` Eric Blake
2018-07-05 16:41 ` Eduardo Habkost [this message]
2018-07-09 15:57 ` [Qemu-devel] [PATCH 0/2] Let's not chisel --preconfig in stone without a user Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705164144.GP7451@localhost.localdomain \
    --to=ehabkost@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.