All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org, imammedo@redhat.com, pkrempa@redhat.com,
	ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] cli qmp: Mark --preconfig, exit-preconfig experimental
Date: Fri, 06 Jul 2018 08:31:02 +0200	[thread overview]
Message-ID: <87r2kg3mft.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <d8ff142e-34f8-65c8-fa3e-2509a85fa06e@redhat.com> (Eric Blake's message of "Thu, 5 Jul 2018 11:39:02 -0500")

Eric Blake <eblake@redhat.com> writes:

> On 07/05/2018 04:14 AM, Markus Armbruster wrote:
>> Committing to the current --preconfig / exit-preconfig interface
>> before it has seen any use is premature.  Mark both as experimental,
>> the former in documentation, the latter by renaming it to
>> x-exit-preconfig.
>>
>> See the previous commit for more detailed rationale.
>
> Should the CLI be spelled --x-preconfig?

Would be the first use of x- with option names.

Since you have to pair --preconfig with x-exit-preconfig, I figure
slapping x- onto the latter suffices.  But I'm not opposed to slapping
it onto the former as well.

>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>
> Other than the potential for a spelling change,
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks!

  reply	other threads:[~2018-07-06  6:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05  9:14 [Qemu-devel] [PATCH 0/2] Let's not chisel --preconfig in stone without a user Markus Armbruster
2018-07-05  9:14 ` [Qemu-devel] [PATCH 1/2] qapi: Do not expose "allow-preconfig" in query-qmp-schema Markus Armbruster
2018-07-05 16:36   ` Eric Blake
2018-07-05  9:14 ` [Qemu-devel] [PATCH 2/2] cli qmp: Mark --preconfig, exit-preconfig experimental Markus Armbruster
2018-07-05 16:39   ` Eric Blake
2018-07-06  6:31     ` Markus Armbruster [this message]
2018-07-05 17:04   ` Eric Blake
2018-07-05 16:41 ` [Qemu-devel] [PATCH 0/2] Let's not chisel --preconfig in stone without a user Eduardo Habkost
2018-07-09 15:57 ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2kg3mft.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.