From: Adrian Pop <apop@bitdefender.com>
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <jbeulich@suse.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 1/2] x86/mem_access: Add a helper function for memaccess conversion
Date: Fri, 6 Jul 2018 00:07:12 +0300 [thread overview]
Message-ID: <20180705210711.GA5520@hel> (raw)
In-Reply-To: <CABfawhkgELLq-zJyGNJBMc_BF5kmA0HU5QthjT8LuF9Wx57qXQ@mail.gmail.com>
On Thu, Jul 05, 2018 at 10:53:22AM -0600, Tamas K Lengyel wrote:
> On Thu, Jul 5, 2018 at 4:44 AM Adrian Pop <apop@bitdefender.com> wrote:
> > @@ -72,11 +83,7 @@ static int _p2m_get_mem_access(struct p2m_domain *p2m, gfn_t gfn,
> > if ( mfn_eq(mfn, INVALID_MFN) )
> > return -ESRCH;
> >
> > - if ( (unsigned int)a >= ARRAY_SIZE(memaccess) )
> > - return -ERANGE;
> > -
> > - *access = memaccess[a];
> > - return 0;
> > + return access_to_xenmem_access(p2m, a, access);
>
> Shouldn't this be p2m_access_to_xenmem_access? Did you compile check
> this patch before sending?
Oh, that's right! It seems I've mistakenly used an intermediary version
of the patch when testing unfortunately.
Thank you!
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-07-05 21:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 10:44 [PATCH v2 0/2] Add an altp2m subop for obtaining the page mem access Adrian Pop
2018-07-05 10:44 ` [PATCH v2 1/2] x86/mem_access: Add a helper function for memaccess conversion Adrian Pop
2018-07-05 16:53 ` Tamas K Lengyel
2018-07-05 21:07 ` Adrian Pop [this message]
2018-07-05 10:44 ` [PATCH v2 2/2] x86/altp2m: Add a subop for obtaining the memaccess of a page Adrian Pop
2018-07-09 8:35 ` Jan Beulich
2018-07-09 8:44 ` Razvan Cojocaru
2018-07-18 9:24 ` Adrian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705210711.GA5520@hel \
--to=apop@bitdefender.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=rcojocaru@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.