From: Adrian Pop <apop@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
tamas@tklengyel.com, xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 2/2] x86/altp2m: Add a subop for obtaining the memaccess of a page
Date: Wed, 18 Jul 2018 12:24:50 +0300 [thread overview]
Message-ID: <20180718092450.GA7520@hel> (raw)
In-Reply-To: <5B431E5202000078001D2313@prv1-mh.provo.novell.com>
On Mon, Jul 09, 2018 at 02:35:30AM -0600, Jan Beulich wrote:
> >>> On 05.07.18 at 12:44, <apop@bitdefender.com> wrote:
> > Both altp2m get/set memaccess functions use the struct
> > xen_hvm_altp2m_mem_access which has now dropped the `set' part and has
> > been renamed from xen_hvm_altp2m_set_mem_access.
> >
> > Signed-off-by: Adrian Pop <apop@bitdefender.com>
>
> Looking through this patch - what's the point of patch 1? There's no
> further user being introduced here.
It's not entirely necessary. It just cleans up _p2m_get_mem_access()
slightly, which would be the only user of the new function. I could
drop patch 1 and if it's deemed desirable I could send it separately.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-07-18 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 10:44 [PATCH v2 0/2] Add an altp2m subop for obtaining the page mem access Adrian Pop
2018-07-05 10:44 ` [PATCH v2 1/2] x86/mem_access: Add a helper function for memaccess conversion Adrian Pop
2018-07-05 16:53 ` Tamas K Lengyel
2018-07-05 21:07 ` Adrian Pop
2018-07-05 10:44 ` [PATCH v2 2/2] x86/altp2m: Add a subop for obtaining the memaccess of a page Adrian Pop
2018-07-09 8:35 ` Jan Beulich
2018-07-09 8:44 ` Razvan Cojocaru
2018-07-18 9:24 ` Adrian Pop [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718092450.GA7520@hel \
--to=apop@bitdefender.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=rcojocaru@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.