From: hch@infradead.org (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [PATCH v2 3/7] riscv: Include asm-generic/compat.h
Date: Thu, 5 Jul 2018 15:21:10 -0700 [thread overview]
Message-ID: <20180705222110.GA5698@infradead.org> (raw)
In-Reply-To: <20180705213604.18883-4-deepa.kernel@gmail.com>
On Thu, Jul 05, 2018 at 02:36:00PM -0700, Deepa Dinamani wrote:
> defconfig, allmodconfig and nomodconfig.
> And hence does not inlude definitions for compat data types.
>
> Now that time syscalls are being reused in non CONFIG_COMPAT
> modes, include asm-generic definitions for riscv.
>
> Alternative would be to make compat_time.h to be conditional on
> CONFIG_COMPAT_32BIT_TIME. But, since riscv is already has an
> asm/compat.h include the generic version instead.
Two comments here:
First I think the current riscv compat.h is completely bogus.
As you mentioned riscv does not actually have a compat mode, so
having a compat.h makes no sensse at all, and the COMPAT_UTS_MACHINE
override which is the only thing implemented is included in that
statement.
Second I think abusing compat.h for old syscall compatibility of any
form is a really bad idea. I think you need to split that part out,
and preferably not using compat in the name, but something like
old-time.h or time32.h for the name.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
y2038@lists.linaro.org, linux-riscv@lists.infradead.org,
palmer@sifive.com, arnd@arndb.de
Subject: Re: [PATCH v2 3/7] riscv: Include asm-generic/compat.h
Date: Thu, 5 Jul 2018 15:21:10 -0700 [thread overview]
Message-ID: <20180705222110.GA5698@infradead.org> (raw)
In-Reply-To: <20180705213604.18883-4-deepa.kernel@gmail.com>
On Thu, Jul 05, 2018 at 02:36:00PM -0700, Deepa Dinamani wrote:
> defconfig, allmodconfig and nomodconfig.
> And hence does not inlude definitions for compat data types.
>
> Now that time syscalls are being reused in non CONFIG_COMPAT
> modes, include asm-generic definitions for riscv.
>
> Alternative would be to make compat_time.h to be conditional on
> CONFIG_COMPAT_32BIT_TIME. But, since riscv is already has an
> asm/compat.h include the generic version instead.
Two comments here:
First I think the current riscv compat.h is completely bogus.
As you mentioned riscv does not actually have a compat mode, so
having a compat.h makes no sensse at all, and the COMPAT_UTS_MACHINE
override which is the only thing implemented is included in that
statement.
Second I think abusing compat.h for old syscall compatibility of any
form is a really bad idea. I think you need to split that part out,
and preferably not using compat in the name, but something like
old-time.h or time32.h for the name.
next prev parent reply other threads:[~2018-07-05 22:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 21:35 [PATCH v2 0/7] Introduce struct __kernel_timex Deepa Dinamani
2018-07-05 21:35 ` Deepa Dinamani
2018-07-05 21:35 ` [PATCH v2 1/7] arm64: Make basic compat_* types always available Deepa Dinamani
2018-07-05 21:35 ` [PATCH v2 2/7] sparc: Make thread_info.h available directly Deepa Dinamani
2018-07-05 21:36 ` [PATCH v2 3/7] riscv: Include asm-generic/compat.h Deepa Dinamani
2018-07-05 21:36 ` Deepa Dinamani
2018-07-05 22:21 ` Christoph Hellwig [this message]
2018-07-05 22:21 ` Christoph Hellwig
2018-07-05 23:56 ` Deepa Dinamani
2018-07-05 23:56 ` Deepa Dinamani
2018-07-06 11:42 ` Arnd Bergmann
2018-07-06 11:42 ` Arnd Bergmann
2018-07-07 4:23 ` Deepa Dinamani
2018-07-07 4:23 ` Deepa Dinamani
2018-07-12 8:32 ` Christoph Hellwig
2018-07-12 8:32 ` Christoph Hellwig
2018-07-12 12:31 ` Arnd Bergmann
2018-07-12 12:31 ` Arnd Bergmann
2018-07-12 12:42 ` Geert Uytterhoeven
2018-07-12 12:42 ` Geert Uytterhoeven
2018-07-12 13:51 ` Arnd Bergmann
2018-07-12 13:51 ` Arnd Bergmann
2018-07-05 21:36 ` [PATCH v2 4/7] timex: prepare compat helpers for y2038 changes Deepa Dinamani
2018-07-05 21:36 ` [PATCH v2 5/7] time: Add struct __kernel_timex Deepa Dinamani
2018-07-05 21:36 ` [PATCH v2 6/7] timex: use __kernel_timex internally Deepa Dinamani
2018-07-05 21:36 ` [PATCH v2 7/7] timex: change syscalls to use struct __kernel_timex Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705222110.GA5698@infradead.org \
--to=hch@infradead.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.