From: Philip Li <philip.li@intel.com>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
kernel test robot <fengguang.wu@intel.com>,
linux-arch <linux-arch@vger.kernel.org>,
kbuild test robot <lkp@intel.com>, Arnd Bergmann <arnd@arndb.de>,
y2038 Mailman List <y2038@lists.linaro.org>,
palmer@sifive.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kbuild-all@01.org, linux-riscv@lists.infradead.org
Subject: Re: [kbuild-all] [PATCH 3/6] timex: prepare compat helpers for y2038 changes
Date: Fri, 6 Jul 2018 08:41:33 +0800 [thread overview]
Message-ID: <20180706004133.GA24731@intel.com> (raw)
In-Reply-To: <CABeXuvpa6GtEOEn5HbYPnAVqqweTXLBH0KUXssGpFBzUNeayZA@mail.gmail.com>
On Thu, Jul 05, 2018 at 02:45:05PM -0700, Deepa Dinamani wrote:
> Posted v2 now.
>
> Fengguang,
>
> Also the make.cross script pointed to by the kernel test bot is broken
> for riscv.
>
> I applied the following fix to compile it.
>
> Pull request: https://github.com/intel/lkp-tests/pull/11
thanks Deepa, i will follow up with the pull request to merge it.
>
> Thanks,
> Deepa
>
> On Thu, Jul 5, 2018 at 1:33 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Thu, 5 Jul 2018, Deepa Dinamani wrote:
> >
> >> The error is fixed with the following patch that goes in before patch
> >> 3/6 above in the series.
> >> Let me know if I should post a v2 instead.
> >>
> >> Thanks,
> >> Deepa
> >>
> >>
> >> commit bfe4b046ed7f01154aef44fcb77d3f172929ccc2
> >> Author: Deepa Dinamani <deepa.kernel@gmail.com>
> >> Date: Thu Jul 5 11:47:25 2018 -0700
> >>
> >> riscv: Include asm-generic/compat.h
> >>
> >> riscv does not enable CONFIG_COMPAT in default configurations:
> >> defconfig, allmodconfig and nomodconfig.
> >> And hence does not inlude definitions for compat data types.
> >>
> >> Now that time syscalls are being reused in non CONFIG_COMPAT
> >> modes, include asm-generic definitions for riscv.
> >>
> >> Alternative would be to make compat_time.h to be conditional on
> >> CONFIG_COMPAT_32BIT_TIME. But, since riscv is already has an
> >> asm/compat.h include the generic version instead.
> >>
> >> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> >> Cc: palmer@sifive.com
> >> Cc: linux-riscv@lists.infradead.org
> >
> > Post a real patch please instead of something which I have to cleanup
> > manually. A V2 of the series is probably the simplest way.
> >
> > Thanks,
> >
> > tglx
> _______________________________________________
> kbuild-all mailing list
> kbuild-all@lists.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all
WARNING: multiple messages have this Message-ID (diff)
From: philip.li@intel.com (Philip Li)
To: linux-riscv@lists.infradead.org
Subject: [kbuild-all] [PATCH 3/6] timex: prepare compat helpers for y2038 changes
Date: Fri, 6 Jul 2018 08:41:33 +0800 [thread overview]
Message-ID: <20180706004133.GA24731@intel.com> (raw)
In-Reply-To: <CABeXuvpa6GtEOEn5HbYPnAVqqweTXLBH0KUXssGpFBzUNeayZA@mail.gmail.com>
On Thu, Jul 05, 2018 at 02:45:05PM -0700, Deepa Dinamani wrote:
> Posted v2 now.
>
> Fengguang,
>
> Also the make.cross script pointed to by the kernel test bot is broken
> for riscv.
>
> I applied the following fix to compile it.
>
> Pull request: https://github.com/intel/lkp-tests/pull/11
thanks Deepa, i will follow up with the pull request to merge it.
>
> Thanks,
> Deepa
>
> On Thu, Jul 5, 2018 at 1:33 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Thu, 5 Jul 2018, Deepa Dinamani wrote:
> >
> >> The error is fixed with the following patch that goes in before patch
> >> 3/6 above in the series.
> >> Let me know if I should post a v2 instead.
> >>
> >> Thanks,
> >> Deepa
> >>
> >>
> >> commit bfe4b046ed7f01154aef44fcb77d3f172929ccc2
> >> Author: Deepa Dinamani <deepa.kernel@gmail.com>
> >> Date: Thu Jul 5 11:47:25 2018 -0700
> >>
> >> riscv: Include asm-generic/compat.h
> >>
> >> riscv does not enable CONFIG_COMPAT in default configurations:
> >> defconfig, allmodconfig and nomodconfig.
> >> And hence does not inlude definitions for compat data types.
> >>
> >> Now that time syscalls are being reused in non CONFIG_COMPAT
> >> modes, include asm-generic definitions for riscv.
> >>
> >> Alternative would be to make compat_time.h to be conditional on
> >> CONFIG_COMPAT_32BIT_TIME. But, since riscv is already has an
> >> asm/compat.h include the generic version instead.
> >>
> >> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> >> Cc: palmer at sifive.com
> >> Cc: linux-riscv at lists.infradead.org
> >
> > Post a real patch please instead of something which I have to cleanup
> > manually. A V2 of the series is probably the simplest way.
> >
> > Thanks,
> >
> > tglx
> _______________________________________________
> kbuild-all mailing list
> kbuild-all at lists.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all
next prev parent reply other threads:[~2018-07-06 0:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 5:44 [PATCH 0/6] Introduce struct __kernel_timex Deepa Dinamani
2018-07-03 5:44 ` Deepa Dinamani
2018-07-03 5:44 ` [PATCH 1/6] arm64: Make basic compat_* types always available Deepa Dinamani
2018-07-03 5:44 ` [PATCH 2/6] sparc: Make thread_info.h available directly Deepa Dinamani
2018-07-03 9:16 ` David Miller
2018-07-03 5:44 ` [PATCH 3/6] timex: prepare compat helpers for y2038 changes Deepa Dinamani
2018-07-05 7:06 ` kbuild test robot
2018-07-05 20:06 ` Deepa Dinamani
2018-07-05 20:06 ` Deepa Dinamani
2018-07-05 20:33 ` Thomas Gleixner
2018-07-05 20:33 ` Thomas Gleixner
2018-07-05 20:33 ` Thomas Gleixner
2018-07-05 21:45 ` Deepa Dinamani
2018-07-05 21:45 ` Deepa Dinamani
2018-07-06 0:41 ` Philip Li [this message]
2018-07-06 0:41 ` [kbuild-all] " Philip Li
2018-07-03 5:44 ` [PATCH 4/6] time: Add struct __kernel_timex Deepa Dinamani
2018-07-03 5:44 ` [PATCH 5/6] timex: use __kernel_timex internally Deepa Dinamani
2018-07-03 5:44 ` [PATCH 6/6] timex: change syscalls to use struct __kernel_timex Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706004133.GA24731@intel.com \
--to=philip.li@intel.com \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=palmer@sifive.com \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.