All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: "Hook, Gary" <ghook-5C7GfCeVMHo@public.gmane.org>,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	Colin Ian King
	<colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
	Walter Harms <wharms-fPG8STNUNVg@public.gmane.org>
Subject: Re: [PATCH] iommu/amd: fix missing tag from dev_err message
Date: Fri, 06 Jul 2018 13:00:24 +0000	[thread overview]
Message-ID: <20180706130024.GD13903@8bytes.org> (raw)
In-Reply-To: <cb5702b95b8d4914612526125f625c4bc2cedfcc.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>

On Tue, Jul 03, 2018 at 10:34:12AM -0700, Joe Perches wrote:
> On Tue, 2018-07-03 at 18:57 +0200, Walter Harms wrote:
> > It is only cosmetics but even the author got lost about the loose bracket.
> > I would suggest to remove all the brackets or if needed to move the [ in the
> > message. We have enought memory this days.
> 
> My suggestion would be to remove the separate dev_err
> and use "Event log [" in each dev_err.
> 
> So here's an actual suggested patch that does a few things:
> 
> o Coalesce formats and realigns arguments
> o Uses pr_fmt and dev_fmt to prefix "AMD-Vi: " to all messages
> o Remove embedded "AMD-Vi: " from various formats

Nice cleanup! But I got lost a bit in the patches floating around in
this thread and their dependencies. Can someone sort it out and send it
a new patch-set to me?


Thanks,

	Joerg


WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: "Hook, Gary" <ghook-5C7GfCeVMHo@public.gmane.org>,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	Colin Ian King
	<colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
	Walter Harms <wharms-fPG8STNUNVg@public.gmane.org>
Subject: Re: [PATCH] iommu/amd: fix missing tag from dev_err message
Date: Fri, 6 Jul 2018 15:00:24 +0200	[thread overview]
Message-ID: <20180706130024.GD13903@8bytes.org> (raw)
In-Reply-To: <cb5702b95b8d4914612526125f625c4bc2cedfcc.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>

On Tue, Jul 03, 2018 at 10:34:12AM -0700, Joe Perches wrote:
> On Tue, 2018-07-03 at 18:57 +0200, Walter Harms wrote:
> > It is only cosmetics but even the author got lost about the loose bracket.
> > I would suggest to remove all the brackets or if needed to move the [ in the
> > message. We have enought memory this days.
> 
> My suggestion would be to remove the separate dev_err
> and use "Event log [" in each dev_err.
> 
> So here's an actual suggested patch that does a few things:
> 
> o Coalesce formats and realigns arguments
> o Uses pr_fmt and dev_fmt to prefix "AMD-Vi: " to all messages
> o Remove embedded "AMD-Vi: " from various formats

Nice cleanup! But I got lost a bit in the patches floating around in
this thread and their dependencies. Can someone sort it out and send it
a new patch-set to me?


Thanks,

	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Joe Perches <joe@perches.com>
Cc: Walter Harms <wharms@bfs.de>, "Hook, Gary" <ghook@amd.com>,
	Colin Ian King <colin.king@canonical.com>,
	iommu@lists.linux-foundation.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: fix missing tag from dev_err message
Date: Fri, 6 Jul 2018 15:00:24 +0200	[thread overview]
Message-ID: <20180706130024.GD13903@8bytes.org> (raw)
In-Reply-To: <cb5702b95b8d4914612526125f625c4bc2cedfcc.camel@perches.com>

On Tue, Jul 03, 2018 at 10:34:12AM -0700, Joe Perches wrote:
> On Tue, 2018-07-03 at 18:57 +0200, Walter Harms wrote:
> > It is only cosmetics but even the author got lost about the loose bracket.
> > I would suggest to remove all the brackets or if needed to move the [ in the
> > message. We have enought memory this days.
> 
> My suggestion would be to remove the separate dev_err
> and use "Event log [" in each dev_err.
> 
> So here's an actual suggested patch that does a few things:
> 
> o Coalesce formats and realigns arguments
> o Uses pr_fmt and dev_fmt to prefix "AMD-Vi: " to all messages
> o Remove embedded "AMD-Vi: " from various formats

Nice cleanup! But I got lost a bit in the patches floating around in
this thread and their dependencies. Can someone sort it out and send it
a new patch-set to me?


Thanks,

	Joerg


  parent reply	other threads:[~2018-07-06 13:00 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03  6:40 [PATCH] iommu/amd: fix missing tag from dev_err message Colin King
2018-07-03  6:40 ` Colin King
     [not found] ` <20180703064005.18908-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2018-07-03 10:07   ` Joe Perches
2018-07-03 10:07     ` Joe Perches
2018-07-03 10:07     ` Joe Perches
2018-07-03 12:56     ` Gary R Hook
2018-07-03 12:56       ` Gary R Hook
2018-07-03 15:55       ` Joe Perches
2018-07-03 15:55         ` Joe Perches
     [not found]         ` <d93bfa0f52d8907019b16336645986cd339ebf75.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2018-07-03 16:21           ` Hook, Gary
2018-07-03 16:21             ` Hook, Gary
2018-07-03 16:21             ` Hook, Gary
     [not found]             ` <f3e15437-68c1-58eb-bc34-93fa70e50dc9-5C7GfCeVMHo@public.gmane.org>
2018-07-03 16:24               ` Colin Ian King
2018-07-03 16:24                 ` Colin Ian King
2018-07-03 16:24                 ` Colin Ian King
     [not found]                 ` <6fbcf273-bc0a-5dbd-fa0e-a7f656c4ccbc-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2018-07-03 16:27                   ` Hook, Gary
2018-07-03 16:27                     ` Hook, Gary
2018-07-03 16:27                     ` Hook, Gary
2018-07-03 16:38                     ` Joe Perches
2018-07-03 16:38                       ` Joe Perches
2018-07-03 16:38                       ` Joe Perches
2018-07-03 12:54   ` Gary R Hook
2018-07-03 12:54     ` Gary R Hook
2018-07-03 12:54     ` Gary R Hook
2018-07-03 16:57 ` Walter Harms
2018-07-03 16:57   ` Walter Harms
2018-07-03 17:34   ` Joe Perches
2018-07-03 17:34     ` Joe Perches
     [not found]     ` <cb5702b95b8d4914612526125f625c4bc2cedfcc.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2018-07-06 13:00       ` Joerg Roedel [this message]
2018-07-06 13:00         ` Joerg Roedel
2018-07-06 13:00         ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180706130024.GD13903@8bytes.org \
    --to=joro@8bytes.org \
    --cc=colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
    --cc=ghook-5C7GfCeVMHo@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
    --cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wharms-fPG8STNUNVg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.