From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: David Lechner <david@lechnology.com>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>,
gregkh@linuxfoundation.org, jic23@kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
fabrice.gasnier@st.com, benjamin.gaignard@st.com,
robh+dt@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, mark.rutland@arm.com
Subject: Re: [PATCH v7 00/10] Introduce the Counter subsystem
Date: Fri, 6 Jul 2018 15:20:13 -0400 [thread overview]
Message-ID: <20180706192013.GA6810@sophia> (raw)
In-Reply-To: <59b0950e-ef39-4ad4-a32b-316992e1f236@lechnology.com>
On Fri, Jul 06, 2018 at 01:22:57PM -0500, David Lechner wrote:
>On 07/06/2018 12:21 PM, Jonathan Cameron wrote:
>> On Mon, 2 Jul 2018 22:48:35 -0400
>> William Breathitt Gray <vilhelm.gray@gmail.com> wrote:
>>> Is frequency useful for other
>>> applications on its own (perhaps velocity of an automobile device
>>> equipped with an encoder wheel for some reason or other)?
>
>Since we are just dealing with counters here, I think we should call
>it "rate" instead of "frequency". At least that seems to be the common
>name in industrial automation.
>
>Another possible use case for "rate" would be flow meters. Some
>flow meters generate a pulse every X gallons. Assuming that the
>counter also has a rate output, then you can scale the rate (e.g.
>counts/second) into flow in gallons per minute.
>
>>>
>>> Once we figure out how this data is used, we can determine the best
>>> design and place to introduce it into the Generic Counter interface,
>>> then move on to integration from there.
>>
>> Great - as long as this fits reasonably well in ABI wise (whatever the
>> details) sounds like we don't need to solve it today. I'm anxious not
>> to delay merging this counter subsystem for another cycle.
>
>Certainly don't delay things on account of me. I'm just trying to get
>a feel for where things are headed since I missed the earlier discussions.
>I don't see any major problems with the current state of things.
>
>Once this lands, I may have a go at the eQEP and see how it looks.
No worries, it looks like your application would be served well by the
Generic Counter interface, and exposing a "rate" value would be a simple
feature to add. However, since this patchset has been stabilizing over
the past few revisions, I want to postpone the addition of new features
until this interface and its current feature set is merged.
David, once this introduction patchset has been merged, submit to me a
patch adding the "rate" functionality feature and we'll continue
discussing it there.
William Breathitt Gray
WARNING: multiple messages have this Message-ID (diff)
From: vilhelm.gray@gmail.com (William Breathitt Gray)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 00/10] Introduce the Counter subsystem
Date: Fri, 6 Jul 2018 15:20:13 -0400 [thread overview]
Message-ID: <20180706192013.GA6810@sophia> (raw)
In-Reply-To: <59b0950e-ef39-4ad4-a32b-316992e1f236@lechnology.com>
On Fri, Jul 06, 2018 at 01:22:57PM -0500, David Lechner wrote:
>On 07/06/2018 12:21 PM, Jonathan Cameron wrote:
>> On Mon, 2 Jul 2018 22:48:35 -0400
>> William Breathitt Gray <vilhelm.gray@gmail.com> wrote:
>>> Is frequency useful for other
>>> applications on its own (perhaps velocity of an automobile device
>>> equipped with an encoder wheel for some reason or other)?
>
>Since we are just dealing with counters here, I think we should call
>it "rate" instead of "frequency". At least that seems to be the common
>name in industrial automation.
>
>Another possible use case for "rate" would be flow meters. Some
>flow meters generate a pulse every X gallons. Assuming that the
>counter also has a rate output, then you can scale the rate (e.g.
>counts/second) into flow in gallons per minute.
>
>>>
>>> Once we figure out how this data is used, we can determine the best
>>> design and place to introduce it into the Generic Counter interface,
>>> then move on to integration from there.
>>
>> Great - as long as this fits reasonably well in ABI wise (whatever the
>> details) sounds like we don't need to solve it today. I'm anxious not
>> to delay merging this counter subsystem for another cycle.
>
>Certainly don't delay things on account of me. I'm just trying to get
>a feel for where things are headed since I missed the earlier discussions.
>I don't see any major problems with the current state of things.
>
>Once this lands, I may have a go at the eQEP and see how it looks.
No worries, it looks like your application would be served well by the
Generic Counter interface, and exposing a "rate" value would be a simple
feature to add. However, since this patchset has been stabilizing over
the past few revisions, I want to postpone the addition of new features
until this interface and its current feature set is merged.
David, once this introduction patchset has been merged, submit to me a
patch adding the "rate" functionality feature and we'll continue
discussing it there.
William Breathitt Gray
next prev parent reply other threads:[~2018-07-06 19:20 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 21:06 [PATCH v7 00/10] Introduce the Counter subsystem William Breathitt Gray
2018-06-21 21:06 ` William Breathitt Gray
2018-06-21 21:07 ` [PATCH v7 01/10] counter: Introduce the Generic Counter interface William Breathitt Gray
2018-06-21 21:07 ` William Breathitt Gray
2018-07-07 15:16 ` Greg KH
2018-07-07 15:16 ` Greg KH
2018-07-07 15:16 ` Greg KH
2018-07-09 17:40 ` William Breathitt Gray
2018-07-09 17:40 ` William Breathitt Gray
2018-07-09 17:40 ` William Breathitt Gray
2018-07-09 18:54 ` Greg KH
2018-07-09 18:54 ` Greg KH
2018-07-09 18:56 ` William Breathitt Gray
2018-07-09 18:56 ` William Breathitt Gray
2018-07-18 3:49 ` Andrew Morton
2018-07-18 3:49 ` Andrew Morton
2018-07-21 16:26 ` William Breathitt Gray
2018-07-21 16:26 ` William Breathitt Gray
2018-07-22 5:41 ` Andrew Morton
2018-07-22 5:41 ` Andrew Morton
2018-06-21 21:07 ` [PATCH v7 02/10] counter: Documentation: Add Generic Counter sysfs documentation William Breathitt Gray
2018-06-21 21:07 ` William Breathitt Gray
2018-07-02 19:11 ` [v7, " David Lechner
2018-07-02 19:11 ` David Lechner
2018-07-03 14:04 ` William Breathitt Gray
2018-07-03 14:04 ` William Breathitt Gray
2018-06-21 21:07 ` [PATCH v7 03/10] docs: Add Generic Counter interface documentation William Breathitt Gray
2018-06-21 21:07 ` William Breathitt Gray
2018-06-22 16:51 ` Jonathan Cameron
2018-06-22 16:51 ` Jonathan Cameron
2018-06-22 16:51 ` Jonathan Cameron
2018-07-02 19:37 ` [v7,03/10] " David Lechner
2018-07-02 19:37 ` David Lechner
2018-07-03 14:16 ` William Breathitt Gray
2018-07-03 14:16 ` William Breathitt Gray
2018-07-04 17:23 ` Linus Walleij
2018-07-04 17:23 ` Linus Walleij
2018-07-06 17:15 ` Jonathan Cameron
2018-07-06 17:15 ` Jonathan Cameron
2018-07-06 17:15 ` Jonathan Cameron
2018-07-06 18:25 ` David Lechner
2018-07-06 18:25 ` David Lechner
2018-07-02 19:42 ` David Lechner
2018-07-02 19:42 ` David Lechner
2018-07-03 14:21 ` William Breathitt Gray
2018-07-03 14:21 ` William Breathitt Gray
2018-06-21 21:07 ` [PATCH v7 04/10] counter: 104-quad-8: Add Generic Counter interface support William Breathitt Gray
2018-06-21 21:07 ` William Breathitt Gray
2018-06-22 16:57 ` Jonathan Cameron
2018-06-22 16:57 ` Jonathan Cameron
2018-06-22 16:57 ` Jonathan Cameron
2018-06-21 21:08 ` [PATCH v7 05/10] counter: 104-quad-8: Documentation: Add Generic Counter sysfs documentation William Breathitt Gray
2018-06-21 21:08 ` William Breathitt Gray
2018-06-22 16:59 ` Jonathan Cameron
2018-06-22 16:59 ` Jonathan Cameron
2018-06-22 16:59 ` Jonathan Cameron
2018-06-21 21:08 ` [PATCH v7 06/10] counter: Add STM32 Timer quadrature encoder William Breathitt Gray
2018-06-21 21:08 ` William Breathitt Gray
2018-06-22 17:03 ` Jonathan Cameron
2018-06-22 17:03 ` Jonathan Cameron
2018-06-22 17:03 ` Jonathan Cameron
2018-06-21 21:08 ` [PATCH v7 07/10] dt-bindings: counter: Document stm32 " William Breathitt Gray
2018-06-21 21:08 ` William Breathitt Gray
2018-07-02 19:56 ` [v7,07/10] " David Lechner
2018-07-02 19:56 ` David Lechner
2018-07-05 21:13 ` [PATCH v7 07/10] " Rob Herring
2018-07-05 21:13 ` Rob Herring
2018-06-21 21:08 ` [PATCH v7 08/10] counter: stm32-lptimer: add counter device William Breathitt Gray
2018-06-21 21:08 ` William Breathitt Gray
2018-06-22 17:06 ` Jonathan Cameron
2018-06-22 17:06 ` Jonathan Cameron
2018-06-22 17:06 ` Jonathan Cameron
2018-06-21 21:08 ` [PATCH v7 09/10] dt-bindings: counter: Adjust dt-bindings for STM32 lptimer move William Breathitt Gray
2018-06-21 21:08 ` William Breathitt Gray
2018-07-05 21:13 ` Rob Herring
2018-07-05 21:13 ` Rob Herring
2018-06-21 21:09 ` [PATCH v7 10/10] iio: counter: Add deprecation markings for IIO Counter attributes William Breathitt Gray
2018-06-21 21:09 ` William Breathitt Gray
2018-06-22 17:10 ` [PATCH v7 00/10] Introduce the Counter subsystem Jonathan Cameron
2018-06-22 17:10 ` Jonathan Cameron
2018-06-22 17:10 ` Jonathan Cameron
2018-07-02 18:13 ` David Lechner
2018-07-02 18:13 ` David Lechner
2018-07-03 2:48 ` William Breathitt Gray
2018-07-03 2:48 ` William Breathitt Gray
2018-07-06 17:21 ` Jonathan Cameron
2018-07-06 17:21 ` Jonathan Cameron
2018-07-06 17:21 ` Jonathan Cameron
2018-07-06 18:22 ` David Lechner
2018-07-06 18:22 ` David Lechner
2018-07-06 19:20 ` William Breathitt Gray [this message]
2018-07-06 19:20 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706192013.GA6810@sophia \
--to=vilhelm.gray@gmail.com \
--cc=benjamin.gaignard@st.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.