From: Greg KH <greg@kroah.com>
To: "Алексей Бродкин" <alexey.brodkin@gmail.com>
Cc: linux-arch@vger.kernel.org,
Alexey Brodkin <abrodkin@synopsys.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-snps-arc@lists.infradead.org
Subject: Re: [PATCH v2] devres: Really align data field to unsigned long long
Date: Mon, 9 Jul 2018 06:18:05 +0200 [thread overview]
Message-ID: <20180709041805.GA5983@kroah.com> (raw)
In-Reply-To: <CAML3pwV8YMa0269fLH-+SNhOYCWdymqTE-XYMuRJktH-=UXH8g@mail.gmail.com>
On Sun, Jul 08, 2018 at 09:45:31PM +0300, Алексей Бродкин wrote:
> Hi Greg,
>
> вс, 8 июл. 2018 г. в 21:40, Greg KH <greg@kroah.com>:
> >
> > On Sun, Jul 08, 2018 at 08:56:21PM +0300, Alexey Brodkin wrote:
> > > Depending on ABI "long long" type of a particular 32-bit CPU
> > > might be aligned by either word (32-bits) or double word (64-bits).
> > > Make sure "data" is really 64-bit aligned for any 32-bit CPU.
> > >
> > > At least for 32-bit ARC cores ABI requires "long long" types
> > > to be aligned by normal 32-bit word. This makes "data" field aligned to
> > > 12 bytes. Which is still OK as long as we use 32-bit data only.
> > >
> > > But once we want to use native atomic64_t type (i.e. when we use special
> > > instructions LLOCKD/SCONDD for accessing 64-bit data) we easily hit
> > > misaligned access exception.
> > >
> > > That's because even on CPUs capable of non-aligned data access LL/SC
> > > instructions require strict alignment.
> > >
> > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > Cc: stable@vger.kernel.org
> > > ---
> > >
> > > Changes v1 -> v2:
> > >
> > > * Reworded commit message
> > > * Inserted comment right in source [Thomas]
> > >
> > > drivers/base/devres.c | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > Always use scripts/get_maintainer.pl to properly cc: the needed
> > developer/maintainer. As it is, this patch is going to get dropped on
> > the floor, sorry...
>
> Right I was way too relaxed dealing with very generic stuff which might get
> not that much of attention as more narrow topics or subsystems. But anyways
> get_maintainer.pl says you're the guy so do I need to do anything extra still or
> it's OK for this time?
Please resend it properly, it is not in my patch queue anywhere...
greg k-h
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: "Алексей Бродкин" <alexey.brodkin@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-arch@vger.kernel.org,
Alexey Brodkin <abrodkin@synopsys.com>,
Thomas Gleixner <tglx@linutronix.de>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] devres: Really align data field to unsigned long long
Date: Mon, 9 Jul 2018 06:18:05 +0200 [thread overview]
Message-ID: <20180709041805.GA5983@kroah.com> (raw)
Message-ID: <20180709041805.7DsHbzmw-QFHhTq1WFDMpwwAXzlObQwDNnngM_mFlTE@z> (raw)
In-Reply-To: <CAML3pwV8YMa0269fLH-+SNhOYCWdymqTE-XYMuRJktH-=UXH8g@mail.gmail.com>
On Sun, Jul 08, 2018 at 09:45:31PM +0300, Алексей Бродкин wrote:
> Hi Greg,
>
> вс, 8 июл. 2018 г. в 21:40, Greg KH <greg@kroah.com>:
> >
> > On Sun, Jul 08, 2018 at 08:56:21PM +0300, Alexey Brodkin wrote:
> > > Depending on ABI "long long" type of a particular 32-bit CPU
> > > might be aligned by either word (32-bits) or double word (64-bits).
> > > Make sure "data" is really 64-bit aligned for any 32-bit CPU.
> > >
> > > At least for 32-bit ARC cores ABI requires "long long" types
> > > to be aligned by normal 32-bit word. This makes "data" field aligned to
> > > 12 bytes. Which is still OK as long as we use 32-bit data only.
> > >
> > > But once we want to use native atomic64_t type (i.e. when we use special
> > > instructions LLOCKD/SCONDD for accessing 64-bit data) we easily hit
> > > misaligned access exception.
> > >
> > > That's because even on CPUs capable of non-aligned data access LL/SC
> > > instructions require strict alignment.
> > >
> > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > Cc: stable@vger.kernel.org
> > > ---
> > >
> > > Changes v1 -> v2:
> > >
> > > * Reworded commit message
> > > * Inserted comment right in source [Thomas]
> > >
> > > drivers/base/devres.c | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > Always use scripts/get_maintainer.pl to properly cc: the needed
> > developer/maintainer. As it is, this patch is going to get dropped on
> > the floor, sorry...
>
> Right I was way too relaxed dealing with very generic stuff which might get
> not that much of attention as more narrow topics or subsystems. But anyways
> get_maintainer.pl says you're the guy so do I need to do anything extra still or
> it's OK for this time?
Please resend it properly, it is not in my patch queue anywhere...
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: greg@kroah.com (Greg KH)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v2] devres: Really align data field to unsigned long long
Date: Mon, 9 Jul 2018 06:18:05 +0200 [thread overview]
Message-ID: <20180709041805.GA5983@kroah.com> (raw)
In-Reply-To: <CAML3pwV8YMa0269fLH-+SNhOYCWdymqTE-XYMuRJktH-=UXH8g@mail.gmail.com>
On Sun, Jul 08, 2018@09:45:31PM +0300, ??????? ??????? wrote:
> Hi Greg,
>
> ??, 8 ???. 2018 ?. ? 21:40, Greg KH <greg at kroah.com>:
> >
> > On Sun, Jul 08, 2018@08:56:21PM +0300, Alexey Brodkin wrote:
> > > Depending on ABI "long long" type of a particular 32-bit CPU
> > > might be aligned by either word (32-bits) or double word (64-bits).
> > > Make sure "data" is really 64-bit aligned for any 32-bit CPU.
> > >
> > > At least for 32-bit ARC cores ABI requires "long long" types
> > > to be aligned by normal 32-bit word. This makes "data" field aligned to
> > > 12 bytes. Which is still OK as long as we use 32-bit data only.
> > >
> > > But once we want to use native atomic64_t type (i.e. when we use special
> > > instructions LLOCKD/SCONDD for accessing 64-bit data) we easily hit
> > > misaligned access exception.
> > >
> > > That's because even on CPUs capable of non-aligned data access LL/SC
> > > instructions require strict alignment.
> > >
> > > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> > > Cc: Thomas Gleixner <tglx at linutronix.de>
> > > Cc: stable at vger.kernel.org
> > > ---
> > >
> > > Changes v1 -> v2:
> > >
> > > * Reworded commit message
> > > * Inserted comment right in source [Thomas]
> > >
> > > drivers/base/devres.c | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > Always use scripts/get_maintainer.pl to properly cc: the needed
> > developer/maintainer. As it is, this patch is going to get dropped on
> > the floor, sorry...
>
> Right I was way too relaxed dealing with very generic stuff which might get
> not that much of attention as more narrow topics or subsystems. But anyways
> get_maintainer.pl says you're the guy so do I need to do anything extra still or
> it's OK for this time?
Please resend it properly, it is not in my patch queue anywhere...
greg k-h
next prev parent reply other threads:[~2018-07-09 4:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-08 17:56 [PATCH v2] devres: Really align data field to unsigned long long Alexey Brodkin
2018-07-08 17:56 ` Alexey Brodkin
2018-07-08 18:40 ` Greg KH
2018-07-08 18:40 ` Greg KH
2018-07-08 18:45 ` Алексей Бродкин
2018-07-08 18:45 ` Алексей Бродкин
2018-07-09 4:18 ` Greg KH [this message]
2018-07-09 4:18 ` Greg KH
2018-07-09 4:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709041805.GA5983@kroah.com \
--to=greg@kroah.com \
--cc=abrodkin@synopsys.com \
--cc=alexey.brodkin@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.