All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH] drivers/misc: Aspeed LPC snoop output using misc chardev
Date: Mon, 9 Jul 2018 09:52:33 +0200	[thread overview]
Message-ID: <20180709075233.GF13479@kroah.com> (raw)
In-Reply-To: <20180706182531.137362-1-benjaminfair@google.com>

On Fri, Jul 06, 2018 at 11:25:32AM -0700, Benjamin Fair wrote:
> From: Robert Lippert <rlippert@google.com>
> 
> Provides the data bytes snooped over the LPC snoop bus to userspace
> as a (blocking) misc character device.

If this is a debugging thing, why not just use debugfs instead of a char
device?  That should make this code simpler overall, and you can do
whatever you want with debugfs.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Benjamin Fair <benjaminfair@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@aj.id.au>,
	openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org,
	Robert Lippert <rlippert@google.com>,
	Patrick Venture <venture@google.com>
Subject: Re: [PATCH] drivers/misc: Aspeed LPC snoop output using misc chardev
Date: Mon, 9 Jul 2018 09:52:33 +0200	[thread overview]
Message-ID: <20180709075233.GF13479@kroah.com> (raw)
In-Reply-To: <20180706182531.137362-1-benjaminfair@google.com>

On Fri, Jul 06, 2018 at 11:25:32AM -0700, Benjamin Fair wrote:
> From: Robert Lippert <rlippert@google.com>
> 
> Provides the data bytes snooped over the LPC snoop bus to userspace
> as a (blocking) misc character device.

If this is a debugging thing, why not just use debugfs instead of a char
device?  That should make this code simpler overall, and you can do
whatever you want with debugfs.

thanks,

greg k-h

  reply	other threads:[~2018-07-09  7:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 18:25 [PATCH] drivers/misc: Aspeed LPC snoop output using misc chardev Benjamin Fair
2018-07-06 18:25 ` Benjamin Fair
2018-07-09  7:52 ` Greg Kroah-Hartman [this message]
2018-07-09  7:52   ` Greg Kroah-Hartman
2018-07-10 18:11   ` Benjamin Fair
2018-07-10 18:11     ` Benjamin Fair

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180709075233.GF13479@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.