From: Peter Zijlstra <peterz@infradead.org>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: linux-arch@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
David Laight <David.Laight@ACULAB.COM>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Greg KH <greg@kroah.com>, Thomas Gleixner <tglx@linutronix.de>,
linux-snps-arc@lists.infradead.org
Subject: Re: [PATCH v3] devres: Explicitly align datai[] to 64-bit
Date: Mon, 9 Jul 2018 16:10:56 +0200 [thread overview]
Message-ID: <20180709141056.GR2512@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180709140717.GR2476@hirez.programming.kicks-ass.net>
On Mon, Jul 09, 2018 at 04:07:17PM +0200, Peter Zijlstra wrote:
> On Mon, Jul 09, 2018 at 04:45:50PM +0300, Alexey Brodkin wrote:
> > --- a/drivers/base/devres.c
> > +++ b/drivers/base/devres.c
> > @@ -24,8 +24,12 @@ struct devres_node {
> >
> > struct devres {
> > struct devres_node node;
> > - /* -- 3 pointers */
> > - unsigned long long data[]; /* guarantee ull alignment */
> > + /*
> > + * data[] must be 64 bit aligned even on 32 bit architectures
> > + * because it might be accessed by instructions that require
> > + * aligned memory arguments such as atomic64_t.
> > + */
> > + u8 __aligned(8) data[];
> > };
>
> Seeing that this ends up in a semi generic allocation thing, I don't
> feel this should be different from ARCH_KMALLOC_MINALIGN.
In fact, since alloc_dr() uses kmalloc() to allocate the entire thing,
it is impossible to guarantee a larger alignment than kmalloc does.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-arch@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
David Laight <David.Laight@ACULAB.COM>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will.deacon@arm.com>, Greg KH <greg@kroah.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v3] devres: Explicitly align datai[] to 64-bit
Date: Mon, 9 Jul 2018 16:10:56 +0200 [thread overview]
Message-ID: <20180709141056.GR2512@hirez.programming.kicks-ass.net> (raw)
Message-ID: <20180709141056.f6RoRcybLtYI0w0yxbUBjppOGy8D09wBk4dt9d7fPJg@z> (raw)
In-Reply-To: <20180709140717.GR2476@hirez.programming.kicks-ass.net>
On Mon, Jul 09, 2018 at 04:07:17PM +0200, Peter Zijlstra wrote:
> On Mon, Jul 09, 2018 at 04:45:50PM +0300, Alexey Brodkin wrote:
> > --- a/drivers/base/devres.c
> > +++ b/drivers/base/devres.c
> > @@ -24,8 +24,12 @@ struct devres_node {
> >
> > struct devres {
> > struct devres_node node;
> > - /* -- 3 pointers */
> > - unsigned long long data[]; /* guarantee ull alignment */
> > + /*
> > + * data[] must be 64 bit aligned even on 32 bit architectures
> > + * because it might be accessed by instructions that require
> > + * aligned memory arguments such as atomic64_t.
> > + */
> > + u8 __aligned(8) data[];
> > };
>
> Seeing that this ends up in a semi generic allocation thing, I don't
> feel this should be different from ARCH_KMALLOC_MINALIGN.
In fact, since alloc_dr() uses kmalloc() to allocate the entire thing,
it is impossible to guarantee a larger alignment than kmalloc does.
WARNING: multiple messages have this Message-ID (diff)
From: peterz@infradead.org (Peter Zijlstra)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v3] devres: Explicitly align datai[] to 64-bit
Date: Mon, 9 Jul 2018 16:10:56 +0200 [thread overview]
Message-ID: <20180709141056.GR2512@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180709140717.GR2476@hirez.programming.kicks-ass.net>
On Mon, Jul 09, 2018@04:07:17PM +0200, Peter Zijlstra wrote:
> On Mon, Jul 09, 2018@04:45:50PM +0300, Alexey Brodkin wrote:
> > --- a/drivers/base/devres.c
> > +++ b/drivers/base/devres.c
> > @@ -24,8 +24,12 @@ struct devres_node {
> >
> > struct devres {
> > struct devres_node node;
> > - /* -- 3 pointers */
> > - unsigned long long data[]; /* guarantee ull alignment */
> > + /*
> > + * data[] must be 64 bit aligned even on 32 bit architectures
> > + * because it might be accessed by instructions that require
> > + * aligned memory arguments such as atomic64_t.
> > + */
> > + u8 __aligned(8) data[];
> > };
>
> Seeing that this ends up in a semi generic allocation thing, I don't
> feel this should be different from ARCH_KMALLOC_MINALIGN.
In fact, since alloc_dr() uses kmalloc() to allocate the entire thing,
it is impossible to guarantee a larger alignment than kmalloc does.
next prev parent reply other threads:[~2018-07-09 14:10 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 13:45 [PATCH v3] devres: Explicitly align datai[] to 64-bit Alexey Brodkin
2018-07-09 13:45 ` Alexey Brodkin
2018-07-09 13:54 ` Peter Zijlstra
2018-07-09 13:54 ` Peter Zijlstra
2018-07-09 13:54 ` Peter Zijlstra
2018-07-09 13:54 ` Peter Zijlstra
2018-07-09 13:54 ` Peter Zijlstra
2018-07-09 14:04 ` Mark Rutland
2018-07-09 14:04 ` Mark Rutland
2018-07-09 14:10 ` Geert Uytterhoeven
2018-07-09 14:10 ` Geert Uytterhoeven
2018-07-09 14:07 ` Alexey Brodkin
2018-07-09 14:07 ` Alexey Brodkin
2018-07-09 14:07 ` Peter Zijlstra
2018-07-09 14:07 ` Peter Zijlstra
2018-07-09 14:07 ` Peter Zijlstra
2018-07-09 14:10 ` Peter Zijlstra [this message]
2018-07-09 14:10 ` Peter Zijlstra
2018-07-09 14:10 ` Peter Zijlstra
2018-07-09 14:33 ` Alexey Brodkin
2018-07-09 14:33 ` Alexey Brodkin
2018-07-09 14:49 ` Peter Zijlstra
2018-07-09 14:49 ` Peter Zijlstra
2018-07-09 14:53 ` Alexey Brodkin
2018-07-09 14:53 ` Alexey Brodkin
2018-10-04 16:19 ` Alexey Brodkin
2018-10-04 16:19 ` Alexey Brodkin
2018-07-09 15:02 ` David Laight
2018-07-09 15:02 ` David Laight
2018-07-09 15:14 ` Peter Zijlstra
2018-07-09 15:14 ` Peter Zijlstra
2018-07-09 15:14 ` Peter Zijlstra
2018-07-09 15:29 ` Mark Rutland
2018-07-09 15:29 ` Mark Rutland
2018-07-09 15:34 ` Peter Zijlstra
2018-07-09 15:34 ` Peter Zijlstra
2018-07-09 15:34 ` Peter Zijlstra
2018-07-09 15:45 ` Peter Zijlstra
2018-07-09 15:45 ` Peter Zijlstra
2018-07-09 15:45 ` Peter Zijlstra
2018-07-09 15:48 ` Mark Rutland
2018-07-09 15:48 ` Mark Rutland
2018-07-09 16:10 ` David Laight
2018-07-09 16:10 ` David Laight
2018-07-09 20:28 ` Vineet Gupta
2018-07-09 20:28 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709141056.GR2512@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Alexey.Brodkin@synopsys.com \
--cc=David.Laight@ACULAB.COM \
--cc=geert@linux-m68k.org \
--cc=greg@kroah.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.