From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Revert "arm64: Use aarch64elf and aarch64elfb emulation mode variants"
Date: Tue, 10 Jul 2018 10:01:26 +0100 [thread overview]
Message-ID: <20180710090125.GA28924@arm.com> (raw)
In-Reply-To: <20180709200956.31158-1-labbott@redhat.com>
Thanks, Laura.
I'll take this as a fix, and add a comment to the Makefile to justify
why we need the linux target.
Will
On Mon, Jul 09, 2018 at 01:09:56PM -0700, Laura Abbott wrote:
> This reverts commit 38fc4248677552ce35efc09902fdcb06b61d7ef9.
>
> This breaks compilation with Fedora gcc-8 tool chains:
>
> CHK include/generated/compile.h
> LD [M] arch/arm64/crypto/sha512-ce.o
> aarch64-linux-gnu-ld: cannot open linker script file ldscripts/aarch64elf.xr: No such file or directory
> make[1]: *** [scripts/Makefile.build:530: arch/arm64/crypto/sha512-ce.o] Error 1
> make: *** [Makefile:1029: arch/arm64/crypto] Error 2
>
> Fixes: 38fc42486775 ("arm64: Use aarch64elf and aarch64elfb emulation mode variants")
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> A bit rushed and I'm still debugging but I wanted to send this out
> before anyone else gets hit since it is -rc4. Seeing this on both native
> and cross compiles.
> ---
> arch/arm64/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index 7976d2d242fa..f476d52ad8d6 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -60,13 +60,13 @@ ifeq ($(CONFIG_CPU_BIG_ENDIAN), y)
> KBUILD_CPPFLAGS += -mbig-endian
> CHECKFLAGS += -D__AARCH64EB__
> AS += -EB
> -LDFLAGS += -EB -maarch64elfb
> +LDFLAGS += -EB -maarch64linuxb
> UTS_MACHINE := aarch64_be
> else
> KBUILD_CPPFLAGS += -mlittle-endian
> CHECKFLAGS += -D__AARCH64EL__
> AS += -EL
> -LDFLAGS += -EL -maarch64elf
> +LDFLAGS += -EL -maarch64linux
> UTS_MACHINE := aarch64
> endif
>
> --
> 2.17.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Paul Kocialkowski <contact@paulk.fr>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "arm64: Use aarch64elf and aarch64elfb emulation mode variants"
Date: Tue, 10 Jul 2018 10:01:26 +0100 [thread overview]
Message-ID: <20180710090125.GA28924@arm.com> (raw)
In-Reply-To: <20180709200956.31158-1-labbott@redhat.com>
Thanks, Laura.
I'll take this as a fix, and add a comment to the Makefile to justify
why we need the linux target.
Will
On Mon, Jul 09, 2018 at 01:09:56PM -0700, Laura Abbott wrote:
> This reverts commit 38fc4248677552ce35efc09902fdcb06b61d7ef9.
>
> This breaks compilation with Fedora gcc-8 tool chains:
>
> CHK include/generated/compile.h
> LD [M] arch/arm64/crypto/sha512-ce.o
> aarch64-linux-gnu-ld: cannot open linker script file ldscripts/aarch64elf.xr: No such file or directory
> make[1]: *** [scripts/Makefile.build:530: arch/arm64/crypto/sha512-ce.o] Error 1
> make: *** [Makefile:1029: arch/arm64/crypto] Error 2
>
> Fixes: 38fc42486775 ("arm64: Use aarch64elf and aarch64elfb emulation mode variants")
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> A bit rushed and I'm still debugging but I wanted to send this out
> before anyone else gets hit since it is -rc4. Seeing this on both native
> and cross compiles.
> ---
> arch/arm64/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index 7976d2d242fa..f476d52ad8d6 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -60,13 +60,13 @@ ifeq ($(CONFIG_CPU_BIG_ENDIAN), y)
> KBUILD_CPPFLAGS += -mbig-endian
> CHECKFLAGS += -D__AARCH64EB__
> AS += -EB
> -LDFLAGS += -EB -maarch64elfb
> +LDFLAGS += -EB -maarch64linuxb
> UTS_MACHINE := aarch64_be
> else
> KBUILD_CPPFLAGS += -mlittle-endian
> CHECKFLAGS += -D__AARCH64EL__
> AS += -EL
> -LDFLAGS += -EL -maarch64elf
> +LDFLAGS += -EL -maarch64linux
> UTS_MACHINE := aarch64
> endif
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-07-10 9:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 20:09 [PATCH] Revert "arm64: Use aarch64elf and aarch64elfb emulation mode variants" Laura Abbott
2018-07-09 20:09 ` Laura Abbott
2018-07-09 23:24 ` Laura Abbott
2018-07-09 23:24 ` Laura Abbott
2018-07-10 0:29 ` Kevin Hilman
2018-07-10 0:29 ` Kevin Hilman
2018-07-10 9:01 ` Will Deacon [this message]
2018-07-10 9:01 ` Will Deacon
2018-07-10 9:30 ` Paul Kocialkowski
2018-07-10 9:30 ` Paul Kocialkowski
2018-07-10 9:36 ` Will Deacon
2018-07-10 9:36 ` Will Deacon
2018-07-13 14:59 ` Olof Johansson
2018-07-13 14:59 ` Olof Johansson
2018-07-13 15:01 ` Olof Johansson
2018-07-13 15:01 ` Olof Johansson
2018-07-13 15:08 ` Paul Kocialkowski
2018-07-13 15:08 ` Paul Kocialkowski
2018-07-13 15:07 ` Will Deacon
2018-07-13 15:07 ` Will Deacon
2018-07-13 15:15 ` Olof Johansson
2018-07-13 15:15 ` Olof Johansson
2018-07-13 15:30 ` [PATCH] arm64: build with baremetal linker target instead of Linux when available Olof Johansson
2018-07-13 15:30 ` Olof Johansson
2018-07-13 19:21 ` Laura Abbott
2018-07-13 19:21 ` Laura Abbott
2018-07-13 19:58 ` Olof Johansson
2018-07-13 19:58 ` Olof Johansson
2018-07-18 23:08 ` Masahiro Yamada
2018-07-18 23:08 ` Masahiro Yamada
2018-07-19 0:18 ` Ard Biesheuvel
2018-07-19 0:18 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710090125.GA28924@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.