From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 00/19] arm64: invoke syscalls with pt_regs
Date: Tue, 10 Jul 2018 11:39:02 +0100 [thread overview]
Message-ID: <20180710103901.GA31318@arm.com> (raw)
In-Reply-To: <20180702110415.10465-1-mark.rutland@arm.com>
On Mon, Jul 02, 2018 at 12:03:56PM +0100, Mark Rutland wrote:
> This series reworks arm64's syscall handling to minimize the propagation
> of user-controlled register values into speculated code paths. As with
> x86 [1], a wrapper is generated for each syscall, which extracts the
> argument from a struct pt_regs. During kernel entry from userspace,
> registers are zeroed.
>
> The arm64 kernel code directly invokes some syscalls which the x86 code
> doesn't, so I've added ksys_* wrappers for these, following the x86
> example. The rest of the series is arm64-specific.
>
> I've pushed the series out to my arm64/syscall-regs branch [2] on
> kernel.org.
One thing I noticed with this series applied is that our sys_call_table
declarations all get a bit muddled:
arm64/kernel/sys.c: void * const sys_call_table[]
arm64/kernel/sys32.c: void * const compat_sys_call_table[]
arm64/kernel/syscall.c: extern syscall_fn_t sys_call_table[];
extern syscall_fn_t compat_sys_call_table[];
arm64/include/asm/syscall.h: extern const void *sys_call_table[];
Can we tidy this up so that syscall.h provides a declaration using
syscall_fn_t, allowing us to drop the additional externs?
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
dave.martin@arm.com, hch@infradead.org, james.morse@arm.com,
linux@dominikbrodowski.net, linux-fsdevel@vger.kernel.org,
marc.zyngier@arm.com, viro@zeniv.linux.org.uk
Subject: Re: [PATCHv4 00/19] arm64: invoke syscalls with pt_regs
Date: Tue, 10 Jul 2018 11:39:02 +0100 [thread overview]
Message-ID: <20180710103901.GA31318@arm.com> (raw)
In-Reply-To: <20180702110415.10465-1-mark.rutland@arm.com>
On Mon, Jul 02, 2018 at 12:03:56PM +0100, Mark Rutland wrote:
> This series reworks arm64's syscall handling to minimize the propagation
> of user-controlled register values into speculated code paths. As with
> x86 [1], a wrapper is generated for each syscall, which extracts the
> argument from a struct pt_regs. During kernel entry from userspace,
> registers are zeroed.
>
> The arm64 kernel code directly invokes some syscalls which the x86 code
> doesn't, so I've added ksys_* wrappers for these, following the x86
> example. The rest of the series is arm64-specific.
>
> I've pushed the series out to my arm64/syscall-regs branch [2] on
> kernel.org.
One thing I noticed with this series applied is that our sys_call_table
declarations all get a bit muddled:
arm64/kernel/sys.c: void * const sys_call_table[]
arm64/kernel/sys32.c: void * const compat_sys_call_table[]
arm64/kernel/syscall.c: extern syscall_fn_t sys_call_table[];
extern syscall_fn_t compat_sys_call_table[];
arm64/include/asm/syscall.h: extern const void *sys_call_table[];
Can we tidy this up so that syscall.h provides a declaration using
syscall_fn_t, allowing us to drop the additional externs?
Will
next prev parent reply other threads:[~2018-07-10 10:39 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 11:03 [PATCHv4 00/19] arm64: invoke syscalls with pt_regs Mark Rutland
2018-07-02 11:03 ` Mark Rutland
2018-07-02 11:03 ` [PATCHv4 01/19] arm64: consistently use unsigned long for thread flags Mark Rutland
2018-07-02 11:03 ` Mark Rutland
2018-07-02 11:03 ` [PATCHv4 02/19] arm64: move SCTLR_EL{1, 2} assertions to <asm/sysreg.h> Mark Rutland
2018-07-02 11:03 ` [PATCHv4 02/19] arm64: move SCTLR_EL{1,2} " Mark Rutland
2018-07-02 11:03 ` [PATCHv4 03/19] arm64: kill config_sctlr_el1() Mark Rutland
2018-07-02 11:03 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 04/19] arm64: kill change_cpacr() Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 05/19] arm64: move sve_user_{enable, disable} to <asm/fpsimd.h> Mark Rutland
2018-07-02 11:04 ` [PATCHv4 05/19] arm64: move sve_user_{enable,disable} " Mark Rutland
2018-07-02 11:04 ` [PATCHv4 06/19] arm64: remove sigreturn wrappers Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 07/19] arm64: convert raw syscall invocation to C Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 08/19] arm64: convert syscall trace logic " Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 09/19] arm64: convert native/compat syscall entry " Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 10/19] arm64: don't restore GPRs when context tracking Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 11/19] arm64: don't reload GPRs after apply_ssbd Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-06 16:38 ` Will Deacon
2018-07-06 16:38 ` Will Deacon
2018-07-09 14:21 ` Mark Rutland
2018-07-09 14:21 ` Mark Rutland
2018-07-10 10:37 ` Dave Martin
2018-07-10 10:37 ` Dave Martin
2018-07-10 17:33 ` Will Deacon
2018-07-10 17:33 ` Will Deacon
2018-07-11 9:46 ` Mark Rutland
2018-07-11 9:46 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 12/19] arm64: zero GPRs upon entry from EL0 Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 13/19] kernel: add ksys_personality() Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 14/19] kernel: add kcompat_sys_{f,}statfs64() Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 15/19] arm64: remove in-kernel call to sys_personality() Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 16/19] arm64: use {COMPAT,}SYSCALL_DEFINE0 for sigreturn Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 17/19] arm64: use SYSCALL_DEFINE6() for mmap Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 18/19] arm64: convert compat wrappers to C Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-02 11:04 ` [PATCHv4 19/19] arm64: implement syscall wrappers Mark Rutland
2018-07-02 11:04 ` Mark Rutland
2018-07-06 16:42 ` [PATCHv4 00/19] arm64: invoke syscalls with pt_regs Will Deacon
2018-07-06 16:42 ` Will Deacon
2018-07-10 10:39 ` Will Deacon [this message]
2018-07-10 10:39 ` Will Deacon
2018-07-11 10:47 ` Mark Rutland
2018-07-11 10:47 ` Mark Rutland
2018-07-11 12:27 ` Will Deacon
2018-07-11 12:27 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710103901.GA31318@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.