* [PATCH][next] drm/panel: ILI9881c: fix missing assignment to error return ret
@ 2018-06-26 16:03 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2018-06-26 16:03 UTC (permalink / raw)
To: Thierry Reding, David Airlie, dri-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently, ret is being checked for an error condition however it
is not being assigned in the previous statement on the call of
function mipi_dsi_dcs_exit_sleep_mode. Add in the missing assignment
of ret.
Detected by CoverityScan, CID#1470174, 1470178 ("Unchecked return value")
Fixes: 26aec25593c2 ("drm/panel: Add Ilitek ILI9881c panel driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index e848af235df5..3ad4a46c4e94 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -334,7 +334,7 @@ static int ili9881c_prepare(struct drm_panel *panel)
if (ret)
return ret;
- mipi_dsi_dcs_exit_sleep_mode(ctx->dsi);
+ ret = mipi_dsi_dcs_exit_sleep_mode(ctx->dsi);
if (ret)
return ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH][next] drm/panel: ILI9881c: fix missing assignment to error return ret
@ 2018-06-26 16:03 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2018-06-26 16:03 UTC (permalink / raw)
To: Thierry Reding, David Airlie, dri-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently, ret is being checked for an error condition however it
is not being assigned in the previous statement on the call of
function mipi_dsi_dcs_exit_sleep_mode. Add in the missing assignment
of ret.
Detected by CoverityScan, CID#1470174, 1470178 ("Unchecked return value")
Fixes: 26aec25593c2 ("drm/panel: Add Ilitek ILI9881c panel driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index e848af235df5..3ad4a46c4e94 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -334,7 +334,7 @@ static int ili9881c_prepare(struct drm_panel *panel)
if (ret)
return ret;
- mipi_dsi_dcs_exit_sleep_mode(ctx->dsi);
+ ret = mipi_dsi_dcs_exit_sleep_mode(ctx->dsi);
if (ret)
return ret;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH][next] drm/panel: ILI9881c: fix missing assignment to error return ret
@ 2018-06-26 16:03 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2018-06-26 16:03 UTC (permalink / raw)
To: Thierry Reding, David Airlie, dri-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently, ret is being checked for an error condition however it
is not being assigned in the previous statement on the call of
function mipi_dsi_dcs_exit_sleep_mode. Add in the missing assignment
of ret.
Detected by CoverityScan, CID#1470174, 1470178 ("Unchecked return value")
Fixes: 26aec25593c2 ("drm/panel: Add Ilitek ILI9881c panel driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index e848af235df5..3ad4a46c4e94 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -334,7 +334,7 @@ static int ili9881c_prepare(struct drm_panel *panel)
if (ret)
return ret;
- mipi_dsi_dcs_exit_sleep_mode(ctx->dsi);
+ ret = mipi_dsi_dcs_exit_sleep_mode(ctx->dsi);
if (ret)
return ret;
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH][next] drm/panel: ILI9881c: fix missing assignment to error return ret
2018-06-26 16:03 ` Colin King
(?)
@ 2018-07-10 10:42 ` Thierry Reding
-1 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2018-07-10 10:42 UTC (permalink / raw)
To: Colin King; +Cc: David Airlie, kernel-janitors, linux-kernel, dri-devel
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
On Tue, Jun 26, 2018 at 05:03:54PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently, ret is being checked for an error condition however it
> is not being assigned in the previous statement on the call of
> function mipi_dsi_dcs_exit_sleep_mode. Add in the missing assignment
> of ret.
>
> Detected by CoverityScan, CID#1470174, 1470178 ("Unchecked return value")
>
> Fixes: 26aec25593c2 ("drm/panel: Add Ilitek ILI9881c panel driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][next] drm/panel: ILI9881c: fix missing assignment to error return ret
@ 2018-07-10 10:42 ` Thierry Reding
0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2018-07-10 10:42 UTC (permalink / raw)
To: Colin King; +Cc: David Airlie, dri-devel, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
On Tue, Jun 26, 2018 at 05:03:54PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently, ret is being checked for an error condition however it
> is not being assigned in the previous statement on the call of
> function mipi_dsi_dcs_exit_sleep_mode. Add in the missing assignment
> of ret.
>
> Detected by CoverityScan, CID#1470174, 1470178 ("Unchecked return value")
>
> Fixes: 26aec25593c2 ("drm/panel: Add Ilitek ILI9881c panel driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH][next] drm/panel: ILI9881c: fix missing assignment to error return ret
@ 2018-07-10 10:42 ` Thierry Reding
0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2018-07-10 10:42 UTC (permalink / raw)
To: Colin King; +Cc: David Airlie, kernel-janitors, linux-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 696 bytes --]
On Tue, Jun 26, 2018 at 05:03:54PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently, ret is being checked for an error condition however it
> is not being assigned in the previous statement on the call of
> function mipi_dsi_dcs_exit_sleep_mode. Add in the missing assignment
> of ret.
>
> Detected by CoverityScan, CID#1470174, 1470178 ("Unchecked return value")
>
> Fixes: 26aec25593c2 ("drm/panel: Add Ilitek ILI9881c panel driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-10 10:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-26 16:03 [PATCH][next] drm/panel: ILI9881c: fix missing assignment to error return ret Colin King
2018-06-26 16:03 ` Colin King
2018-06-26 16:03 ` Colin King
2018-07-10 10:42 ` Thierry Reding
2018-07-10 10:42 ` Thierry Reding
2018-07-10 10:42 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.