From: Greg KH <gregkh@linuxfoundation.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: stable@vger.kernel.org, boris.brezillon@bootlin.com,
miquel.raynal@bootlin.com, s.hauer@pengutronix.de
Subject: Re: [PATCH] mtd: rawnand: mxc: set spare area size register explicitly
Date: Tue, 10 Jul 2018 16:17:00 +0200 [thread overview]
Message-ID: <20180710141700.GR1123@kroah.com> (raw)
In-Reply-To: <1530462993-2125-1-git-send-email-martin@kaiser.cx>
On Sun, Jul 01, 2018 at 06:36:33PM +0200, Martin Kaiser wrote:
> commit 3f77f244d8ec28e3a0a81240ffac7d626390060c upstream.
>
> The v21 version of the NAND flash controller contains a Spare Area Size
> Register (SPAS) at offset 0x10. Its setting defaults to the maximum
> spare area size of 218 bytes. The size that is set in this register is
> used by the controller when it calculates the ECC bytes internally in
> hardware.
>
> Usually, this register is updated from settings in the IIM fuses when
> the system is booting from NAND flash. For other boot media, however,
> the SPAS register remains at the default setting, which may not work for
> the particular flash chip on the board. The same goes for flash chips
> whose configuration cannot be set in the IIM fuses (e.g. chips with 2k
> sector size and 128 bytes spare area size can't be configured in the IIM
> fuses on imx25 systems).
>
> Set the SPAS register explicitly during the preset operation. Derive the
> register value from mtd->oobsize that was detected during probe by
> decoding the flash chip's ID bytes.
>
> While at it, rename the define for the spare area register's offset to
> NFC_V21_RSLTSPARE_AREA. The register at offset 0x10 on v1 controllers is
> different from the register on v21 controllers.
>
> Fixes: d484018 ("mtd: mxc_nand: set NFC registers after reset")
> Cc: stable@vger.kernel.org
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> Hello Greg,
>
> the file that this patch modifies was renamed after 4.14. This patch
> uses the previous name. I tested it to apply to the 4.4, 4.9 and 4.14
> stable branches. Could you add it to the queues again?
Now applied, thanks.
greg k-h
next prev parent reply other threads:[~2018-07-10 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-01 9:56 FAILED: patch "[PATCH] mtd: rawnand: mxc: set spare area size register explicitly" failed to apply to 4.14-stable tree gregkh
2018-07-01 16:36 ` [PATCH] mtd: rawnand: mxc: set spare area size register explicitly Martin Kaiser
2018-07-10 14:17 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-03 11:31 Martin Kaiser
2018-06-04 6:53 ` Sascha Hauer
2018-06-07 15:19 ` Miquel Raynal
2018-06-10 13:14 ` Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710141700.GR1123@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=boris.brezillon@bootlin.com \
--cc=martin@kaiser.cx \
--cc=miquel.raynal@bootlin.com \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.