From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: devel@driverdev.osuosl.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
Sergio Paracuellos <sergio.paracuellos@gmail.com>,
linux-mediatek@lists.infradead.org, NeilBrown <neil@brown.name>,
John Crispin <blogic@openwrt.org>,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH 2/2] staging: mt7621-gpio: remove driver
Date: Tue, 10 Jul 2018 17:30:09 +0200 [thread overview]
Message-ID: <20180710153009.GA11605@kroah.com> (raw)
In-Reply-To: <20180710151915.2282622-2-arnd@arndb.de>
On Tue, Jul 10, 2018 at 05:18:48PM +0200, Arnd Bergmann wrote:
> The gpio-mt7621 driver has graduated out of staging and got accepted
> into the gpio tree. Since they both use the same Kconfig symbol,
> we could run into conflicts, e.g. I got this failure when the staging
> driver got enabled with the other one being unavailable but using the
> same Kconfig symbol:
>
> drivers/gpio/gpio-mt7621.c: In function 'mediatek_gpio_bank_probe':
> drivers/gpio/gpio-mt7621.c:228:10: error: 'struct gpio_chip' has no member named 'of_node'
> rg->chip.of_node = node;
> ^
> drivers/gpio/gpio-mt7621.c:243:10: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
> rg->chip.of_gpio_n_cells = 2;
> ^
> drivers/gpio/gpio-mt7621.c:244:10: error: 'struct gpio_chip' has no member named 'of_xlate'
> rg->chip.of_xlate = mediatek_gpio_xlate;
>
> It would be trivial to rename the Kconfig symbol to avoid that problem,
> but there is also seems to be little value in keeping the staging driver
> around now.
>
> Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This is already removed in my staging-next tree and will be in the next
linux-next.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] staging: mt7621-gpio: remove driver
Date: Tue, 10 Jul 2018 17:30:09 +0200 [thread overview]
Message-ID: <20180710153009.GA11605@kroah.com> (raw)
In-Reply-To: <20180710151915.2282622-2-arnd@arndb.de>
On Tue, Jul 10, 2018 at 05:18:48PM +0200, Arnd Bergmann wrote:
> The gpio-mt7621 driver has graduated out of staging and got accepted
> into the gpio tree. Since they both use the same Kconfig symbol,
> we could run into conflicts, e.g. I got this failure when the staging
> driver got enabled with the other one being unavailable but using the
> same Kconfig symbol:
>
> drivers/gpio/gpio-mt7621.c: In function 'mediatek_gpio_bank_probe':
> drivers/gpio/gpio-mt7621.c:228:10: error: 'struct gpio_chip' has no member named 'of_node'
> rg->chip.of_node = node;
> ^
> drivers/gpio/gpio-mt7621.c:243:10: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
> rg->chip.of_gpio_n_cells = 2;
> ^
> drivers/gpio/gpio-mt7621.c:244:10: error: 'struct gpio_chip' has no member named 'of_xlate'
> rg->chip.of_xlate = mediatek_gpio_xlate;
>
> It would be trivial to rename the Kconfig symbol to avoid that problem,
> but there is also seems to be little value in keeping the staging driver
> around now.
>
> Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This is already removed in my staging-next tree and will be in the next
linux-next.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
NeilBrown <neil@brown.name>,
Sergio Paracuellos <sergio.paracuellos@gmail.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 2/2] staging: mt7621-gpio: remove driver
Date: Tue, 10 Jul 2018 17:30:09 +0200 [thread overview]
Message-ID: <20180710153009.GA11605@kroah.com> (raw)
In-Reply-To: <20180710151915.2282622-2-arnd@arndb.de>
On Tue, Jul 10, 2018 at 05:18:48PM +0200, Arnd Bergmann wrote:
> The gpio-mt7621 driver has graduated out of staging and got accepted
> into the gpio tree. Since they both use the same Kconfig symbol,
> we could run into conflicts, e.g. I got this failure when the staging
> driver got enabled with the other one being unavailable but using the
> same Kconfig symbol:
>
> drivers/gpio/gpio-mt7621.c: In function 'mediatek_gpio_bank_probe':
> drivers/gpio/gpio-mt7621.c:228:10: error: 'struct gpio_chip' has no member named 'of_node'
> rg->chip.of_node = node;
> ^
> drivers/gpio/gpio-mt7621.c:243:10: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
> rg->chip.of_gpio_n_cells = 2;
> ^
> drivers/gpio/gpio-mt7621.c:244:10: error: 'struct gpio_chip' has no member named 'of_xlate'
> rg->chip.of_xlate = mediatek_gpio_xlate;
>
> It would be trivial to rename the Kconfig symbol to avoid that problem,
> but there is also seems to be little value in keeping the staging driver
> around now.
>
> Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This is already removed in my staging-next tree and will be in the next
linux-next.
thanks,
greg k-h
next prev parent reply other threads:[~2018-07-10 15:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 15:18 [PATCH 1/2] gpio: mt7621: add OF_GPIO dependency Arnd Bergmann
2018-07-10 15:18 ` Arnd Bergmann
2018-07-10 15:18 ` Arnd Bergmann
2018-07-10 15:18 ` [PATCH 2/2] staging: mt7621-gpio: remove driver Arnd Bergmann
2018-07-10 15:18 ` Arnd Bergmann
2018-07-10 15:18 ` Arnd Bergmann
2018-07-10 15:30 ` Greg Kroah-Hartman [this message]
2018-07-10 15:30 ` Greg Kroah-Hartman
2018-07-10 15:30 ` Greg Kroah-Hartman
2018-07-13 7:26 ` [PATCH 1/2] gpio: mt7621: add OF_GPIO dependency Linus Walleij
2018-07-13 7:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710153009.GA11605@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=blogic@openwrt.org \
--cc=devel@driverdev.osuosl.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=neil@brown.name \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.