* [PATCH] automation: fix builds with clang
@ 2018-07-10 22:58 Doug Goldstein
2018-07-11 0:06 ` Doug Goldstein
2018-07-11 7:07 ` Wei Liu
0 siblings, 2 replies; 3+ messages in thread
From: Doug Goldstein @ 2018-07-10 22:58 UTC (permalink / raw)
To: xen-devel; +Cc: Doug Goldstein, Wei Liu
a75703b2f0f585a2fc6a7bcdb7d16a61bcf5e6b0 unconditionally enabled
building of rombios and stubdoms but unfortunately these two pieces do
not build successfully with clang. rombios unconditionally depends on
the build of iPXE and upstream iPXE does not support building with
clang. Similiarly the build of the stubdoms depends on the build of
newlib which does not support being built with clang.
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
---
automation/scripts/build | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/automation/scripts/build b/automation/scripts/build
index b9e4c1e329..8bbca15a51 100755
--- a/automation/scripts/build
+++ b/automation/scripts/build
@@ -13,9 +13,13 @@ fi
cfgargs=()
cfgargs+=("--enable-docs")
-# SeaBIOS cannot be built with clang
if [[ "${CC}" == "clang" ]]; then
+ # SeaBIOS cannot be built with clang
cfgargs+=("--with-system-seabios=/usr/share/seabios/bios.bin")
+ # iPXE cannot be built with clang so we cannot build rombios
+ cfgargs+=("--disable-rombios")
+ # newlib cannot be built with clang so we cannot build stubdoms
+ cfgargs+=("--disable-stubdom")
fi
if [[ "${XEN_TARGET_ARCH}" == "arm64" || "${XEN_TARGET_ARCH}" == "arm32" ]]; then
--
2.16.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] automation: fix builds with clang
2018-07-10 22:58 [PATCH] automation: fix builds with clang Doug Goldstein
@ 2018-07-11 0:06 ` Doug Goldstein
2018-07-11 7:07 ` Wei Liu
1 sibling, 0 replies; 3+ messages in thread
From: Doug Goldstein @ 2018-07-11 0:06 UTC (permalink / raw)
To: xen-devel; +Cc: Wei Liu
On Tue, Jul 10, 2018 at 05:58:58PM -0500, Doug Goldstein wrote:
Without this patch:
https://gitlab.com/xen-project/xen/pipelines/25489605
With this patch:
https://gitlab.com/cardoe/xen/pipelines/25512404
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] automation: fix builds with clang
2018-07-10 22:58 [PATCH] automation: fix builds with clang Doug Goldstein
2018-07-11 0:06 ` Doug Goldstein
@ 2018-07-11 7:07 ` Wei Liu
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2018-07-11 7:07 UTC (permalink / raw)
To: Doug Goldstein; +Cc: xen-devel, Wei Liu
On Tue, Jul 10, 2018 at 05:58:58PM -0500, Doug Goldstein wrote:
> a75703b2f0f585a2fc6a7bcdb7d16a61bcf5e6b0 unconditionally enabled
> building of rombios and stubdoms but unfortunately these two pieces do
> not build successfully with clang. rombios unconditionally depends on
> the build of iPXE and upstream iPXE does not support building with
The dependency of rombios for ipxe will soon change -- I wrote a patch
series to provide --with-system-ipxe. Does rombios build with clang? If
so I will submit a patch to enable rombios in the future.
> clang. Similiarly the build of the stubdoms depends on the build of
> newlib which does not support being built with clang.
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
For now:
Acked-by: Wei Liu <wei.liu2@citrix.com>
Thanks for fixing this.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-11 7:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-10 22:58 [PATCH] automation: fix builds with clang Doug Goldstein
2018-07-11 0:06 ` Doug Goldstein
2018-07-11 7:07 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.