From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: neon: Fix function may_use_simd() return error status
Date: Wed, 11 Jul 2018 13:05:19 +0100 [thread overview]
Message-ID: <20180711120519.GC15725@arm.com> (raw)
In-Reply-To: <1531307188-12032-1-git-send-email-yandong77520@gmail.com>
On Wed, Jul 11, 2018 at 07:06:28PM +0800, Yandong.Zhao wrote:
> From: Yandong Zhao <yandong77520@gmail.com>
>
> It does not matter if the caller of may_use_simd() migrates to
> another cpu after the call, but it is still important that the
> kernel_neon_busy percpu instance that is read matches the cpu the
> task is running on at the time of the read.
>
> This means that raw_cpu_read() is not sufficient. kernel_neon_busy
> may appear true if the caller migrates during the execution of
> raw_cpu_read() and the next task to be scheduled in on the initial
> cpu calls kernel_neon_begin().
>
> This patch replaces raw_cpu_read() with this_cpu_read() to protect
> against this race.
>
> Fixes: cb84d11e1625 ("arm64: neon: Remove support for nested or hardirq kernel-mode NEON")
> Reviewed-by: Dave Martin <Dave.Martin@arm.com>
> Signed-off-by: Yandong Zhao <yandong77520@gmail.com>
> ---
> arch/arm64/include/asm/simd.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Does this need to go to stable?
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: "Yandong.Zhao" <yandong77520@gmail.com>
Cc: Dave.Martin@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, ard.biesheuvel@linaro.org,
catalin.marinas@arm.com, zhaoyd@thundersoft.com,
zhaoxb@thundersoft.com, fanlc0801@thundersoft.com
Subject: Re: [PATCH] arm64: neon: Fix function may_use_simd() return error status
Date: Wed, 11 Jul 2018 13:05:19 +0100 [thread overview]
Message-ID: <20180711120519.GC15725@arm.com> (raw)
In-Reply-To: <1531307188-12032-1-git-send-email-yandong77520@gmail.com>
On Wed, Jul 11, 2018 at 07:06:28PM +0800, Yandong.Zhao wrote:
> From: Yandong Zhao <yandong77520@gmail.com>
>
> It does not matter if the caller of may_use_simd() migrates to
> another cpu after the call, but it is still important that the
> kernel_neon_busy percpu instance that is read matches the cpu the
> task is running on at the time of the read.
>
> This means that raw_cpu_read() is not sufficient. kernel_neon_busy
> may appear true if the caller migrates during the execution of
> raw_cpu_read() and the next task to be scheduled in on the initial
> cpu calls kernel_neon_begin().
>
> This patch replaces raw_cpu_read() with this_cpu_read() to protect
> against this race.
>
> Fixes: cb84d11e1625 ("arm64: neon: Remove support for nested or hardirq kernel-mode NEON")
> Reviewed-by: Dave Martin <Dave.Martin@arm.com>
> Signed-off-by: Yandong Zhao <yandong77520@gmail.com>
> ---
> arch/arm64/include/asm/simd.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Does this need to go to stable?
Will
next prev parent reply other threads:[~2018-07-11 12:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 11:06 [PATCH] arm64: neon: Fix function may_use_simd() return error status Yandong.Zhao
2018-07-11 11:06 ` Yandong.Zhao
2018-07-11 12:05 ` Will Deacon [this message]
2018-07-11 12:05 ` Will Deacon
2018-07-11 12:58 ` Dave Martin
2018-07-11 12:58 ` Dave Martin
-- strict thread matches above, loose matches on Subject: below --
2018-07-12 3:29 Yandong.Zhao
2018-07-12 3:29 ` Yandong.Zhao
2018-07-12 9:56 ` Dave Martin
2018-07-12 9:56 ` Dave Martin
2018-07-11 1:09 Yandong.Zhao
2018-07-11 1:09 ` Yandong.Zhao
2018-07-11 7:20 ` Ard Biesheuvel
2018-07-11 7:20 ` Ard Biesheuvel
2018-07-11 15:47 ` Mark Rutland
2018-07-11 15:47 ` Mark Rutland
2018-07-11 16:03 ` Will Deacon
2018-07-11 16:03 ` Will Deacon
2018-07-11 16:07 ` Mark Rutland
2018-07-11 16:07 ` Mark Rutland
2018-07-11 10:55 ` Dave Martin
2018-07-11 10:55 ` Dave Martin
2018-07-10 2:21 Yandong.Zhao
2018-07-10 2:21 ` Yandong.Zhao
2018-07-10 13:11 ` Dave Martin
2018-07-10 13:11 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711120519.GC15725@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.