From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] pinctrl: at91-pio4: remove redundant return value check of platform_get_resource()
Date: Wed, 11 Jul 2018 13:03:49 +0000 [thread overview]
Message-ID: <20180711130349.GP16084@piout.net> (raw)
In-Reply-To: <1531312447-134423-1-git-send-email-weiyongjun1@huawei.com>
On 11/07/2018 12:34:07+0000, Wei Yongjun wrote:
> Remove unneeded error handling on the result of a call
> to platform_get_resource() when the value is passed to
> devm_ioremap_resource().
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I'm not sure it is worth the effort but
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/pinctrl/pinctrl-at91-pio4.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
> index 8f06197..ef7ab20 100644
> --- a/drivers/pinctrl/pinctrl-at91-pio4.c
> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
> @@ -971,10 +971,6 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
> atmel_pioctrl->npins = atmel_pioctrl->nbanks * ATMEL_PIO_NPINS_PER_BANK;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "unable to get atmel pinctrl resource\n");
> - return -EINVAL;
> - }
> atmel_pioctrl->reg_base = devm_ioremap_resource(dev, res);
> if (IS_ERR(atmel_pioctrl->reg_base))
> return -EINVAL;
>
>
>
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
kernel-janitors@vger.kernel.org, linux-gpio@vger.kernel.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] pinctrl: at91-pio4: remove redundant return value check of platform_get_resource()
Date: Wed, 11 Jul 2018 15:03:49 +0200 [thread overview]
Message-ID: <20180711130349.GP16084@piout.net> (raw)
In-Reply-To: <1531312447-134423-1-git-send-email-weiyongjun1@huawei.com>
On 11/07/2018 12:34:07+0000, Wei Yongjun wrote:
> Remove unneeded error handling on the result of a call
> to platform_get_resource() when the value is passed to
> devm_ioremap_resource().
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I'm not sure it is worth the effort but
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/pinctrl/pinctrl-at91-pio4.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
> index 8f06197..ef7ab20 100644
> --- a/drivers/pinctrl/pinctrl-at91-pio4.c
> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
> @@ -971,10 +971,6 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
> atmel_pioctrl->npins = atmel_pioctrl->nbanks * ATMEL_PIO_NPINS_PER_BANK;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "unable to get atmel pinctrl resource\n");
> - return -EINVAL;
> - }
> atmel_pioctrl->reg_base = devm_ioremap_resource(dev, res);
> if (IS_ERR(atmel_pioctrl->reg_base))
> return -EINVAL;
>
>
>
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@bootlin.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] pinctrl: at91-pio4: remove redundant return value check of platform_get_resource()
Date: Wed, 11 Jul 2018 15:03:49 +0200 [thread overview]
Message-ID: <20180711130349.GP16084@piout.net> (raw)
In-Reply-To: <1531312447-134423-1-git-send-email-weiyongjun1@huawei.com>
On 11/07/2018 12:34:07+0000, Wei Yongjun wrote:
> Remove unneeded error handling on the result of a call
> to platform_get_resource() when the value is passed to
> devm_ioremap_resource().
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I'm not sure it is worth the effort but
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> drivers/pinctrl/pinctrl-at91-pio4.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
> index 8f06197..ef7ab20 100644
> --- a/drivers/pinctrl/pinctrl-at91-pio4.c
> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c
> @@ -971,10 +971,6 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
> atmel_pioctrl->npins = atmel_pioctrl->nbanks * ATMEL_PIO_NPINS_PER_BANK;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "unable to get atmel pinctrl resource\n");
> - return -EINVAL;
> - }
> atmel_pioctrl->reg_base = devm_ioremap_resource(dev, res);
> if (IS_ERR(atmel_pioctrl->reg_base))
> return -EINVAL;
>
>
>
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-07-11 13:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 12:34 [PATCH -next] pinctrl: at91-pio4: remove redundant return value check of platform_get_resource() Wei Yongjun
2018-07-11 12:34 ` Wei Yongjun
2018-07-11 12:34 ` Wei Yongjun
2018-07-11 13:03 ` Alexandre Belloni [this message]
2018-07-11 13:03 ` Alexandre Belloni
2018-07-11 13:03 ` Alexandre Belloni
2018-07-11 14:10 ` Ludovic Desroches
2018-07-11 14:10 ` Ludovic Desroches
2018-07-11 14:10 ` Ludovic Desroches
2018-07-13 7:43 ` Linus Walleij
2018-07-13 7:43 ` Linus Walleij
2018-07-13 7:43 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711130349.GP16084@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.