All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-omap@vger.kernel.org, nekit1000@gmail.com, mpartap@gmx.net,
	merlijn@wizzup.org
Subject: Re: Vibrations on Droid 4?
Date: Wed, 11 Jul 2018 06:27:39 -0700	[thread overview]
Message-ID: <20180711132739.GL99251@atomide.com> (raw)
In-Reply-To: <20180711080218.GA21225@amd>

* Pavel Machek <pavel@ucw.cz> [180711 08:05]:
> Hi!
> 
> > > Its parent is gpio@4805d000 , and that one seems to be present.
> > > 
> > > user@devuan:/sys/bus/platform/devices$ ls 4805d000.gpio
> > > driver				       driver_override  gpio
> > > gpiochip5  modalias  of_node  power  subsystem  uevent
> > 
> > Sorry, something went wrong with merging this. The parent
> > of ti,omap-dmtimer-pwm and pwm-vibrator should be / and
> > not gpio6.
> 
> Ok, got it to probe... after dts fix and adding EPROBE_DEFFER to
> driver.
..
> --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts
> +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> @@ -159,13 +159,7 @@
>  
>  		dais = <&mcbsp2_port>, <&mcbsp3_port>;
>  	};
> -};
> -
> -&dss {
> -	status = "okay";
> -};
>  
> -&gpio6 {
>  	pwm8: dmtimer-pwm-8 {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&vibrator_direction_pin>;
> @@ -192,7 +186,10 @@
>  		pwm-names = "enable", "direction";
>  		direction-duty-cycle-ns = <10000000>;
>  	};
> +};
>  
> +&dss {
> +	status = "okay";
>  };
>  
>  &dsi1 {

Hmm sorry if I did a mismerge on the above. A note to
myself to stop applying patches that apply with fuzz,
that is clearly dangerous with dts files with lots
of similar named properties.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: Vibrations on Droid 4?
Date: Wed, 11 Jul 2018 06:27:39 -0700	[thread overview]
Message-ID: <20180711132739.GL99251@atomide.com> (raw)
In-Reply-To: <20180711080218.GA21225@amd>

* Pavel Machek <pavel@ucw.cz> [180711 08:05]:
> Hi!
> 
> > > Its parent is gpio at 4805d000 , and that one seems to be present.
> > > 
> > > user at devuan:/sys/bus/platform/devices$ ls 4805d000.gpio
> > > driver				       driver_override  gpio
> > > gpiochip5  modalias  of_node  power  subsystem  uevent
> > 
> > Sorry, something went wrong with merging this. The parent
> > of ti,omap-dmtimer-pwm and pwm-vibrator should be / and
> > not gpio6.
> 
> Ok, got it to probe... after dts fix and adding EPROBE_DEFFER to
> driver.
..
> --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts
> +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> @@ -159,13 +159,7 @@
>  
>  		dais = <&mcbsp2_port>, <&mcbsp3_port>;
>  	};
> -};
> -
> -&dss {
> -	status = "okay";
> -};
>  
> -&gpio6 {
>  	pwm8: dmtimer-pwm-8 {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&vibrator_direction_pin>;
> @@ -192,7 +186,10 @@
>  		pwm-names = "enable", "direction";
>  		direction-duty-cycle-ns = <10000000>;
>  	};
> +};
>  
> +&dss {
> +	status = "okay";
>  };
>  
>  &dsi1 {

Hmm sorry if I did a mismerge on the above. A note to
myself to stop applying patches that apply with fuzz,
that is clearly dangerous with dts files with lots
of similar named properties.

Regards,

Tony

  reply	other threads:[~2018-07-11 13:27 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09  8:15 Vibrations on Droid 4? Pavel Machek
2018-07-09  8:15 ` Pavel Machek
2018-07-09 21:49 ` Sebastian Reichel
2018-07-09 21:49   ` Sebastian Reichel
2018-07-09 22:02   ` Pavel Machek
2018-07-09 22:02     ` Pavel Machek
2018-07-10 10:11     ` Sebastian Reichel
2018-07-10 10:11       ` Sebastian Reichel
2018-07-10 13:30       ` Pavel Machek
2018-07-10 13:30         ` Pavel Machek
2018-07-10 16:11         ` Sebastian Reichel
2018-07-10 16:11           ` Sebastian Reichel
2018-07-11  8:02           ` Pavel Machek
2018-07-11  8:02             ` Pavel Machek
2018-07-11 13:27             ` Tony Lindgren [this message]
2018-07-11 13:27               ` Tony Lindgren
2018-07-11 14:25               ` Sebastian Reichel
2018-07-11 14:25                 ` Sebastian Reichel
2018-07-16  7:10                 ` [PATCH] dts/droid4: fix dts w.r.t. pwm Pavel Machek
2018-07-16  7:10                   ` Pavel Machek
2018-07-16 10:11                   ` Sebastian Reichel
2018-07-16 10:11                     ` Sebastian Reichel
2018-07-17  6:48                     ` Tony Lindgren
2018-07-17  6:48                       ` Tony Lindgren
2018-07-16  7:13                 ` [PATCH] pwm-omap: handle timers not ready in probe Pavel Machek
2018-07-16  7:13                   ` Pavel Machek
2018-07-16  7:57                   ` Tony Lindgren
2018-07-16  7:57                     ` Tony Lindgren
2018-07-16  8:37                     ` Pavel Machek
2018-07-16  8:37                       ` Pavel Machek
2018-07-16 15:47                       ` David Rivshin
2018-07-16 15:47                         ` David Rivshin
2018-07-16 15:47                         ` David Rivshin
2018-07-15 20:17               ` Vibrations on Droid 4? Pavel Machek
2018-07-15 20:17                 ` Pavel Machek
2018-07-16  7:59                 ` Tony Lindgren
2018-07-16  7:59                   ` Tony Lindgren
2018-08-01 18:58                   ` Pavel Machek
2018-08-01 18:58                     ` Pavel Machek
2018-08-02 11:07                     ` Sebastian Reichel
2018-08-02 11:07                       ` Sebastian Reichel
2018-08-08 17:09                       ` Pavel Machek
2018-08-08 17:09                         ` Pavel Machek
2018-08-01 20:26                   ` Pavel Machek
2018-08-01 20:26                     ` Pavel Machek
2018-08-01 20:28                   ` [PATCH] fix vibrations on Droid 4 Pavel Machek
2018-08-01 20:28                     ` Pavel Machek
2018-08-02 10:55                     ` Sebastian Reichel
2018-08-02 10:55                       ` Sebastian Reichel
2018-08-17 14:26                       ` Tony Lindgren
2018-08-17 14:26                         ` Tony Lindgren
2018-07-11  8:25           ` Vibrations on Droid 4? Pavel Machek
2018-07-11  8:25             ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180711132739.GL99251@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=merlijn@wizzup.org \
    --cc=mpartap@gmx.net \
    --cc=nekit1000@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.