From: Rob Herring <robh@kernel.org>
To: Govind Singh <govinds@codeaurora.org>
Cc: devicetree@vger.kernel.org, niklas.cassel@linaro.org,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
bjorn.andersson@linaro.org, david.brown@linaro.org,
andy.gross@linaro.org
Subject: Re: [PATCH v3 3/6] dt: bindings: add bindings for msa memory region
Date: Wed, 11 Jul 2018 09:27:18 -0600 [thread overview]
Message-ID: <20180711152718.GA18470@rob-hp-laptop> (raw)
In-Reply-To: <20180706090043.28363-1-govinds@codeaurora.org>
On Fri, Jul 06, 2018 at 02:30:43PM +0530, Govind Singh wrote:
> Add device tree binding documentation details of msa
> memory region for ath10k qmi client for SDM845/APQ8098
> SoC into "qcom,ath10k.txt".
>
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> ---
> .../bindings/net/wireless/qcom,ath10k.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> index 7fd4e8ce4149..87489054aea5 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> @@ -57,6 +57,16 @@ Optional properties:
> - <supply-name>-supply: handle to the regulator device tree node
> optional "supply-name" is "vdd-0.8-cx-mx".
>
> += SUBNODES:
> +wcn3990-wifi node may contain one subnode, named "msa" representing
> +the fixed msa memory regions used by the wifi firmware running in Q6.
> +This sub-node must contain:
Why do you need a sub-node? Just add memory-region property.
> +
> +- memory-region:
> + Usage: required
> + Value type: <phandle>
> + Definition: reference to the reserved-memory for the region
> +
> Example (to supply the calibration data alone):
>
> In this example, the node is defined as child node of the PCI controller.
> @@ -149,4 +159,7 @@ wifi@18000000 {
> <0 140 0 /* CE10 */ >,
> <0 141 0 /* CE11 */ >;
> vdd-0.8-cx-mx-supply = <&pm8998_l5>;
> + msa {
> + memory-region = <&wifi_msa_mem>;
> + };
> };
> --
> 2.17.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Govind Singh <govinds@codeaurora.org>
Cc: devicetree@vger.kernel.org, bjorn.andersson@linaro.org,
david.brown@linaro.org, andy.gross@linaro.org,
niklas.cassel@linaro.org, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 3/6] dt: bindings: add bindings for msa memory region
Date: Wed, 11 Jul 2018 09:27:18 -0600 [thread overview]
Message-ID: <20180711152718.GA18470@rob-hp-laptop> (raw)
In-Reply-To: <20180706090043.28363-1-govinds@codeaurora.org>
On Fri, Jul 06, 2018 at 02:30:43PM +0530, Govind Singh wrote:
> Add device tree binding documentation details of msa
> memory region for ath10k qmi client for SDM845/APQ8098
> SoC into "qcom,ath10k.txt".
>
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> ---
> .../bindings/net/wireless/qcom,ath10k.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> index 7fd4e8ce4149..87489054aea5 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> @@ -57,6 +57,16 @@ Optional properties:
> - <supply-name>-supply: handle to the regulator device tree node
> optional "supply-name" is "vdd-0.8-cx-mx".
>
> += SUBNODES:
> +wcn3990-wifi node may contain one subnode, named "msa" representing
> +the fixed msa memory regions used by the wifi firmware running in Q6.
> +This sub-node must contain:
Why do you need a sub-node? Just add memory-region property.
> +
> +- memory-region:
> + Usage: required
> + Value type: <phandle>
> + Definition: reference to the reserved-memory for the region
> +
> Example (to supply the calibration data alone):
>
> In this example, the node is defined as child node of the PCI controller.
> @@ -149,4 +159,7 @@ wifi@18000000 {
> <0 140 0 /* CE10 */ >,
> <0 141 0 /* CE11 */ >;
> vdd-0.8-cx-mx-supply = <&pm8998_l5>;
> + msa {
> + memory-region = <&wifi_msa_mem>;
> + };
> };
> --
> 2.17.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Govind Singh <govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
niklas.cassel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 3/6] dt: bindings: add bindings for msa memory region
Date: Wed, 11 Jul 2018 09:27:18 -0600 [thread overview]
Message-ID: <20180711152718.GA18470@rob-hp-laptop> (raw)
In-Reply-To: <20180706090043.28363-1-govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On Fri, Jul 06, 2018 at 02:30:43PM +0530, Govind Singh wrote:
> Add device tree binding documentation details of msa
> memory region for ath10k qmi client for SDM845/APQ8098
> SoC into "qcom,ath10k.txt".
>
> Signed-off-by: Govind Singh <govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> ---
> .../bindings/net/wireless/qcom,ath10k.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> index 7fd4e8ce4149..87489054aea5 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> @@ -57,6 +57,16 @@ Optional properties:
> - <supply-name>-supply: handle to the regulator device tree node
> optional "supply-name" is "vdd-0.8-cx-mx".
>
> += SUBNODES:
> +wcn3990-wifi node may contain one subnode, named "msa" representing
> +the fixed msa memory regions used by the wifi firmware running in Q6.
> +This sub-node must contain:
Why do you need a sub-node? Just add memory-region property.
> +
> +- memory-region:
> + Usage: required
> + Value type: <phandle>
> + Definition: reference to the reserved-memory for the region
> +
> Example (to supply the calibration data alone):
>
> In this example, the node is defined as child node of the PCI controller.
> @@ -149,4 +159,7 @@ wifi@18000000 {
> <0 140 0 /* CE10 */ >,
> <0 141 0 /* CE11 */ >;
> vdd-0.8-cx-mx-supply = <&pm8998_l5>;
> + msa {
> + memory-region = <&wifi_msa_mem>;
> + };
> };
> --
> 2.17.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-07-11 15:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 9:00 [PATCH v3 3/6] dt: bindings: add bindings for msa memory region Govind Singh
2018-07-06 9:00 ` Govind Singh
2018-07-06 9:00 ` Govind Singh
2018-07-10 23:44 ` Brian Norris
2018-07-10 23:44 ` Brian Norris
2018-07-10 23:44 ` Brian Norris
2018-07-11 15:27 ` Rob Herring [this message]
2018-07-11 15:27 ` Rob Herring
2018-07-11 15:27 ` Rob Herring
2018-07-23 12:36 ` Govind Singh
2018-07-23 12:36 ` Govind Singh
2018-07-23 12:36 ` Govind Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711152718.GA18470@rob-hp-laptop \
--to=robh@kernel.org \
--cc=andy.gross@linaro.org \
--cc=ath10k@lists.infradead.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=govinds@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.