From: Christoph Hellwig <hch@infradead.org>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, arnd@arndb.de,
y2038@lists.linaro.org, linux-api@vger.kernel.org
Subject: Re: [PATCH v3 7/7] timex: change syscalls to use struct __kernel_timex
Date: Thu, 12 Jul 2018 01:29:56 -0700 [thread overview]
Message-ID: <20180712082956.GD8802@infradead.org> (raw)
In-Reply-To: <20180707054247.19802-8-deepa.kernel@gmail.com>
On Fri, Jul 06, 2018 at 10:42:47PM -0700, Deepa Dinamani wrote:
> struct timex is not y2038 safe.
> Switch all the syscall apis to use y2038 safe __kernel_timex.
So you switch existing syscalls to use a different structure.
If this actually happens to be safe it needs a big explanation
in the commit log.
> -#ifdef CONFIG_COMPAT
> -
> COMPAT_SYSCALL_DEFINE2(clock_adjtime, clockid_t, which_clock,
> struct compat_timex __user *, utp)
> {
> @@ -1187,10 +1183,6 @@ COMPAT_SYSCALL_DEFINE2(clock_adjtime, clockid_t, which_clock,
> return err;
> }
>
> -#endif
And this unconditionally defines clock_adjtime, but doesn't actually
seem to add callers, which looks rather odd. Same for other bits
in the patch.
next prev parent reply other threads:[~2018-07-12 8:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-07 5:42 [PATCH v3 0/7] Introduce struct __kernel_timex Deepa Dinamani
2018-07-07 5:42 ` Deepa Dinamani
2018-07-07 5:42 ` Deepa Dinamani
2018-07-07 5:42 ` [PATCH v3 1/7] arm64: Make basic compat_* types always available Deepa Dinamani
2018-07-12 8:20 ` Christoph Hellwig
2018-07-07 5:42 ` [PATCH v3 2/7] sparc: Make thread_info.h available directly Deepa Dinamani
2018-07-07 5:42 ` [PATCH v3 3/7] riscv: Delete asm/compat.h Deepa Dinamani
2018-07-07 5:42 ` Deepa Dinamani
2018-07-12 8:14 ` Christoph Hellwig
2018-07-12 8:14 ` Christoph Hellwig
2018-08-03 1:26 ` Palmer Dabbelt
2018-08-03 1:26 ` Palmer Dabbelt
2018-08-03 7:39 ` Christoph Hellwig
2018-08-03 7:39 ` Christoph Hellwig
2018-08-05 21:29 ` Arnd Bergmann
2018-08-05 21:29 ` Arnd Bergmann
2018-07-07 5:42 ` [PATCH v3 4/7] timex: prepare compat helpers for y2038 changes Deepa Dinamani
2018-07-07 5:42 ` [PATCH v3 5/7] time: Add struct __kernel_timex Deepa Dinamani
2018-07-11 9:54 ` Arnd Bergmann
2018-07-12 8:26 ` Christoph Hellwig
2018-07-12 14:53 ` Arnd Bergmann
2018-07-07 5:42 ` [PATCH v3 6/7] timex: use __kernel_timex internally Deepa Dinamani
2018-07-07 14:23 ` Richard Henderson
2018-07-07 14:23 ` Richard Henderson
2018-07-12 8:27 ` Christoph Hellwig
2018-07-07 5:42 ` [PATCH v3 7/7] timex: change syscalls to use struct __kernel_timex Deepa Dinamani
2018-07-12 8:29 ` Christoph Hellwig [this message]
2018-07-12 14:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712082956.GD8802@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.