From: hch@infradead.org (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [PATCH v3 3/7] riscv: Delete asm/compat.h
Date: Thu, 12 Jul 2018 01:14:47 -0700 [thread overview]
Message-ID: <20180712081447.GA28806@infradead.org> (raw)
In-Reply-To: <20180707054247.19802-4-deepa.kernel@gmail.com>
On Fri, Jul 06, 2018 at 10:42:43PM -0700, Deepa Dinamani wrote:
> riscv does not enable CONFIG_COMPAT in default configurations:
> defconfig, allmodconfig and allnoconfig.
> Remove the asm/compat.h as it does not seem to add any value to
> the architecture without CONFIG_COMPAT.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Now that time compat syscalls are being reused in non CONFIG_COMPAT
> modes, asm-generic/compat.h provides definitions for riscv 32 bit
> mode.
>
> Alternative would be to make compat_time.h to be conditional on
> CONFIG_COMPAT_32BIT_TIME. But, since riscv does not does not need
> asm/compat.h, delete it instead.
Except that all this isn't relavant for this patch (and a horribly
bad idea, but ?'ll reply to it separately).
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
y2038@lists.linaro.org, linux-riscv@lists.infradead.org,
palmer@sifive.com, arnd@arndb.de
Subject: Re: [PATCH v3 3/7] riscv: Delete asm/compat.h
Date: Thu, 12 Jul 2018 01:14:47 -0700 [thread overview]
Message-ID: <20180712081447.GA28806@infradead.org> (raw)
In-Reply-To: <20180707054247.19802-4-deepa.kernel@gmail.com>
On Fri, Jul 06, 2018 at 10:42:43PM -0700, Deepa Dinamani wrote:
> riscv does not enable CONFIG_COMPAT in default configurations:
> defconfig, allmodconfig and allnoconfig.
> Remove the asm/compat.h as it does not seem to add any value to
> the architecture without CONFIG_COMPAT.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Now that time compat syscalls are being reused in non CONFIG_COMPAT
> modes, asm-generic/compat.h provides definitions for riscv 32 bit
> mode.
>
> Alternative would be to make compat_time.h to be conditional on
> CONFIG_COMPAT_32BIT_TIME. But, since riscv does not does not need
> asm/compat.h, delete it instead.
Except that all this isn't relavant for this patch (and a horribly
bad idea, but Í'll reply to it separately).
next prev parent reply other threads:[~2018-07-12 8:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-07 5:42 [PATCH v3 0/7] Introduce struct __kernel_timex Deepa Dinamani
2018-07-07 5:42 ` Deepa Dinamani
2018-07-07 5:42 ` Deepa Dinamani
2018-07-07 5:42 ` [PATCH v3 1/7] arm64: Make basic compat_* types always available Deepa Dinamani
2018-07-12 8:20 ` Christoph Hellwig
2018-07-07 5:42 ` [PATCH v3 2/7] sparc: Make thread_info.h available directly Deepa Dinamani
2018-07-07 5:42 ` [PATCH v3 3/7] riscv: Delete asm/compat.h Deepa Dinamani
2018-07-07 5:42 ` Deepa Dinamani
2018-07-12 8:14 ` Christoph Hellwig [this message]
2018-07-12 8:14 ` Christoph Hellwig
2018-08-03 1:26 ` Palmer Dabbelt
2018-08-03 1:26 ` Palmer Dabbelt
2018-08-03 7:39 ` Christoph Hellwig
2018-08-03 7:39 ` Christoph Hellwig
2018-08-05 21:29 ` Arnd Bergmann
2018-08-05 21:29 ` Arnd Bergmann
2018-07-07 5:42 ` [PATCH v3 4/7] timex: prepare compat helpers for y2038 changes Deepa Dinamani
2018-07-07 5:42 ` [PATCH v3 5/7] time: Add struct __kernel_timex Deepa Dinamani
2018-07-11 9:54 ` Arnd Bergmann
2018-07-12 8:26 ` Christoph Hellwig
2018-07-12 14:53 ` Arnd Bergmann
2018-07-07 5:42 ` [PATCH v3 6/7] timex: use __kernel_timex internally Deepa Dinamani
2018-07-07 14:23 ` Richard Henderson
2018-07-07 14:23 ` Richard Henderson
2018-07-12 8:27 ` Christoph Hellwig
2018-07-07 5:42 ` [PATCH v3 7/7] timex: change syscalls to use struct __kernel_timex Deepa Dinamani
2018-07-12 8:29 ` Christoph Hellwig
2018-07-12 14:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712081447.GA28806@infradead.org \
--to=hch@infradead.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.