* [PATCH 0/2] Follow up fixes for SCU3 ESB @ 2018-07-12 2:33 ` Andrey Smirnov 0 siblings, 0 replies; 16+ messages in thread From: Andrey Smirnov @ 2018-07-12 2:33 UTC (permalink / raw) To: linux-arm-kernel Shawn: Here's a couple of fixes for things I missed in the [original-submission]. Sorry about the inconvenience. Thanks, Andrey Smirnov [original-submission] lkml.kernel.org/r/20180711050704.11492-1-andrew.smirnov at gmail.com Andrey Smirnov (2): ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config ARM: dts: imx51-zii-scu3-esb: Fix RAVE SP watchdog compatible string arch/arm/boot/dts/imx51-zii-scu3-esb.dts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 0/2] Follow up fixes for SCU3 ESB @ 2018-07-12 2:33 ` Andrey Smirnov 0 siblings, 0 replies; 16+ messages in thread From: Andrey Smirnov @ 2018-07-12 2:33 UTC (permalink / raw) To: Shawn Guo Cc: Andrey Smirnov, Fabio Estevam, Nikita Yushchenko, Lucas Stach, cphealy, Rob Herring, Mark Rutland, linux-arm-kernel, devicetree, linux-kernel, Andrew Lunn Shawn: Here's a couple of fixes for things I missed in the [original-submission]. Sorry about the inconvenience. Thanks, Andrey Smirnov [original-submission] lkml.kernel.org/r/20180711050704.11492-1-andrew.smirnov@gmail.com Andrey Smirnov (2): ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config ARM: dts: imx51-zii-scu3-esb: Fix RAVE SP watchdog compatible string arch/arm/boot/dts/imx51-zii-scu3-esb.dts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config 2018-07-12 2:33 ` Andrey Smirnov @ 2018-07-12 2:33 ` Andrey Smirnov -1 siblings, 0 replies; 16+ messages in thread From: Andrey Smirnov @ 2018-07-12 2:33 UTC (permalink / raw) To: linux-arm-kernel Add DT code to explicitly configure PAD_AUD3_BB_CK and avoid relying on defaults. Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com> Cc: Lucas Stach <l.stach@pengutronix.de> Cc: cphealy at gmail.com Cc: Shawn Guo <shawnguo@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: linux-arm-kernel at lists.infradead.org Cc: devicetree at vger.kernel.org Cc: linux-kernel at vger.kernel.org Cc: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- arch/arm/boot/dts/imx51-zii-scu3-esb.dts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts index 2941a92d40f1..0bb42c00d72b 100644 --- a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts +++ b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts @@ -221,6 +221,8 @@ interrupts = <20 IRQ_TYPE_LEVEL_HIGH>; interrupt-controller; #interrupt-cells = <2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_switch>; ports { #address-cells = <1>; @@ -426,6 +428,12 @@ >; }; + pinctrl_switch: switchgrp { + fsl,pins = < + MX51_PAD_AUD3_BB_CK__GPIO4_20 0xc5 + >; + }; + pinctrl_uart1: uart1grp { fsl,pins = < MX51_PAD_UART1_RXD__UART1_RXD 0x1c5 -- 2.17.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config @ 2018-07-12 2:33 ` Andrey Smirnov 0 siblings, 0 replies; 16+ messages in thread From: Andrey Smirnov @ 2018-07-12 2:33 UTC (permalink / raw) To: Shawn Guo Cc: Andrey Smirnov, Fabio Estevam, Nikita Yushchenko, Lucas Stach, cphealy, Rob Herring, Mark Rutland, linux-arm-kernel, devicetree, linux-kernel, Andrew Lunn Add DT code to explicitly configure PAD_AUD3_BB_CK and avoid relying on defaults. Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com> Cc: Lucas Stach <l.stach@pengutronix.de> Cc: cphealy@gmail.com Cc: Shawn Guo <shawnguo@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: linux-arm-kernel@lists.infradead.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- arch/arm/boot/dts/imx51-zii-scu3-esb.dts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts index 2941a92d40f1..0bb42c00d72b 100644 --- a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts +++ b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts @@ -221,6 +221,8 @@ interrupts = <20 IRQ_TYPE_LEVEL_HIGH>; interrupt-controller; #interrupt-cells = <2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_switch>; ports { #address-cells = <1>; @@ -426,6 +428,12 @@ >; }; + pinctrl_switch: switchgrp { + fsl,pins = < + MX51_PAD_AUD3_BB_CK__GPIO4_20 0xc5 + >; + }; + pinctrl_uart1: uart1grp { fsl,pins = < MX51_PAD_UART1_RXD__UART1_RXD 0x1c5 -- 2.17.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config 2018-07-12 2:33 ` Andrey Smirnov @ 2018-07-12 13:30 ` Andrew Lunn -1 siblings, 0 replies; 16+ messages in thread From: Andrew Lunn @ 2018-07-12 13:30 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jul 11, 2018 at 07:33:36PM -0700, Andrey Smirnov wrote: > Add DT code to explicitly configure PAD_AUD3_BB_CK and avoid relying > on defaults. > > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: cphealy at gmail.com > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: linux-arm-kernel at lists.infradead.org > Cc: devicetree at vger.kernel.org > Cc: linux-kernel at vger.kernel.org > Cc: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Thanks for adding this. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config @ 2018-07-12 13:30 ` Andrew Lunn 0 siblings, 0 replies; 16+ messages in thread From: Andrew Lunn @ 2018-07-12 13:30 UTC (permalink / raw) To: Andrey Smirnov Cc: Shawn Guo, Fabio Estevam, Nikita Yushchenko, Lucas Stach, cphealy, Rob Herring, Mark Rutland, linux-arm-kernel, devicetree, linux-kernel On Wed, Jul 11, 2018 at 07:33:36PM -0700, Andrey Smirnov wrote: > Add DT code to explicitly configure PAD_AUD3_BB_CK and avoid relying > on defaults. > > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: cphealy@gmail.com > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Thanks for adding this. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config 2018-07-12 2:33 ` Andrey Smirnov @ 2018-07-12 13:37 ` Fabio Estevam -1 siblings, 0 replies; 16+ messages in thread From: Fabio Estevam @ 2018-07-12 13:37 UTC (permalink / raw) To: linux-arm-kernel Hi Andrey, On Wed, Jul 11, 2018 at 11:33 PM, Andrey Smirnov <andrew.smirnov@gmail.com> wrote: > + pinctrl_switch: switchgrp { > + fsl,pins = < > + MX51_PAD_AUD3_BB_CK__GPIO4_20 0xc5 The i.MX51 Reference Manual states that 0xa5 is the default reset value for the register IOMUXC_SW_PAD_CTL_PAD_AUD3_BB_CK. By reading your commit log I had the impression you wanted to provide the default value explicitly. Please clarify. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config @ 2018-07-12 13:37 ` Fabio Estevam 0 siblings, 0 replies; 16+ messages in thread From: Fabio Estevam @ 2018-07-12 13:37 UTC (permalink / raw) To: Andrey Smirnov Cc: Shawn Guo, Nikita Yushchenko, Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-kernel, Rob Herring, Andrew Lunn, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, Fabio Estevam, Chris Healy, Lucas Stach Hi Andrey, On Wed, Jul 11, 2018 at 11:33 PM, Andrey Smirnov <andrew.smirnov@gmail.com> wrote: > + pinctrl_switch: switchgrp { > + fsl,pins = < > + MX51_PAD_AUD3_BB_CK__GPIO4_20 0xc5 The i.MX51 Reference Manual states that 0xa5 is the default reset value for the register IOMUXC_SW_PAD_CTL_PAD_AUD3_BB_CK. By reading your commit log I had the impression you wanted to provide the default value explicitly. Please clarify. ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config 2018-07-12 13:37 ` Fabio Estevam @ 2018-07-13 5:15 ` Andrey Smirnov -1 siblings, 0 replies; 16+ messages in thread From: Andrey Smirnov @ 2018-07-13 5:15 UTC (permalink / raw) To: linux-arm-kernel On Thu, Jul 12, 2018 at 6:37 AM Fabio Estevam <festevam@gmail.com> wrote: > > Hi Andrey, > > On Wed, Jul 11, 2018 at 11:33 PM, Andrey Smirnov > <andrew.smirnov@gmail.com> wrote: > > > + pinctrl_switch: switchgrp { > > + fsl,pins = < > > + MX51_PAD_AUD3_BB_CK__GPIO4_20 0xc5 > > The i.MX51 Reference Manual states that 0xa5 is the default reset > value for the register IOMUXC_SW_PAD_CTL_PAD_AUD3_BB_CK. > > By reading your commit log I had the impression you wanted to provide > the default value explicitly. > > Please clarify. I wanted to avoid relying on defaults be it register reset values or settings that bootloader left us with. Default value of 0xa5 works, but, given how the pin is IRQ_TYPE_LEVEL_HIGH, I though it would be better to configure it to have a pulldown. Do you want me to add that to commit log? Thanks, Andrey Smirnov ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config @ 2018-07-13 5:15 ` Andrey Smirnov 0 siblings, 0 replies; 16+ messages in thread From: Andrey Smirnov @ 2018-07-13 5:15 UTC (permalink / raw) To: Fabio Estevam Cc: Shawn Guo, Nikita Yushchenko, Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-kernel, Rob Herring, Andrew Lunn, linux-arm-kernel, Fabio Estevam, Chris Healy, Lucas Stach On Thu, Jul 12, 2018 at 6:37 AM Fabio Estevam <festevam@gmail.com> wrote: > > Hi Andrey, > > On Wed, Jul 11, 2018 at 11:33 PM, Andrey Smirnov > <andrew.smirnov@gmail.com> wrote: > > > + pinctrl_switch: switchgrp { > > + fsl,pins = < > > + MX51_PAD_AUD3_BB_CK__GPIO4_20 0xc5 > > The i.MX51 Reference Manual states that 0xa5 is the default reset > value for the register IOMUXC_SW_PAD_CTL_PAD_AUD3_BB_CK. > > By reading your commit log I had the impression you wanted to provide > the default value explicitly. > > Please clarify. I wanted to avoid relying on defaults be it register reset values or settings that bootloader left us with. Default value of 0xa5 works, but, given how the pin is IRQ_TYPE_LEVEL_HIGH, I though it would be better to configure it to have a pulldown. Do you want me to add that to commit log? Thanks, Andrey Smirnov ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config 2018-07-13 5:15 ` Andrey Smirnov @ 2018-07-13 11:02 ` Fabio Estevam -1 siblings, 0 replies; 16+ messages in thread From: Fabio Estevam @ 2018-07-13 11:02 UTC (permalink / raw) To: linux-arm-kernel On Fri, Jul 13, 2018 at 2:15 AM, Andrey Smirnov <andrew.smirnov@gmail.com> wrote: > I wanted to avoid relying on defaults be it register reset values or > settings that bootloader left us with. Default value of 0xa5 works, > but, given how the pin is IRQ_TYPE_LEVEL_HIGH, I though it would be > better to configure it to have a pulldown. Do you want me to add that > to commit log? Yes, that would be nice. Thanks ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config @ 2018-07-13 11:02 ` Fabio Estevam 0 siblings, 0 replies; 16+ messages in thread From: Fabio Estevam @ 2018-07-13 11:02 UTC (permalink / raw) To: Andrey Smirnov Cc: Shawn Guo, Nikita Yushchenko, Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-kernel, Rob Herring, Andrew Lunn, linux-arm-kernel, Fabio Estevam, Chris Healy, Lucas Stach On Fri, Jul 13, 2018 at 2:15 AM, Andrey Smirnov <andrew.smirnov@gmail.com> wrote: > I wanted to avoid relying on defaults be it register reset values or > settings that bootloader left us with. Default value of 0xa5 works, > but, given how the pin is IRQ_TYPE_LEVEL_HIGH, I though it would be > better to configure it to have a pulldown. Do you want me to add that > to commit log? Yes, that would be nice. Thanks ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: imx51-zii-scu3-esb: Fix RAVE SP watchdog compatible string 2018-07-12 2:33 ` Andrey Smirnov @ 2018-07-12 2:33 ` Andrey Smirnov -1 siblings, 0 replies; 16+ messages in thread From: Andrey Smirnov @ 2018-07-12 2:33 UTC (permalink / raw) To: linux-arm-kernel It looks like I made a nasty typo in the original patch which resulted in missing watchdog device. Fix it. Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com> Cc: Lucas Stach <l.stach@pengutronix.de> Cc: cphealy at gmail.com Cc: Shawn Guo <shawnguo@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: linux-arm-kernel at lists.infradead.org Cc: devicetree at vger.kernel.org Cc: linux-kernel at vger.kernel.org Cc: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- arch/arm/boot/dts/imx51-zii-scu3-esb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts index 0bb42c00d72b..dffb761a1cc8 100644 --- a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts +++ b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts @@ -325,7 +325,7 @@ #size-cells = <1>; watchdog { - compatible = "zii,rave-sp-watchodg-legacy"; + compatible = "zii,rave-sp-watchdog-legacy"; }; eeprom at a4 { -- 2.17.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: imx51-zii-scu3-esb: Fix RAVE SP watchdog compatible string @ 2018-07-12 2:33 ` Andrey Smirnov 0 siblings, 0 replies; 16+ messages in thread From: Andrey Smirnov @ 2018-07-12 2:33 UTC (permalink / raw) To: Shawn Guo Cc: Andrey Smirnov, Fabio Estevam, Nikita Yushchenko, Lucas Stach, cphealy, Rob Herring, Mark Rutland, linux-arm-kernel, devicetree, linux-kernel, Andrew Lunn It looks like I made a nasty typo in the original patch which resulted in missing watchdog device. Fix it. Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com> Cc: Lucas Stach <l.stach@pengutronix.de> Cc: cphealy@gmail.com Cc: Shawn Guo <shawnguo@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: linux-arm-kernel@lists.infradead.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- arch/arm/boot/dts/imx51-zii-scu3-esb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts index 0bb42c00d72b..dffb761a1cc8 100644 --- a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts +++ b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts @@ -325,7 +325,7 @@ #size-cells = <1>; watchdog { - compatible = "zii,rave-sp-watchodg-legacy"; + compatible = "zii,rave-sp-watchdog-legacy"; }; eeprom@a4 { -- 2.17.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: dts: imx51-zii-scu3-esb: Fix RAVE SP watchdog compatible string 2018-07-12 2:33 ` Andrey Smirnov @ 2018-07-12 17:15 ` Chris Healy -1 siblings, 0 replies; 16+ messages in thread From: Chris Healy @ 2018-07-12 17:15 UTC (permalink / raw) To: linux-arm-kernel Tested-by: Chris Healy <cphealy@gmail.com> watchdog driver loads and works now. On Wed, Jul 11, 2018 at 7:33 PM, Andrey Smirnov <andrew.smirnov@gmail.com> wrote: > It looks like I made a nasty typo in the original patch which resulted > in missing watchdog device. Fix it. > > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: cphealy at gmail.com > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: linux-arm-kernel at lists.infradead.org > Cc: devicetree at vger.kernel.org > Cc: linux-kernel at vger.kernel.org > Cc: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > --- > arch/arm/boot/dts/imx51-zii-scu3-esb.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts > index 0bb42c00d72b..dffb761a1cc8 100644 > --- a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts > +++ b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts > @@ -325,7 +325,7 @@ > #size-cells = <1>; > > watchdog { > - compatible = "zii,rave-sp-watchodg-legacy"; > + compatible = "zii,rave-sp-watchdog-legacy"; > }; > > eeprom at a4 { > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: dts: imx51-zii-scu3-esb: Fix RAVE SP watchdog compatible string @ 2018-07-12 17:15 ` Chris Healy 0 siblings, 0 replies; 16+ messages in thread From: Chris Healy @ 2018-07-12 17:15 UTC (permalink / raw) To: Andrey Smirnov Cc: Shawn Guo, Fabio Estevam, Nikita Yushchenko, Lucas Stach, Rob Herring, Mark Rutland, linux ARM, devicetree, linux-kernel, Andrew Lunn Tested-by: Chris Healy <cphealy@gmail.com> watchdog driver loads and works now. On Wed, Jul 11, 2018 at 7:33 PM, Andrey Smirnov <andrew.smirnov@gmail.com> wrote: > It looks like I made a nasty typo in the original patch which resulted > in missing watchdog device. Fix it. > > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: cphealy@gmail.com > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > --- > arch/arm/boot/dts/imx51-zii-scu3-esb.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts > index 0bb42c00d72b..dffb761a1cc8 100644 > --- a/arch/arm/boot/dts/imx51-zii-scu3-esb.dts > +++ b/arch/arm/boot/dts/imx51-zii-scu3-esb.dts > @@ -325,7 +325,7 @@ > #size-cells = <1>; > > watchdog { > - compatible = "zii,rave-sp-watchodg-legacy"; > + compatible = "zii,rave-sp-watchdog-legacy"; > }; > > eeprom@a4 { > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2018-07-13 11:02 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-07-12 2:33 [PATCH 0/2] Follow up fixes for SCU3 ESB Andrey Smirnov 2018-07-12 2:33 ` Andrey Smirnov 2018-07-12 2:33 ` [PATCH 1/2] ARM: dts: imx51-zii-scu3-esb: Add switch IRQ line pinumx config Andrey Smirnov 2018-07-12 2:33 ` Andrey Smirnov 2018-07-12 13:30 ` Andrew Lunn 2018-07-12 13:30 ` Andrew Lunn 2018-07-12 13:37 ` Fabio Estevam 2018-07-12 13:37 ` Fabio Estevam 2018-07-13 5:15 ` Andrey Smirnov 2018-07-13 5:15 ` Andrey Smirnov 2018-07-13 11:02 ` Fabio Estevam 2018-07-13 11:02 ` Fabio Estevam 2018-07-12 2:33 ` [PATCH 2/2] ARM: dts: imx51-zii-scu3-esb: Fix RAVE SP watchdog compatible string Andrey Smirnov 2018-07-12 2:33 ` Andrey Smirnov 2018-07-12 17:15 ` Chris Healy 2018-07-12 17:15 ` Chris Healy
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.