All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH i-g-t 1/2] igt/gem_gpgpu_fill: Check for GEM before use
Date: Thu, 12 Jul 2018 22:01:12 +0300	[thread overview]
Message-ID: <20180712190112.GG5565@intel.com> (raw)
In-Reply-To: <20180712153709.10125-1-chris@chris-wilson.co.uk>

On Thu, Jul 12, 2018 at 04:37:08PM +0100, Chris Wilson wrote:
> As we need GEM and the GPU to do a GPGPU fill, we should check that it
> is operable before using -- skipping rather than failing when the device
> is wedged.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  tests/gem_gpgpu_fill.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/gem_gpgpu_fill.c b/tests/gem_gpgpu_fill.c
> index 8ef05a3f0..dfb581652 100644
> --- a/tests/gem_gpgpu_fill.c
> +++ b/tests/gem_gpgpu_fill.c
> @@ -104,6 +104,7 @@ igt_simple_main
>  
>  	data.drm_fd = drm_open_driver_render(DRIVER_INTEL);
>  	data.devid = intel_get_drm_devid(data.drm_fd);
> +	igt_require_gem(data.drm_fd);
>  
>  	data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
>  	igt_assert(data.bufmgr);
> -- 
> 2.18.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/2] igt/gem_gpgpu_fill: Check for GEM before use
Date: Thu, 12 Jul 2018 22:01:12 +0300	[thread overview]
Message-ID: <20180712190112.GG5565@intel.com> (raw)
In-Reply-To: <20180712153709.10125-1-chris@chris-wilson.co.uk>

On Thu, Jul 12, 2018 at 04:37:08PM +0100, Chris Wilson wrote:
> As we need GEM and the GPU to do a GPGPU fill, we should check that it
> is operable before using -- skipping rather than failing when the device
> is wedged.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  tests/gem_gpgpu_fill.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/gem_gpgpu_fill.c b/tests/gem_gpgpu_fill.c
> index 8ef05a3f0..dfb581652 100644
> --- a/tests/gem_gpgpu_fill.c
> +++ b/tests/gem_gpgpu_fill.c
> @@ -104,6 +104,7 @@ igt_simple_main
>  
>  	data.drm_fd = drm_open_driver_render(DRIVER_INTEL);
>  	data.devid = intel_get_drm_devid(data.drm_fd);
> +	igt_require_gem(data.drm_fd);
>  
>  	data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
>  	igt_assert(data.bufmgr);
> -- 
> 2.18.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-07-12 19:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12 15:37 [igt-dev] [PATCH i-g-t 1/2] igt/gem_gpgpu_fill: Check for GEM before use Chris Wilson
2018-07-12 15:37 ` Chris Wilson
2018-07-12 15:37 ` [Intel-gfx] [PATCH i-g-t 2/2] lib/gt: Check GEM is operation before injecting a hang Chris Wilson
2018-07-12 15:37   ` Chris Wilson
2018-07-12 18:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] igt/gem_gpgpu_fill: Check for GEM before use Patchwork
2018-07-12 19:01 ` Ville Syrjälä [this message]
2018-07-12 19:01   ` [PATCH i-g-t 1/2] " Ville Syrjälä
2018-07-12 21:12 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180712190112.GG5565@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.