All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: QEMU Developer <qemu-devel@nongnu.org>,
	QEMU Trivial <qemu-trivial@nongnu.org>,
	Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
	qemu-block@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] block: Fix typos in comments (found by codespell)
Date: Thu, 12 Jul 2018 16:39:24 -0400	[thread overview]
Message-ID: <20180712203924.GC3729096@localhost.localdomain> (raw)
In-Reply-To: <20180712195120.27394-1-sw@weilnetz.de>

On Thu, Jul 12, 2018 at 09:51:20PM +0200, Stefan Weil wrote:
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  block.c         | 2 +-
>  block/backup.c  | 4 ++--
>  block/curl.c    | 2 +-
>  block/gluster.c | 2 +-
>  block/vhdx.c    | 2 +-
>  5 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/block.c b/block.c
> index a2fe05ea96..39f373e035 100644
> --- a/block.c
> +++ b/block.c
> @@ -3002,7 +3002,7 @@ BlockReopenQueue *bdrv_reopen_queue(BlockReopenQueue *bs_queue,
>   *
>   * Reopens all BDS specified in the queue, with the appropriate
>   * flags.  All devices are prepared for reopen, and failure of any
> - * device will cause all device changes to be abandonded, and intermediate
> + * device will cause all device changes to be abandoned, and intermediate
>   * data cleaned up.
>   *
>   * If all devices prepare successfully, then the changes are committed
> diff --git a/block/backup.c b/block/backup.c
> index 319fc922e8..8630d32926 100644
> --- a/block/backup.c
> +++ b/block/backup.c
> @@ -91,7 +91,7 @@ static void cow_request_end(CowRequest *req)
>  }
>  
>  /* Copy range to target with a bounce buffer and return the bytes copied. If
> - * error occured, return a negative error number */
> + * error occurred, return a negative error number */
>  static int coroutine_fn backup_cow_with_bounce_buffer(BackupBlockJob *job,
>                                                        int64_t start,
>                                                        int64_t end,
> @@ -148,7 +148,7 @@ fail:
>  
>  }
>  
> -/* Copy range to target and return the bytes copied. If error occured, return a
> +/* Copy range to target and return the bytes copied. If error occurred, return a
>   * negative error number. */
>  static int coroutine_fn backup_cow_with_offload(BackupBlockJob *job,
>                                                  int64_t start,
> diff --git a/block/curl.c b/block/curl.c
> index aa42535783..229bb84a27 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -804,7 +804,7 @@ static int curl_open(BlockDriverState *bs, QDict *options, int flags,
>      }
>      /* Prior CURL 7.19.4 return value of 0 could mean that the file size is not
>       * know or the size is zero. From 7.19.4 CURL returns -1 if size is not
> -     * known and zero if it is realy zero-length file. */
> +     * known and zero if it is really zero-length file. */
>  #if LIBCURL_VERSION_NUM >= 0x071304
>      if (d < 0) {
>          pstrcpy(state->errmsg, CURL_ERROR_SIZE,
> diff --git a/block/gluster.c b/block/gluster.c
> index a4e1c8ecd8..4fd55a9cc5 100644
> --- a/block/gluster.c
> +++ b/block/gluster.c
> @@ -1326,7 +1326,7 @@ static int qemu_gluster_has_zero_init(BlockDriverState *bs)
>   * If @start is in a trailing hole or beyond EOF, return -ENXIO.
>   * If we can't find out, return a negative errno other than -ENXIO.
>   *
> - * (Shamefully copied from file-posix.c, only miniscule adaptions.)
> + * (Shamefully copied from file-posix.c, only minuscule adaptions.)
>   */
>  static int find_allocation(BlockDriverState *bs, off_t start,
>                             off_t *data, off_t *hole)
> diff --git a/block/vhdx.c b/block/vhdx.c
> index 4d0819750f..0795ca1985 100644
> --- a/block/vhdx.c
> +++ b/block/vhdx.c
> @@ -185,7 +185,7 @@ uint32_t vhdx_checksum_calc(uint32_t crc, uint8_t *buf, size_t size,
>  /* Validates the checksum of the buffer, with an in-place CRC.
>   *
>   * Zero is substituted during crc calculation for the original crc field,
> - * and the crc field is restored afterwards.  But the buffer will be modifed
> + * and the crc field is restored afterwards.  But the buffer will be modified

Oops, that one was mine.

>   * during the calculation, so this may not be not suitable for multi-threaded
>   * use.
>   *
> -- 
> 2.11.0
> 


Reviewed-by: Jeff Cody <jcody@redhat.com>



WARNING: multiple messages have this Message-ID (diff)
From: Jeff Cody <jcody@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: QEMU Developer <qemu-devel@nongnu.org>,
	QEMU Trivial <qemu-trivial@nongnu.org>,
	Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
	qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: Fix typos in comments (found by codespell)
Date: Thu, 12 Jul 2018 16:39:24 -0400	[thread overview]
Message-ID: <20180712203924.GC3729096@localhost.localdomain> (raw)
In-Reply-To: <20180712195120.27394-1-sw@weilnetz.de>

On Thu, Jul 12, 2018 at 09:51:20PM +0200, Stefan Weil wrote:
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  block.c         | 2 +-
>  block/backup.c  | 4 ++--
>  block/curl.c    | 2 +-
>  block/gluster.c | 2 +-
>  block/vhdx.c    | 2 +-
>  5 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/block.c b/block.c
> index a2fe05ea96..39f373e035 100644
> --- a/block.c
> +++ b/block.c
> @@ -3002,7 +3002,7 @@ BlockReopenQueue *bdrv_reopen_queue(BlockReopenQueue *bs_queue,
>   *
>   * Reopens all BDS specified in the queue, with the appropriate
>   * flags.  All devices are prepared for reopen, and failure of any
> - * device will cause all device changes to be abandonded, and intermediate
> + * device will cause all device changes to be abandoned, and intermediate
>   * data cleaned up.
>   *
>   * If all devices prepare successfully, then the changes are committed
> diff --git a/block/backup.c b/block/backup.c
> index 319fc922e8..8630d32926 100644
> --- a/block/backup.c
> +++ b/block/backup.c
> @@ -91,7 +91,7 @@ static void cow_request_end(CowRequest *req)
>  }
>  
>  /* Copy range to target with a bounce buffer and return the bytes copied. If
> - * error occured, return a negative error number */
> + * error occurred, return a negative error number */
>  static int coroutine_fn backup_cow_with_bounce_buffer(BackupBlockJob *job,
>                                                        int64_t start,
>                                                        int64_t end,
> @@ -148,7 +148,7 @@ fail:
>  
>  }
>  
> -/* Copy range to target and return the bytes copied. If error occured, return a
> +/* Copy range to target and return the bytes copied. If error occurred, return a
>   * negative error number. */
>  static int coroutine_fn backup_cow_with_offload(BackupBlockJob *job,
>                                                  int64_t start,
> diff --git a/block/curl.c b/block/curl.c
> index aa42535783..229bb84a27 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -804,7 +804,7 @@ static int curl_open(BlockDriverState *bs, QDict *options, int flags,
>      }
>      /* Prior CURL 7.19.4 return value of 0 could mean that the file size is not
>       * know or the size is zero. From 7.19.4 CURL returns -1 if size is not
> -     * known and zero if it is realy zero-length file. */
> +     * known and zero if it is really zero-length file. */
>  #if LIBCURL_VERSION_NUM >= 0x071304
>      if (d < 0) {
>          pstrcpy(state->errmsg, CURL_ERROR_SIZE,
> diff --git a/block/gluster.c b/block/gluster.c
> index a4e1c8ecd8..4fd55a9cc5 100644
> --- a/block/gluster.c
> +++ b/block/gluster.c
> @@ -1326,7 +1326,7 @@ static int qemu_gluster_has_zero_init(BlockDriverState *bs)
>   * If @start is in a trailing hole or beyond EOF, return -ENXIO.
>   * If we can't find out, return a negative errno other than -ENXIO.
>   *
> - * (Shamefully copied from file-posix.c, only miniscule adaptions.)
> + * (Shamefully copied from file-posix.c, only minuscule adaptions.)
>   */
>  static int find_allocation(BlockDriverState *bs, off_t start,
>                             off_t *data, off_t *hole)
> diff --git a/block/vhdx.c b/block/vhdx.c
> index 4d0819750f..0795ca1985 100644
> --- a/block/vhdx.c
> +++ b/block/vhdx.c
> @@ -185,7 +185,7 @@ uint32_t vhdx_checksum_calc(uint32_t crc, uint8_t *buf, size_t size,
>  /* Validates the checksum of the buffer, with an in-place CRC.
>   *
>   * Zero is substituted during crc calculation for the original crc field,
> - * and the crc field is restored afterwards.  But the buffer will be modifed
> + * and the crc field is restored afterwards.  But the buffer will be modified

Oops, that one was mine.

>   * during the calculation, so this may not be not suitable for multi-threaded
>   * use.
>   *
> -- 
> 2.11.0
> 


Reviewed-by: Jeff Cody <jcody@redhat.com>

  parent reply	other threads:[~2018-07-12 20:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12 19:51 [Qemu-trivial] [PATCH] block: Fix typos in comments (found by codespell) Stefan Weil
2018-07-12 19:51 ` [Qemu-devel] " Stefan Weil
2018-07-12 20:32 ` [Qemu-trivial] [Qemu-block] " John Snow
2018-07-12 20:32   ` [Qemu-devel] " John Snow
2018-07-20 21:14   ` [Qemu-trivial] " Eric Blake
2018-07-20 21:14     ` Eric Blake
2018-07-12 20:39 ` Jeff Cody [this message]
2018-07-12 20:39   ` [Qemu-devel] " Jeff Cody
2018-07-13  8:03 ` [Qemu-trivial] " Kevin Wolf
2018-07-13  8:03   ` [Qemu-devel] " Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180712203924.GC3729096@localhost.localdomain \
    --to=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.