From: Lee Jones <lee.jones@linaro.org>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] mfd: hi655x: Fix regmap area declared size for hi655x
Date: Fri, 13 Jul 2018 08:27:08 +0100 [thread overview]
Message-ID: <20180713072708.GL4641@dell> (raw)
In-Reply-To: <20180706172833.533-1-rafael.tinoco@linaro.org>
On Fri, 06 Jul 2018, Rafael David Tinoco wrote:
> Fixes: https://bugs.linaro.org/show_bug.cgi?id=3903
>
> LTP Functional tests have caused a bad paging request when triggering
> the regmap_read_debugfs() logic of the device PMIC Hi6553 (reading
> regmap/f8000000.pmic/registers file during read_all test):
>
> Unable to handle kernel paging request at virtual address ffff0
> [ffff00000984e000] pgd=0000000077ffe803, pud=0000000077ffd803,0
> Internal error: Oops: 96000007 [#1] SMP
> ...
> Hardware name: HiKey Development Board (DT)
> ...
> Call trace:
> regmap_mmio_read8+0x24/0x40
> regmap_mmio_read+0x48/0x70
> _regmap_bus_reg_read+0x38/0x48
> _regmap_read+0x68/0x170
> regmap_read+0x50/0x78
> regmap_read_debugfs+0x1a0/0x308
> regmap_map_read_file+0x48/0x58
> full_proxy_read+0x68/0x98
> __vfs_read+0x48/0x80
> vfs_read+0x94/0x150
> SyS_read+0x6c/0xd8
> el0_svc_naked+0x30/0x34
> Code: aa1e03e0 d503201f f9400280 8b334000 (39400000)
>
> Investigations have showed that, when triggered by debugfs read()
> handler, the mmio regmap logic was reading a bigger (16k) register area
> than the one mapped by devm_ioremap_resource() during hi655x-pmic probe
> time (4k).
>
> This commit changes hi655x's max register, according to HW specs, to be
> the same as the one declared in the pmic device in hi6220's dts, fixing
> the issue.
>
> Signed-off-by: Rafael David Tinoco <rafael.tinoco@linaro.org>
> Cc: <stable@vger.kernel.org> #v4.9 #v4.14 #v4.16 #v4.17
> ---
> drivers/mfd/hi655x-pmic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Rafael David Tinoco <rafael.tinoco@linaro.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
puck.chen@hisilicon.com, john.stultz@linaro.org,
ltp@lists.linux.it, lkft-triage@lists.linaro.org
Subject: Re: [PATCH] mfd: hi655x: Fix regmap area declared size for hi655x
Date: Fri, 13 Jul 2018 08:27:08 +0100 [thread overview]
Message-ID: <20180713072708.GL4641@dell> (raw)
In-Reply-To: <20180706172833.533-1-rafael.tinoco@linaro.org>
On Fri, 06 Jul 2018, Rafael David Tinoco wrote:
> Fixes: https://bugs.linaro.org/show_bug.cgi?id=3903
>
> LTP Functional tests have caused a bad paging request when triggering
> the regmap_read_debugfs() logic of the device PMIC Hi6553 (reading
> regmap/f8000000.pmic/registers file during read_all test):
>
> Unable to handle kernel paging request at virtual address ffff0
> [ffff00000984e000] pgd=0000000077ffe803, pud=0000000077ffd803,0
> Internal error: Oops: 96000007 [#1] SMP
> ...
> Hardware name: HiKey Development Board (DT)
> ...
> Call trace:
> regmap_mmio_read8+0x24/0x40
> regmap_mmio_read+0x48/0x70
> _regmap_bus_reg_read+0x38/0x48
> _regmap_read+0x68/0x170
> regmap_read+0x50/0x78
> regmap_read_debugfs+0x1a0/0x308
> regmap_map_read_file+0x48/0x58
> full_proxy_read+0x68/0x98
> __vfs_read+0x48/0x80
> vfs_read+0x94/0x150
> SyS_read+0x6c/0xd8
> el0_svc_naked+0x30/0x34
> Code: aa1e03e0 d503201f f9400280 8b334000 (39400000)
>
> Investigations have showed that, when triggered by debugfs read()
> handler, the mmio regmap logic was reading a bigger (16k) register area
> than the one mapped by devm_ioremap_resource() during hi655x-pmic probe
> time (4k).
>
> This commit changes hi655x's max register, according to HW specs, to be
> the same as the one declared in the pmic device in hi6220's dts, fixing
> the issue.
>
> Signed-off-by: Rafael David Tinoco <rafael.tinoco@linaro.org>
> Cc: <stable@vger.kernel.org> #v4.9 #v4.14 #v4.16 #v4.17
> ---
> drivers/mfd/hi655x-pmic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-07-13 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 17:28 [LTP] [PATCH] mfd: hi655x: Fix regmap area declared size for hi655x Rafael David Tinoco
2018-07-06 17:28 ` Rafael David Tinoco
2018-07-13 7:27 ` Lee Jones [this message]
2018-07-13 7:27 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713072708.GL4641@dell \
--to=lee.jones@linaro.org \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.