From: Greg KH <gregkh@linuxfoundation.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: linux-pm@vger.kernel.org, rjw@rjwysocki.net, robh+dt@kernel.org,
mturquette@baylibre.com, khilman@baylibre.com,
abailon@baylibre.com, vincent.guittot@linaro.org,
skannan@codeaurora.org, bjorn.andersson@linaro.org,
amit.kucheria@linaro.org, seansw@qti.qualcomm.com,
daidavid1@codeaurora.org, evgreen@chromium.org, mka@chromium.org,
mark.rutland@arm.com, lorenzo.pieralisi@arm.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v6 3/8] interconnect: Add debugfs support
Date: Sun, 15 Jul 2018 14:15:07 +0200 [thread overview]
Message-ID: <20180715121507.GA17794@kroah.com> (raw)
In-Reply-To: <20180709155104.25528-4-georgi.djakov@linaro.org>
On Mon, Jul 09, 2018 at 06:50:59PM +0300, Georgi Djakov wrote:
> +static int __init icc_debugfs_init(void)
> +{
> + struct dentry *file;
> +
> + icc_debugfs_dir = debugfs_create_dir("interconnect", NULL);
> + if (!icc_debugfs_dir) {
> + pr_err("interconnect: error creating debugfs directory\n");
> + return -ENODEV;
> + }
You should never care about the return value of a debugfs call. Just
ignore it and move on.
> + file = debugfs_create_file("interconnect_summary", 0444,
> + icc_debugfs_dir, NULL, &icc_summary_fops);
> + if (!file)
> + return -ENODEV;
Again, do not check this.
Where do you remove this directory and file from the system when the
code shuts down?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 3/8] interconnect: Add debugfs support
Date: Sun, 15 Jul 2018 14:15:07 +0200 [thread overview]
Message-ID: <20180715121507.GA17794@kroah.com> (raw)
In-Reply-To: <20180709155104.25528-4-georgi.djakov@linaro.org>
On Mon, Jul 09, 2018 at 06:50:59PM +0300, Georgi Djakov wrote:
> +static int __init icc_debugfs_init(void)
> +{
> + struct dentry *file;
> +
> + icc_debugfs_dir = debugfs_create_dir("interconnect", NULL);
> + if (!icc_debugfs_dir) {
> + pr_err("interconnect: error creating debugfs directory\n");
> + return -ENODEV;
> + }
You should never care about the return value of a debugfs call. Just
ignore it and move on.
> + file = debugfs_create_file("interconnect_summary", 0444,
> + icc_debugfs_dir, NULL, &icc_summary_fops);
> + if (!file)
> + return -ENODEV;
Again, do not check this.
Where do you remove this directory and file from the system when the
code shuts down?
thanks,
greg k-h
next prev parent reply other threads:[~2018-07-15 12:15 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 15:50 [PATCH v6 0/8] Introduce on-chip interconnect API Georgi Djakov
2018-07-09 15:50 ` Georgi Djakov
2018-07-09 15:50 ` [PATCH v6 1/8] interconnect: Add generic " Georgi Djakov
2018-07-09 15:50 ` Georgi Djakov
2018-07-10 22:34 ` Evan Green
2018-07-10 22:34 ` Evan Green
2018-07-20 14:31 ` Georgi Djakov
2018-07-20 14:31 ` Georgi Djakov
2018-07-11 15:05 ` Alexandre Bailon
2018-07-11 15:05 ` Alexandre Bailon
2018-07-11 16:21 ` Alexandre Bailon
2018-07-11 16:21 ` Alexandre Bailon
2018-07-20 14:33 ` Georgi Djakov
2018-07-20 14:33 ` Georgi Djakov
2018-07-09 15:50 ` [PATCH v6 2/8] dt-bindings: Introduce interconnect provider bindings Georgi Djakov
2018-07-09 15:50 ` Georgi Djakov
2018-07-09 15:50 ` [PATCH v6 3/8] interconnect: Add debugfs support Georgi Djakov
2018-07-09 15:50 ` Georgi Djakov
2018-07-15 12:15 ` Greg KH [this message]
2018-07-15 12:15 ` Greg KH
2018-07-20 14:36 ` Georgi Djakov
2018-07-20 14:36 ` Georgi Djakov
2018-07-09 15:51 ` [PATCH v6 4/8] interconnect: qcom: Add RPM communication Georgi Djakov
2018-07-09 15:51 ` Georgi Djakov
2018-07-09 15:51 ` Georgi Djakov
2018-07-10 22:34 ` Evan Green
2018-07-10 22:34 ` Evan Green
2018-07-20 14:39 ` Georgi Djakov
2018-07-20 14:39 ` Georgi Djakov
2018-07-09 15:51 ` [PATCH v6 5/8] dt-bindings: interconnect: Document qcom,msm8916 NoC bindings Georgi Djakov
2018-07-09 15:51 ` [PATCH v6 5/8] dt-bindings: interconnect: Document qcom, msm8916 " Georgi Djakov
2018-07-09 15:51 ` [PATCH v6 6/8] interconnect: qcom: Add msm8916 interconnect provider driver Georgi Djakov
2018-07-09 15:51 ` Georgi Djakov
2018-07-09 23:56 ` Matthias Kaehlcke
2018-07-09 23:56 ` Matthias Kaehlcke
2018-07-20 14:46 ` Georgi Djakov
2018-07-20 14:46 ` Georgi Djakov
2018-07-10 22:34 ` Evan Green
2018-07-10 22:34 ` Evan Green
2018-07-10 22:34 ` Evan Green
2018-07-20 14:50 ` Georgi Djakov
2018-07-20 14:50 ` Georgi Djakov
2018-07-11 15:42 ` Alexandre Bailon
2018-07-11 15:42 ` Alexandre Bailon
2018-07-20 14:55 ` Georgi Djakov
2018-07-20 14:55 ` Georgi Djakov
2018-07-09 15:51 ` [PATCH v6 7/8] dt-bindings: Introduce interconnect consumers bindings Georgi Djakov
2018-07-09 15:51 ` Georgi Djakov
2018-07-10 22:34 ` Evan Green
2018-07-10 22:34 ` Evan Green
2018-07-10 22:34 ` Evan Green
2018-07-20 14:57 ` Georgi Djakov
2018-07-20 14:57 ` Georgi Djakov
2018-07-09 15:51 ` [PATCH v6 8/8] interconnect: Allow endpoints translation via DT Georgi Djakov
2018-07-09 15:51 ` Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180715121507.GA17794@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abailon@baylibre.com \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=seansw@qti.qualcomm.com \
--cc=skannan@codeaurora.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.